Build fix and addressed feedback

Author: nyurik

compiler/rustc_codegen_gcc/build_system/src/utils.rs

@@ -21,17 +21,17 @@ fn exec_command(
 ) -> Result<ExitStatus, String> {
     let status = get_command_inner(input, cwd, env)
         .spawn()
-        .map_err(|e| command_error(input, &cwd, e))?
+        .map_err(|e| command_error(input, cwd, e))?
         .wait()
-        .map_err(|e| command_error(input, &cwd, e))?;
+        .map_err(|e| command_error(input, cwd, e))?;
     #[cfg(unix)]
     {
         if let Some(signal) = status.signal() {
             unsafe {
                 raise(signal as _);
             }
             // In case the signal didn't kill the current process.
-            return Err(command_error(input, &cwd, format!("Process received signal {}", signal)));
+            return Err(command_error(input, cwd, format!("Process received signal {}", signal)));
         }
     }
     Ok(status)
@@ -112,7 +112,7 @@ pub fn run_command_with_env(
     env: Option<&HashMap<String, String>>,
 ) -> Result<Output, String> {
     let output =
-        get_command_inner(input, cwd, env).output().map_err(|e| command_error(input, &cwd, e))?;
+        get_command_inner(input, cwd, env).output().map_err(|e| command_error(input, cwd, e))?;
     check_exit_status(input, cwd, output.status, Some(&output), true)?;
     Ok(output)
 }

compiler/rustc_session/src/config.rs

@@ -2092,8 +2092,8 @@ fn parse_assert_incr_state(
     opt_assertion: Option<&str>,
 ) -> Option<IncrementalStateAssertion> {
     match opt_assertion {
-        Some(s) if s == "loaded" => Some(IncrementalStateAssertion::Loaded),
-        Some(s) if s == "not-loaded" => Some(IncrementalStateAssertion::NotLoaded),
+        Some("loaded") => Some(IncrementalStateAssertion::Loaded),
+        Some("not-loaded") => Some(IncrementalStateAssertion::NotLoaded),
         Some(s) => {
             early_dcx.early_fatal(format!("unexpected incremental state assertion value: {s}"))
         }