Improve fidelity of rustc-crates-on-stable test

Author: jieyouxu

tests/run-make/rustc-crates-on-stable/rmake.rs

@@ -4,13 +4,16 @@
 use run_make_support::{cargo, rustc_path, source_root};
 
 fn main() {
-    // Use the stage0 beta cargo for the compilation (it shouldn't really matter which cargo we use)
+    // NOTE: in the follow cargo invocation, make sure that no unstable cargo flags are used! We
+    // want to check that these compiler crates can compile on the stable channel, which includes
+    // treating this cargo as if it was a stable cargo!
     cargo()
-        // Ensure `proc-macro2`'s nightly detection is disabled
+        // Ensure `proc-macro2`'s nightly detection is disabled. `proc-macro2` bails its nightly
+        // detection if it detects `RUSTC_STAGE` getting set.
         .env("RUSTC_STAGE", "0")
         .env("RUSTC", rustc_path())
-        // We want to disallow all nightly features to simulate a stable build
-        .env("RUSTFLAGS", "-Zallow-features=")
+        // This forces the underlying rustc to think it is a stable rustc.
+        .env("RUSTC_BOOTSTRAP", "-1")
         .arg("build")
         .arg("--manifest-path")
         .arg(source_root().join("Cargo.toml"))