try not to break the logic

Author: lolbinarycat

compiler/rustc_resolve/src/rustdoc.rs

@@ -574,7 +574,7 @@ pub fn source_span_for_markdown_range(
                 // because it matches the pattern,
                 // which is checked to not be zero sized.
                 if match_data.is_none()
-                    && !snippet.as_bytes().windows(pat.len()).any(|s| s == pat.as_bytes())
+                    && !snippet.as_bytes()[1..].windows(pat.len()).any(|s| s == pat.as_bytes())
                 {
                     match_data = Some((i, match_start));
                 } else {

tests/rustdoc-ui/lints/bare-urls.fixed

@@ -38,13 +38,13 @@
 //~^ ERROR this URL is not a hyperlink
 pub fn c() {}
 
-#[doc = "here's a thing: <https://example.com/>"]
+#[doc = "here's a thing: https://example.com/"]
 //~^ ERROR this URL is not a hyperlink
 pub fn f() {}
 
-/// <https://example.com/sugar>
+/// https://example.com/sugar
 //~^ ERROR this URL is not a hyperlink
-#[doc = "<https://example.com/raw>"]
+#[doc = "https://example.com/raw"]
 //~^ ERROR this URL is not a hyperlink
 pub fn mixed() {}
 

tests/rustdoc-ui/lints/bare-urls.stderr

@@ -208,40 +208,33 @@ LL | /// hey! <https://somewhere.com/a?hello=12&bye=11#xyz>
    |          +                                           +
 
 error: this URL is not a hyperlink
-  --> $DIR/bare-urls.rs:41:26
+  --> $DIR/bare-urls.rs:41:9
    |
 LL | #[doc = "here's a thing: https://example.com/"]
-   |                          ^^^^^^^^^^^^^^^^^^^^
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: bare URLs are not automatically turned into clickable links
-help: use an automatic link instead
-   |
-LL | #[doc = "here's a thing: <https://example.com/>"]
-   |                          +                    +
 
 error: this URL is not a hyperlink
-  --> $DIR/bare-urls.rs:45:5
+  --> $DIR/bare-urls.rs:45:1
    |
-LL | /// https://example.com/sugar
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
+LL | / /// https://example.com/sugar
+LL | |
+LL | | #[doc = "https://example.com/raw"]
+   | |_________________________________^
    |
    = note: bare URLs are not automatically turned into clickable links
-help: use an automatic link instead
-   |
-LL | /// <https://example.com/sugar>
-   |     +                         +
 
 error: this URL is not a hyperlink
-  --> $DIR/bare-urls.rs:47:10
+  --> $DIR/bare-urls.rs:45:1
    |
-LL | #[doc = "https://example.com/raw"]
-   |          ^^^^^^^^^^^^^^^^^^^^^^^
+LL | / /// https://example.com/sugar
+LL | |
+LL | | #[doc = "https://example.com/raw"]
+   | |_________________________________^
    |
    = note: bare URLs are not automatically turned into clickable links
-help: use an automatic link instead
-   |
-LL | #[doc = "<https://example.com/raw>"]
-   |          +                       +
+   = note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`
 
 error: aborting due to 20 previous errors
 

tests/rustdoc-ui/unescaped_backticks.stderr

@@ -628,21 +628,21 @@ LL | /// or even to add a number `n` to 42 (`add(42, n)\`)!
    |                                                   +
 
 error: unescaped backtick
-  --> $DIR/unescaped_backticks.rs:108:10
+  --> $DIR/unescaped_backticks.rs:108:9
    |
 LL | #[doc = "`"]
-   |          ^
+   |         ^^^
    |
    = help: the opening or closing backtick of an inline code may be missing
    = help: if you meant to use a literal backtick, escape it
             change: `
            to this: \`
 
 error: unescaped backtick
-  --> $DIR/unescaped_backticks.rs:115:26
+  --> $DIR/unescaped_backticks.rs:115:9
    |
 LL | #[doc = concat!("\\", "`")]
-   |                          ^
+   |         ^^^^^^^^^^^^^^^^^^^^
    |
    = help: the opening backtick of an inline code may be missing
             change: \`