Split inner impl block and method

Author: mejrs

tests/ui/attributes/positions/README.md

@@ -20,7 +20,7 @@ Or perhaps you've seen a discussion get derailed by a [comment](https://github.c
 > fn main() {
 >     f(#[cold] || {});
 > }
-> 
+>
 > fn f(_: impl Fn()) {}
 > ```
 
@@ -105,9 +105,6 @@ pub mod module {
 
     #[ATTRIBUTE] //~ WARN
     impl<'lt, T> Struct<'lt, T> {
-        #![ATTRIBUTE] //~ WARN
-        //~^ WARN unused attribute
-        //~^^ WARN this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
         #[ATTRIBUTE] //~ WARN
         pub fn method(#[ATTRIBUTE] &mut self) { //~ ERROR allow, cfg, cfg_attr, deny, expect, forbid, and warn are the only allowed built-in attributes in function parameters
@@ -159,6 +156,14 @@ pub mod module {
 pub mod inner_module {
     #![ATTRIBUTE] //~ WARN
 
+    impl<'lt, T> super::module::Struct<'lt, T> {
+        #![ATTRIBUTE] //~ WARN
+
+        pub fn inner_method(&mut self) {
+            #![ATTRIBUTE] //~ ERROR
+        }
+    }
+
     fn x() {
         const {
             #![ATTRIBUTE] //~ WARN

tests/ui/attributes/positions/allow.rs

@@ -65,7 +65,7 @@ pub mod module {
 
     #[allow()] // OK
     impl<'lt, T> Struct<'lt, T> {
-        #![allow()] // OK
+
         #[allow()] // OK
         pub fn method(#[allow()] &mut self) {  // OK
 
@@ -112,6 +112,14 @@ pub mod module {
 pub mod inner_module {
     #![allow()] // OK
 
+    impl<'lt, T> super::module::Struct<'lt, T> {
+        #![allow()] // OK
+
+        pub fn inner_method(&mut self) {
+            #![allow()] // OK
+        }
+    }
+
     fn x() {
         const {
             #![allow()] // OK

tests/ui/attributes/positions/allow.stderr

@@ -9,7 +9,7 @@ LL |             #[allow()]
    = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date
 
 error[E0658]: attributes on expressions are experimental
-  --> $DIR/allow.rs:124:20
+  --> $DIR/allow.rs:132:20
    |
 LL |     let _closure = #[allow()]
    |                    ^^^^^^^^^^
@@ -19,7 +19,7 @@ LL |     let _closure = #[allow()]
    = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date
 
 error[E0658]: attributes on expressions are experimental
-  --> $DIR/allow.rs:127:25
+  --> $DIR/allow.rs:135:25
    |
 LL |     let _move_closure = #[allow()]
    |                         ^^^^^^^^^^
@@ -29,7 +29,7 @@ LL |     let _move_closure = #[allow()]
    = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date
 
 error[E0658]: attributes on expressions are experimental
-  --> $DIR/allow.rs:137:22
+  --> $DIR/allow.rs:145:22
    |
 LL |         let _array = #[allow()]
    |                      ^^^^^^^^^^
@@ -39,7 +39,7 @@ LL |         let _array = #[allow()]
    = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date
 
 error[E0658]: attributes on expressions are experimental
-  --> $DIR/allow.rs:143:22
+  --> $DIR/allow.rs:151:22
    |
 LL |         let _tuple = #[allow()]
    |                      ^^^^^^^^^^

tests/ui/attributes/positions/must_use.rs

@@ -66,9 +66,6 @@ pub mod module {
 
     #[must_use] //~ WARN
     impl<'lt, T> Struct<'lt, T> {
-        #![must_use] //~ WARN
-        //~^ WARN unused attribute
-        //~^^ WARN this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
         #[must_use] // OK
         pub fn method(#[must_use] &mut self) { //~ ERROR allow, cfg, cfg_attr, deny, expect, forbid, and warn are the only allowed built-in attributes in function parameters
@@ -121,6 +118,14 @@ pub mod module {
 pub mod inner_module {
     #![must_use] //~ WARN
 
+    impl<'lt, T> super::module::Struct<'lt, T> {
+        #![must_use] //~ WARN
+
+        pub fn inner_method(&mut self) {
+            #![must_use] // OK
+        }
+    }
+
     fn x() {
         const {
             #![must_use] //~ WARN