MVP of tidy watcher

Author: klensy

Cargo.lock

@@ -5463,6 +5463,7 @@ dependencies = [
  "cargo_metadata 0.15.4",
  "ignore",
  "lazy_static",
+ "md-5",
  "miropt-test-tools",
  "regex",
  "semver",

compiler/rustc_ast/src/token.rs

@@ -104,6 +104,7 @@ impl Lit {
         }
     }
 
+    // tidy-ticket-ast-from_token
     /// Keep this in sync with `Token::can_begin_literal_or_bool` excluding unary negation.
     pub fn from_token(token: &Token) -> Option<Lit> {
         match token.uninterpolate().kind {
@@ -118,6 +119,7 @@ impl Lit {
             _ => None,
         }
     }
+    // tidy-ticket-ast-from_token
 }
 
 impl fmt::Display for Lit {
@@ -571,6 +573,7 @@ impl Token {
     ///
     /// In other words, would this token be a valid start of `parse_literal_maybe_minus`?
     ///
+    // tidy-ticket-ast-can_begin_literal_maybe_minus
     /// Keep this in sync with and `Lit::from_token`, excluding unary negation.
     pub fn can_begin_literal_maybe_minus(&self) -> bool {
         match self.uninterpolate().kind {
@@ -590,6 +593,7 @@ impl Token {
             _ => false,
         }
     }
+    // tidy-ticket-ast-can_begin_literal_maybe_minus
 
     /// A convenience function for matching on identifiers during parsing.
     /// Turns interpolated identifier (`$i: ident`) or lifetime (`$l: lifetime`) token

compiler/rustc_builtin_macros/src/assert/context.rs

@@ -290,6 +290,7 @@ impl<'cx, 'a> Context<'cx, 'a> {
             }
             // Expressions that are not worth or can not be captured.
             //
+            // tidy-ticket-all-expr-kinds
             // Full list instead of `_` to catch possible future inclusions and to
             // sync with the `rfc-2011-nicer-assert-messages/all-expr-kinds.rs` test.
             ExprKind::Assign(_, _, _)
@@ -321,6 +322,7 @@ impl<'cx, 'a> Context<'cx, 'a> {
             | ExprKind::Yeet(_)
             | ExprKind::Become(_)
             | ExprKind::Yield(_) => {}
+            // tidy-ticket-all-expr-kinds
         }
     }
 

compiler/rustc_codegen_ssa/src/back/write.rs

@@ -711,6 +711,7 @@ impl<B: WriteBackendMethods> WorkItem<B> {
         }
     }
 
+    // tidy-ticket-short_description
     /// Generate a short description of this work item suitable for use as a thread name.
     fn short_description(&self) -> String {
         // `pthread_setname()` on *nix ignores anything beyond the first 15
@@ -758,6 +759,7 @@ impl<B: WriteBackendMethods> WorkItem<B> {
             WorkItem::LTO(m) => desc("lto", "LTO module", m.name()),
         }
     }
+    // tidy-ticket-short_description
 }
 
 /// A result produced by the backend.

compiler/rustc_const_eval/src/interpret/projection.rs

@@ -167,6 +167,7 @@ where
                 None => {
                     // For unsized types with an extern type tail we perform no adjustments.
                     // NOTE: keep this in sync with `PlaceRef::project_field` in the codegen backend.
+                    // FIXME: that one? compiler/rustc_codegen_ssa/src/mir/place.rs
                     assert!(matches!(base_meta, MemPlaceMeta::None));
                     (base_meta, offset)
                 }

compiler/rustc_const_eval/src/interpret/validity.rs

@@ -511,6 +511,7 @@ impl<'rt, 'mir, 'tcx: 'mir, M: Machine<'mir, 'tcx>> ValidityVisitor<'rt, 'mir, '
                 Ok(true)
             }
             ty::Float(_) | ty::Int(_) | ty::Uint(_) => {
+                // tidy-ticket-try_visit_primitive
                 // NOTE: Keep this in sync with the array optimization for int/float
                 // types below!
                 self.read_scalar(
@@ -522,6 +523,7 @@ impl<'rt, 'mir, 'tcx: 'mir, M: Machine<'mir, 'tcx>> ValidityVisitor<'rt, 'mir, '
                     },
                 )?;
                 Ok(true)
+                // tidy-ticket-try_visit_primitive
             }
             ty::RawPtr(..) => {
                 let place =
@@ -784,6 +786,7 @@ impl<'rt, 'mir, 'tcx: 'mir, M: Machine<'mir, 'tcx>> ValueVisitor<'mir, 'tcx, M>
                     }
                 };
 
+                // tidy-ticket-visit_value
                 // Optimization: we just check the entire range at once.
                 // NOTE: Keep this in sync with the handling of integer and float
                 // types above, in `visit_primitive`.
@@ -820,6 +823,7 @@ impl<'rt, 'mir, 'tcx: 'mir, M: Machine<'mir, 'tcx>> ValueVisitor<'mir, 'tcx, M>
                         }
                     }
                 }
+                // tidy-ticket-visit_value
             }
             // Fast path for arrays and slices of ZSTs. We only need to check a single ZST element
             // of an array and not all of them, because there's only a single value of a specific

compiler/rustc_data_structures/src/profiling.rs

@@ -125,6 +125,7 @@ bitflags::bitflags! {
     }
 }
 
+// tidy-ticket-self-profile-events
 // keep this in sync with the `-Z self-profile-events` help message in rustc_session/options.rs
 const EVENT_FILTERS_BY_NAME: &[(&str, EventFilter)] = &[
     ("none", EventFilter::empty()),
@@ -142,6 +143,7 @@ const EVENT_FILTERS_BY_NAME: &[(&str, EventFilter)] = &[
     ("incr-result-hashing", EventFilter::INCR_RESULT_HASHING),
     ("artifact-sizes", EventFilter::ARTIFACT_SIZES),
 ];
+// tidy-ticket-self-profile-events
 
 /// Something that uniquely identifies a query invocation.
 pub struct QueryInvocationId(pub u32);

compiler/rustc_errors/src/json.rs

@@ -322,6 +322,8 @@ struct FutureIncompatReport {
     future_incompat_report: Vec<FutureBreakageItem>,
 }
 
+// tidy-ticket-UnusedExterns
+// FIXME: where it located in cargo?
 // NOTE: Keep this in sync with the equivalent structs in rustdoc's
 // doctest component (as well as cargo).
 // We could unify this struct the one in rustdoc but they have different
@@ -333,6 +335,7 @@ struct UnusedExterns<'a, 'b, 'c> {
     /// List of unused externs by their names.
     unused_extern_names: &'b [&'c str],
 }
+// tidy-ticket-UnusedExterns
 
 impl Diagnostic {
     fn from_errors_diagnostic(diag: &crate::Diagnostic, je: &JsonEmitter) -> Diagnostic {

compiler/rustc_hir_analysis/src/check/region.rs

@@ -119,6 +119,7 @@ fn resolve_block<'tcx>(visitor: &mut RegionResolutionVisitor<'tcx>, blk: &'tcx h
     visitor.cx.var_parent = visitor.cx.parent;
 
     {
+        // FIXME: sync with exactly where?
         // This block should be kept approximately in sync with
         // `intravisit::walk_block`. (We manually walk the block, rather
         // than call `walk_block`, in order to maintain precise

compiler/rustc_hir_analysis/src/lib.rs

@@ -206,10 +206,12 @@ pub fn check_crate(tcx: TyCtxt<'_>) -> Result<(), ErrorGuaranteed> {
         tcx.hir().try_par_for_each_module(|module| tcx.ensure().check_mod_type_wf(module))
     });
 
+    // tidy-ticket-sess-time-item_types_checking
     // NOTE: This is copy/pasted in librustdoc/core.rs and should be kept in sync.
     tcx.sess.time("item_types_checking", || {
         tcx.hir().for_each_module(|module| tcx.ensure().check_mod_item_types(module))
     });
+    // tidy-ticket-sess-time-item_types_checking
 
     // HACK: `check_mod_type_wf` may spuriously emit errors due to `delay_span_bug`, even if those errors
     // only actually get emitted in `check_mod_item_types`.