run spellchecker in separate job

Author: klensy

.github/workflows/ci.yml

@@ -58,6 +58,22 @@ jobs:
           COMMIT_MESSAGE: ${{ github.event.head_commit.message }}
         run: python3 src/ci/github-actions/calculate-job-matrix.py >> $GITHUB_OUTPUT
         id: jobs
+
+  spellcheck:
+    name: run spellchecker
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout the source code
+        uses: actions/checkout@v4
+
+      - name: check typos
+        # sync version with src/tools/tidy/src/ext_tool_checks.rs
+        uses: crate-ci/[email protected]
+        with:
+        # sync target files with src/tools/tidy/src/ext_tool_checks.rs
+          files: ./compiler ./library
+          config: ./typos.toml
+
   job:
     name: ${{ matrix.name }}
     needs: [ calculate_matrix ]
@@ -104,18 +120,6 @@ jobs:
         with:
           fetch-depth: 2
 
-      - name: check typos
-        id: typo_check
-        if: ${{ env.CI_JOB_NAME == 'mingw-check-tidy' }}
-        # don't fail job on typos
-        continue-on-error: true
-        # sync version with src/tools/tidy/src/ext_tool_checks.rs
-        uses: crate-ci/[email protected]
-        with:
-        # sync target files with src/tools/tidy/src/ext_tool_checks.rs
-          files: ./compiler ./library
-          config: ./typos.toml
-
       # Free up disk space on Linux by removing preinstalled components that
       # we do not need. We do this to enable some of the less resource
       # intensive jobs to run on free runners, which however also have
@@ -250,15 +254,6 @@ jobs:
           npm install -g @datadog/datadog-ci@^2.x.x
           python3 src/ci/scripts/upload-build-metrics.py build/cpu-usage.csv
 
-      # If pr have typos, we don't fail immediately, but allow job to continue,
-      # but still want job to fail at the end. Without this, job will be marked as
-      # 'success', even if there is typos, so fail it manually.
-      #
-      # also see https://github.com/actions/runner/issues/2347
-      - name: check typos
-        if: ${{ env.CI_JOB_NAME == 'mingw-check-tidy' && steps.typo_check.outcome == 'failure' && steps.typo_check.conclusion == 'success' }}
-        run: exit 1
-
   # This job isused to tell bors the final status of the build, as there is no practical way to detect
   # when a workflow is successful listening to webhooks only in our current bors implementation (homu).
   outcome: