Add FIXME in src/tools/miri/src/shims/native_lib.rs

Strophox · RalfJung · web-flow · commit e383a47b415a · 2024-11-22T13:28:17.000+01:00
Co-authored-by: Ralf Jung &lt;post@ralfj.de&gt;
diff --git a/src/tools/miri/src/shims/native_lib.rs b/src/tools/miri/src/shims/native_lib.rs
@@ -168,6 +168,9 @@ pub trait EvalContextExt<'tcx>: crate::MiriInterpCxExt<'tcx> {
                 this.prepare_for_native_call(alloc_id, prov)?;
             }
         }
+        
+        // FIXME: In the future, we should also call `prepare_for_native_call` on all previously
+        // exposed allocations, since C may access any of them.
 
         // Convert them to `libffi::high::Arg` type.
         let libffi_args = libffi_args

Original file line number	Diff line number	Diff line change
`@@ -168,6 +168,9 @@ pub trait EvalContextExt<'tcx>: crate::MiriInterpCxExt<'tcx> {`
`168`	`168`	`this.prepare_for_native_call(alloc_id, prov)?;`
`169`	`169`	`}`
`170`	`170`	`}`
	`171`	`+`
	`172`	+ // FIXME: In the future, we should also call `prepare_for_native_call` on all previously
	`173`	`+ // exposed allocations, since C may access any of them.`
`171`	`174`
`172`	`175`	// Convert them to `libffi::high::Arg` type.
`173`	`176`	`let libffi_args = libffi_args`