fail manually

Author: klensy

.github/workflows/ci.yml

@@ -105,6 +105,7 @@ jobs:
           fetch-depth: 2
 
       - name: check typos
+        id: typo_check
         if: ${{ env.CI_JOB_NAME == 'mingw-check-tidy' }}
         # don't fail job on typos
         continue-on-error: true
@@ -247,6 +248,15 @@ jobs:
           npm install -g @datadog/datadog-ci@^2.x.x
           python3 src/ci/scripts/upload-build-metrics.py build/cpu-usage.csv
 
+      # If pr have typos, we don't fail immediately, but allow job to continue,
+      # but still want job to fail at the end. Without this, job will be marked as
+      # 'success', even if there is typos, so fail it manually.
+      #
+      # also see https://github.com/actions/runner/issues/2347
+      - name: check typos
+        if: ${{ env.CI_JOB_NAME == 'mingw-check-tidy' && steps.typo_check.outcome == 'failure' && steps.typo_check.conclusion == 'success' }}
+        run: exit 1
+
   # This job isused to tell bors the final status of the build, as there is no practical way to detect
   # when a workflow is successful listening to webhooks only in our current bors implementation (homu).
   outcome: