add with no visible path if doc hidden

Author: Kohei316

compiler/rustc_hir_typeck/src/method/suggest.rs

@@ -23,8 +23,10 @@ use rustc_hir::{self as hir, ExprKind, HirId, Node, PathSegment, QPath};
 use rustc_infer::infer::{self, RegionVariableOrigin};
 use rustc_middle::bug;
 use rustc_middle::ty::fast_reject::{DeepRejectCtxt, TreatParams, simplify_type};
+#[allow(unused_imports)]
 use rustc_middle::ty::print::{
-    PrintTraitRefExt as _, with_crate_prefix, with_forced_trimmed_paths,
+    PrintTraitRefExt as _, with_crate_prefix, with_forced_trimmed_paths, with_no_trimmed_paths,
+    with_no_visible_paths, with_no_visible_paths_if_doc_hidden,
 };
 use rustc_middle::ty::{self, GenericArgKind, IsSuggestable, Ty, TyCtxt, TypeVisitableExt};
 use rustc_span::def_id::DefIdSet;
@@ -3337,15 +3339,19 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                 // );
                 format!(
                     "{prefix}{}{postfix}\n",
-                    with_crate_prefix!(self.tcx.def_path_str(*trait_did)),
+                    with_no_visible_paths_if_doc_hidden!(with_crate_prefix!(
+                        self.tcx.def_path_str(*trait_did)
+                    )),
                 )
             });
 
             let glob_path_strings = globs.iter().map(|trait_did| {
                 let parent_did = parent_map.get(trait_did).unwrap();
                 format!(
                     "{prefix}{}::*{postfix} // trait {}\n",
-                    with_crate_prefix!(self.tcx.def_path_str(*parent_did)),
+                    with_no_visible_paths_if_doc_hidden!(with_crate_prefix!(
+                        self.tcx.def_path_str(*parent_did)
+                    )),
                     self.tcx.item_name(*trait_did),
                 )
             });

compiler/rustc_middle/src/ty/print/pretty.rs

@@ -63,6 +63,7 @@ thread_local! {
     static FORCE_TRIMMED_PATH: Cell<bool> = const { Cell::new(false) };
     static REDUCED_QUERIES: Cell<bool> = const { Cell::new(false) };
     static NO_VISIBLE_PATH: Cell<bool> = const { Cell::new(false) };
+    static NO_VISIBLE_PATH_IF_DOC_HIDDEN: Cell<bool> = const { Cell::new(false) };
     static RTN_MODE: Cell<RtnMode> = const { Cell::new(RtnMode::ForDiagnostic) };
 }
 
@@ -134,6 +135,7 @@ define_helper!(
     /// Prevent selection of visible paths. `Display` impl of DefId will prefer
     /// visible (public) reexports of types as paths.
     fn with_no_visible_paths(NoVisibleGuard, NO_VISIBLE_PATH);
+    fn with_no_visible_paths_if_doc_hidden(NoVisibleIfDocHiddenGuard, NO_VISIBLE_PATH_IF_DOC_HIDDEN);
 );
 
 #[must_use]
@@ -491,6 +493,9 @@ pub trait PrettyPrinter<'tcx>: Printer<'tcx> + fmt::Write {
         callers: &mut Vec<DefId>,
     ) -> Result<bool, PrintError> {
         // debug!("try_print_visible_def_path: def_id={:?}", def_id);
+        if self.tcx().is_doc_hidden(def_id) && with_no_visible_paths_if_doc_hidden() {
+            return Ok(false);
+        }
 
         // If `def_id` is a direct or injected extern crate, return the
         // path to the crate followed by the path to the item within the crate.

tests/ui/issues/issue-127011.stderr

@@ -7,7 +7,7 @@ LL |     Bar::foo();
    = help: items from traits can only be used if the trait is in scope
 help: trait `Foo` which provides `foo` is implemented but not in scope; perhaps you want to import it
    |
-LL + use issue_127011_a::Foo;
+LL + use issue_127011_b::Foo;
    |
 
 error: aborting due to 1 previous error