-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Open
Labels
A-CIArea: Our Github Actions CIArea: Our Github Actions CIA-test-infraArea: test infrastructure (may span bootstrap/compiletest/more)Area: test infrastructure (may span bootstrap/compiletest/more)C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.T-rust-analyzerRelevant to the rust-analyzer team, which will review and decide on the PR/issue.Relevant to the rust-analyzer team, which will review and decide on the PR/issue.
Description
Summary
Currently, we only run a tiny subset of r-a tests (namely proc-macro-srv
). We would like to make sure r-a is well-tested against Tier 1 platforms, and catch more r-a (and even rustc-induced) regressions, by running the main r-a tests as well.
Steps
- Teach bootstrap to run main rust-analyzer tests. Run main rust-analyzer tests in rust-lang/rust CI #147372
- Update bootstrap r-a test setup.
- Teach remaining rust-analyzer crates about in-tree
rustc_private
crates.
- Figure out which rust-analyzer tests we need to disable for now against r-l/r CI through a bunch of try jobs and track them here.
- Monitor r-a test failures.
Follow-ups
- Teach r-a to use something like
RUST_ANALYZER_TEST_DIR
so tests produce output to writable directory in CI. cf. Run main rust-analyzer tests in rust-lang/rust CI #147372 (comment).
Disabled tests
Important
Crucially, we should make sure we know why given r-a tests are disabled.
-
src/tools/rust-analyzer/xtask
: they seem to exercise stable rustup/rustfmt, seems out-of-scope for our purposes. -
tests::smoke_test_real_sysroot_cargo
: needs access to in-tree rustc somehow
Implementation history
Metadata
Metadata
Assignees
Labels
A-CIArea: Our Github Actions CIArea: Our Github Actions CIA-test-infraArea: test infrastructure (may span bootstrap/compiletest/more)Area: test infrastructure (may span bootstrap/compiletest/more)C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.T-rust-analyzerRelevant to the rust-analyzer team, which will review and decide on the PR/issue.Relevant to the rust-analyzer team, which will review and decide on the PR/issue.