Skip to content

Conversation

nidnogg
Copy link
Contributor

@nidnogg nidnogg commented Aug 16, 2022

This PR includes some migrations to the new diagnostics API for the rustc_expand module.
r? @davidtwco

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 16, 2022
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @davidtwco (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2022
@compiler-errors compiler-errors added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Aug 17, 2022
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, will wait until you're happy to un-draft this to merge.

@davidtwco davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2022
@rust-log-analyzer

This comment was marked as resolved.

@nidnogg nidnogg marked this pull request as ready for review August 17, 2022 16:53
@nidnogg nidnogg requested a review from davidtwco August 17, 2022 16:53
@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 17, 2022

📌 Commit a468f13 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 17, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 17, 2022
…nd_transcribe, r=davidtwco

Migrations for rustc_expand transcribe.rs

This PR includes some migrations to the new diagnostics API for the `rustc_expand` module.
r? `@davidtwco`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 17, 2022
…twco

tidy: check fluent files for style

Inspired by rust-lang#100651 (comment)

There were a lot of line length violations, so I've excepted that lint - I'm not sure if fluent files can be formatted to avoid long lines at all.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 17, 2022
…nd_transcribe, r=davidtwco

Migrations for rustc_expand transcribe.rs

This PR includes some migrations to the new diagnostics API for the `rustc_expand` module.
r? ``@davidtwco``
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 18, 2022
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#97962 (Make must_not_suspend lint see through references when drop tracking is enabled)
 - rust-lang#99966 (avoid assertion failures in try_to_scalar_int)
 - rust-lang#100637 (Improving Fuchsia rustc support documentation)
 - rust-lang#100643 (Point at a type parameter shadowing another type)
 - rust-lang#100651 (Migrations for rustc_expand transcribe.rs)
 - rust-lang#100669 (Attribute cleanups)
 - rust-lang#100670 (Fix documentation of rustc_parse::parser::Parser::parse_stmt_without_recovery)
 - rust-lang#100674 (Migrate lint reports in typeck::check_unused to LintDiagnostic)
 - rust-lang#100688 (`ty::Error` does not match other types for region constraints)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8b180ed into rust-lang:master Aug 18, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 18, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 22, 2022
tidy: check fluent files for style

Inspired by rust-lang#100651 (comment)

There were a lot of line length violations, so I've excepted that lint - I'm not sure if fluent files can be formatted to avoid long lines at all.
@davidtwco davidtwco mentioned this pull request Aug 23, 2022
84 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants