Don't use rustc_hir as ast(!)
#110387
Merged
Don't use rustc_hir as ast(!)
#110387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes for confusing code. This was introduced in a large commit in rust-lang#67886 that rearranged a lot of `use` statements. I suspect it was an accident.
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors rollup |
|
r? @fee1-dead @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2023
…fee1-dead Rollup of 3 pull requests Successful merges: - rust-lang#110376 (Convert comment to doc comment on `Interner::get`.) - rust-lang#110379 (Update some ignored tests.) - rust-lang#110387 (Don't `use rustc_hir as ast`(!)) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes for confusing code.
This was introduced in a large commit in #67886 that rearranged a lot of
usestatements. I suspect it was an accident.