* although
* correct
* granular
* libunwind
* repository
* section

Signed-off-by: Josh Soref <[email protected]>

* architecture
* configures
* preparation
* toolstate
* unknown

Signed-off-by: Josh Soref <[email protected]>

This is no longer necessary now that the llvm in `rust-dev` matches the
one in `rustc`.

Bootstrap was setting LD_LIBRARY_PATH for bootstrap tools in `tool_cmd`,
and rustc inherited that environment. That broke when download-rustc was
enabled; see the new comment for details.

When building locally, we never generate a `share` directory in the
local sysroot. However, when we download the `rustc` component from ci,
it includes a `share/man` directory in the sysroot. The
`run-make/translation` test assumed that it didn't exist, and would
create a link from `fakeroot` to the real share directory, and write
symbolic links into it. Change it not to create the link, so that rustc
doesn't try to load multiple copies of the same `.ftl` file.

…correct exit code

Before, it only worked for numbers, not strings.

This also makes some other minor cleanups:
- Suggest `python x.py` on windows instead of `./x.py`, which usually
  doesn't work
- Move the "Configure and Make" section to a subsection of "Building on
  Unix"
- Mention `config.toml` earlier
- Suggest `x.py setup user` on Windows, since `configure` won't work

'./configure' now checks if 'config.toml' exists before writing to that destination

Fixes rust-lang#110109

Instead of overwriting the current `config.toml` file, exit the `./configure` script with a message stating why.

…lbertlarsan68

Spelling src bootstrap

The various src/* items seem slightly disparate, so I'm doing src/* individually.

split from rust-lang#110392

…rsan68

Spelling src ci

The various src/* items seem slightly disparate, so I'm doing src/* individually.

split from rust-lang#110392

…rtlarsan68

Don't special-case download-rustc in `maybe_install_llvm`

This is no longer necessary now that the llvm in `rust-dev` matches the one in `rustc`.

cc rust-lang#110490 (comment), rust-lang#110263

…san68

Fix `x test lint-docs linkchecker` when download-rustc is enabled

Bootstrap was setting LD_LIBRARY_PATH for bootstrap tools in `tool_cmd`, and rustc inherited that environment. That broke when download-rustc was enabled; see the new comment for details.

Fixes rust-lang#110354

… r=albertlarsan68

Fix `tests/run-make-translation` when download-rustc is enabled

When building locally, we never generate a `share` directory in the local sysroot. However, when we download the `rustc` component from ci, it includes a `share/man` directory in the sysroot. The `run-make/translation` test assumed that it didn't exist, and would create a link from `fakeroot` to the real share directory, and write symbolic links into it. Change it not to create the link, so that rustc doesn't try to load multiple copies of the same `.ftl` file.

Fixes rust-lang#110357.

small type system cleanup

…l-trait-not-public, r=notriddle

Missing blanket impl trait not public

Fixes rust-lang#94183.

The problem was that we should have checked if the trait was reachable instead of only "directly public".

r? `@notriddle`

Fix wrong comment in rustc_hir/src/hir.rs

Fix various configure bugs

Fixes rust-lang#107050. Fixes rust-lang#108928. Closes rust-lang#108641.

I recommend reading this commit-by-commit to see the commit descriptions, but the code changes are small.

This also changes the README to suggest `configure` instead of `printf`, as well as a few other cleanups described in the commit message.