Rollup of 8 pull requests #115326

matthiaskrgr · 2023-08-28T17:53:59Z

Successful merges:

MIR validation: reject in-place argument/return for packed fields #115164 (MIR validation: reject in-place argument/return for packed fields)
codegen_llvm/llvm_type: avoid matching on the Rust type #115240 (codegen_llvm/llvm_type: avoid matching on the Rust type)
More precisely detect cycle errors from type_of on opaque #115294 (More precisely detect cycle errors from type_of on opaque)
Document panic behavior across editions, and improve xrefs #115310 (Document panic behavior across editions, and improve xrefs)
Revert "Suggest using Arc on !Send/!Sync types" #115311 (Revert "Suggest using Arc on !Send/!Sync types")
Devacationize oli-obk #115317 (Devacationize oli-obk)
don't use SnapshotVec in Graph implementation, as it looks unused; use Vec instead #115319 (don't use SnapshotVec in Graph implementation, as it looks unused; use Vec instead)
Tweak output of to_pretty_impl_header involving only anon lifetimes #115322 (Tweak output of to_pretty_impl_header involving only anon lifetimes)

r? @ghost
@rustbot modify labels: rollup

Having a section for this inspired by the docs for array::IntoIterator

That xref contains the actual documentation for what format! does. It should be very prominent - particularly, more so than the other links.

This reverts commit 6ec570a.

This reverts commit 9de1a47.

…e Vec instead

it was already unused before, but due to the recursion the compiler did not realize

Do not print `impl<> Foo for &Bar`.

…aber MIR validation: reject in-place argument/return for packed fields As discussed [here](https://rust-lang.zulipchat.com/#narrow/stream/136281-t-opsem/topic/Packed.20fields.20and.20in-place.20function.20argument.2Freturn.20passing).

codegen_llvm/llvm_type: avoid matching on the Rust type This `match` is highly suspicious. Looking at `scalar_llvm_type_at` I think it makes no difference. But if it were to make a difference that would be a huge problem, since it doesn't look through `repr(transparent)`! Cc `@eddyb` `@bjorn3`

More precisely detect cycle errors from type_of on opaque Not sure if this still needs work. Just putting it up for initial impressions, since it seems that a few people are frustrated with the increased error verbosity due to rust-lang#113320. Essentially we introduce a new sub-query for `type_of` specifically for opaques which returns a value that is able to distinguish "has errors" from "due to cycle recovery". Fixes rust-lang#115188 r? `@oli-obk`

Document panic behavior across editions, and improve xrefs This revives (parts of) rust-lang#96518. r? `@scottmcm` Cc `@ijackson`

Revert "Suggest using `Arc` on `!Send`/`!Sync` types" Closes rust-lang#114687. This is a clean revert of rust-lang#88936 + rust-lang#115210. The suggestion to Arc\<{Self}\> when Self does not implement Send is *always* wrong. rust-lang#114842 is considering a way to make a more refined suggestion.

Devacationize oli-obk r? `@oli-obk` `@bors` r+ rollup

…fleLapkin don't use SnapshotVec in Graph implementation, as it looks unused; use Vec instead `Graph` don't use `SnapshotVec` methods, so use simple `Vec` instead?

…rors Tweak output of `to_pretty_impl_header` involving only anon lifetimes Do not print `impl<> Foo for &Bar`.

matthiaskrgr · 2023-08-28T18:06:39Z

@bors r+ rollup=never p=8

bors · 2023-08-28T18:06:41Z

📌 Commit 07a32e2 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-08-28T19:57:35Z

⌛ Testing commit 07a32e2 with merge 4e78abb...

bors · 2023-08-28T21:47:41Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 4e78abb to master...

rust-timer · 2023-08-28T21:49:58Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#115164	MIR validation: reject in-place argument/return for packed …	`b3dd094c739ba856f5c605df2da6d9c7dead4af8` (link)
#115240	codegen_llvm/llvm_type: avoid matching on the Rust type	`4373bab8e3c702585c83e782c61b3f84dd3785be` (link)
#115294	More precisely detect cycle errors from type_of on opaque	`f354f380c7b8cfd7dfdd96085b84617fd5886771` (link)
#115310	Document panic behavior across editions, and improve xrefs	`6c0be83a519f598d766ff30e13756238ba490d71` (link)
#115311	Revert "Suggest using `Arc` on `!Send`/`!Sync` types"	`104e92738a85c8bc65c81783e28a50e55b673f5d` (link)
#115317	Devacationize oli-obk	`8e06ca22ebc5da176852a019b62d513403236849` (link)
#115319	don't use SnapshotVec in Graph implementation, as it looks …	`316480ee00aca6e6657d64a7f9e7ee4c44ad5291` (link)
#115322	Tweak output of `to_pretty_impl_header` involving only anon…	`515cc0e7fe24230cfb299da0859c5d05dc541ac2` (link)

previous master: 93dd620241

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-08-29T01:56:29Z

Finished benchmarking commit (4e78abb): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-0.7%, -0.7%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.167s -> 631.054s (-0.02%)
Artifact size: 316.30 MiB -> 316.21 MiB (-0.03%)

RalfJung and others added 25 commits August 24, 2023 11:38

MIR validation: reject in-place argument/return for packed fields

739144f

codegen_llvm/llvm_type: avoid matching on the Rust type

0fde82f

Pass ErrorGuaranteed to cycle error

e7b3c94

More precisely detect cycle errors from type_of on opaque

bf53598

panic macro: Document edition differences

1116707

Having a section for this inspired by the docs for array::IntoIterator

print macros: add xrefs to format syntax documentation

55159e8

panic macro: Link directly to format syntax, not to format!

2ec8b6b

format, format_args: Make xref to std::fmt much more prominent

39c642e

That xref contains the actual documentation for what format! does. It should be very prominent - particularly, more so than the other links.

improve panic.md edition disucssion, and nits

5016695

Revert "Make rustc_on_unimplemented std-agnostic for alloc::rc"

4120936

This reverts commit 6ec570a.

Revert "Suggest using Arc on !Send/!Sync types"

823bacb

This reverts commit 9de1a47.

also avoid matching on the type in scalar_pair_element_llvm_type

dc70fb6

carry out the same changes in the gcc backend

99d76a4

Devacationize oli-obk

5a4ba68

don't use SnapshotVec in Graph implementation, as it looks unused; us…

3b26b3d

…e Vec instead

remove an unused argument

9b9cb51

it was already unused before, but due to the recursion the compiler did not realize

Tweak output of to_pretty_impl_header involving only anon lifetimes

ecf2f68

Do not print `impl<> Foo for &Bar`.

Rollup merge of rust-lang#115310 - RalfJung:panic-and-format, r=scottmcm

2eff0de

Document panic behavior across editions, and improve xrefs This revives (parts of) rust-lang#96518. r? `@scottmcm` Cc `@ijackson`

Rollup merge of rust-lang#115317 - oli-obk:no_moar_vacation, r=oli-obk

7b6d264

Devacationize oli-obk r? `@oli-obk` `@bors` r+ rollup

Rollup merge of rust-lang#115319 - klensy:no-snapshot-in-graph, r=Waf…

de6b03b

…fleLapkin don't use SnapshotVec in Graph implementation, as it looks unused; use Vec instead `Graph` don't use `SnapshotVec` methods, so use simple `Vec` instead?

Rollup merge of rust-lang#115322 - estebank:list-tweak, r=compiler-er…

07a32e2

…rors Tweak output of `to_pretty_impl_header` involving only anon lifetimes Do not print `impl<> Foo for &Bar`.

rustbot added the rollup A PR which is a rollup label Aug 28, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 28, 2023

bors merged commit 4e78abb into rust-lang:master Aug 28, 2023

rustbot added this to the 1.74.0 milestone Aug 28, 2023

matthiaskrgr deleted the rollup-qsoa8ar branch March 16, 2024 18:19

matthiaskrgr mentioned this pull request Mar 27, 2024

univariant: field #2 comes after unsized field #123134

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 8 pull requests #115326

Rollup of 8 pull requests #115326

Uh oh!

matthiaskrgr commented Aug 28, 2023

Uh oh!

matthiaskrgr commented Aug 28, 2023

Uh oh!

bors commented Aug 28, 2023

Uh oh!

bors commented Aug 28, 2023

Uh oh!

bors commented Aug 28, 2023

Uh oh!

rust-timer commented Aug 28, 2023

Uh oh!

rust-timer commented Aug 29, 2023

Uh oh!

Uh oh!

Rollup of 8 pull requests #115326

Rollup of 8 pull requests #115326

Uh oh!

Conversation

matthiaskrgr commented Aug 28, 2023

Uh oh!

matthiaskrgr commented Aug 28, 2023

Uh oh!

bors commented Aug 28, 2023

Uh oh!

bors commented Aug 28, 2023

Uh oh!

bors commented Aug 28, 2023

Uh oh!

rust-timer commented Aug 28, 2023

Uh oh!

rust-timer commented Aug 29, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!