Explain why `non_snake_case` is skipped for binary crates and cleanup tests #130599

jieyouxu · 2024-09-20T05:38:03Z

Explain non_snake_case lint is skipped for bin crate names because binaries are not intended to be distributed or consumed like library crates (Don't enforce snake_case for binary names #45127).
Coalesce the bunch of tests into a single one but with revisions, which is easier to compare the differences for non_snake_case behavior with respect to crate types.

Follow-up to #121749 with some more comments and test cleanup.

cc @saethlin who bumped into one of the tests and was confused why it was only-x86_64-unknown-linux-gnu.

try-job: dist-i586-gnu-i586-i686-musl

rustbot · 2024-09-20T05:38:11Z

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2024-09-20T05:38:36Z

@bors rollup=iffy (this might bounce due to unsupported crate types for specific targets, but it's probably better to ignore when necessary instead of just running this for x86_64-unknown-linux-gnu).

Zalathar · 2024-09-20T07:08:04Z

I notice that this also gets rid of two extra bin tests that set the crate type and crate name in a variety of ways.

I don't object to that, but I just want to double-check that it was intentional.

jieyouxu · 2024-09-20T07:13:17Z

I notice that this also gets rid of two extra bin tests that set the crate type and crate name in a variety of ways.

I dropped those versions because AFAICT when the check for executable crate type is skipped, the different ways to set crate types/names are indistinguishable to the check as part of a late lint pass. I can add them back in if you think those should be retained.

Zalathar · 2024-09-20T07:17:59Z

Nah, if there's no reason to think the extra variants will be useful then it seems fine to get rid of them.

tests/ui/lint/non-snake-case/lint-non-snake-case-crate.rs

petrochenkov · 2024-09-20T16:38:29Z

r=me with #130599 (comment) answered.
@rustbot author

petrochenkov · 2024-09-20T20:22:46Z

@bors r+

bors · 2024-09-20T20:22:49Z

📌 Commit aebc28e has been approved by petrochenkov

It is now in the queue for this repository.

…r=petrochenkov Explain why `non_snake_case` is skipped for binary crates and cleanup tests - Explain `non_snake_case` lint is skipped for bin crate names because binaries are not intended to be distributed or consumed like library crates (rust-lang#45127). - Coalesce the bunch of tests into a single one but with revisions, which is easier to compare the differences for `non_snake_case` behavior with respect to crate types. Follow-up to rust-lang#121749 with some more comments and test cleanup. cc `@saethlin` who bumped into one of the tests and was confused why it was `only-x86_64-unknown-linux-gnu`.

jieyouxu · 2024-09-21T05:42:59Z

@bors try

tests/ui/lint/non-snake-case/lint-non-snake-case-crate.rs

bors · 2024-09-21T05:44:09Z

⌛ Trying commit 9ae1fb4 with merge 883506d...

…r=<try> Explain why `non_snake_case` is skipped for binary crates and cleanup tests - Explain `non_snake_case` lint is skipped for bin crate names because binaries are not intended to be distributed or consumed like library crates (rust-lang#45127). - Coalesce the bunch of tests into a single one but with revisions, which is easier to compare the differences for `non_snake_case` behavior with respect to crate types. Follow-up to rust-lang#121749 with some more comments and test cleanup. cc `@saethlin` who bumped into one of the tests and was confused why it was `only-x86_64-unknown-linux-gnu`. try-job: dist-i586-gnu-i586-i686-musl

bors · 2024-09-21T06:58:23Z

☀️ Try build successful - checks-actions
Build commit: 883506d (883506d9cd1bcb4c442d6823eba69952f7f92be9)

jieyouxu · 2024-09-21T07:05:30Z

Changes since last review:

Fix test failure by changing to ignore-musl for both cdylib and dylib (musl AFAIK doesn't support dylibs in general)

@rustbot ready

petrochenkov · 2024-09-21T09:52:09Z

@bors r+

bors · 2024-09-21T09:52:12Z

📌 Commit 9ae1fb4 has been approved by petrochenkov

It is now in the queue for this repository.

bors · 2024-09-21T11:16:42Z

⌛ Testing commit 9ae1fb4 with merge f48c99a...

bors · 2024-09-21T13:47:08Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing f48c99a to master...

rust-timer · 2024-09-21T15:16:40Z

Finished benchmarking commit (f48c99a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.5%, secondary 2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	1
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.5%	[-2.5%, -2.5%]	1

Cycles

Results (secondary 1.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.8%	[1.8%, 1.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 769.225s -> 768.677s (-0.07%)
Artifact size: 341.35 MiB -> 341.36 MiB (0.00%)

rustbot assigned petrochenkov Sep 20, 2024

petrochenkov reviewed Sep 20, 2024

View reviewed changes

tests/ui/lint/non-snake-case/lint-non-snake-case-crate.rs Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2024

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 21, 2024

jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2024

jieyouxu added 2 commits September 21, 2024 05:24

Explain why non_snake_case is skipped for binary crates

43ede73

Coalesce non_snake_case crate test set with revisions

9ae1fb4

jieyouxu force-pushed the snake_case_binary_cleanup branch from aebc28e to 9ae1fb4 Compare September 21, 2024 05:42

jieyouxu commented Sep 21, 2024

View reviewed changes

tests/ui/lint/non-snake-case/lint-non-snake-case-crate.rs Show resolved Hide resolved

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 21, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 21, 2024

bors merged commit f48c99a into rust-lang:master Sep 21, 2024
7 checks passed

rustbot added this to the 1.83.0 milestone Sep 21, 2024

jieyouxu deleted the snake_case_binary_cleanup branch December 20, 2024 17:36

jieyouxu mentioned this pull request Dec 29, 2024

tests: add basic test coverage for stable --crate-type flag #134906

Merged

Explain why non_snake_case is skipped for binary crates and cleanup tests #130599

Explain why non_snake_case is skipped for binary crates and cleanup tests #130599

Uh oh!

Conversation

jieyouxu commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 20, 2024

Uh oh!

jieyouxu commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Sep 20, 2024

Uh oh!

jieyouxu commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Sep 20, 2024

Uh oh!

Uh oh!

petrochenkov commented Sep 20, 2024

Uh oh!

petrochenkov commented Sep 20, 2024

Uh oh!

bors commented Sep 20, 2024

Uh oh!

This comment was marked as outdated.

This comment has been minimized.

This comment was marked as outdated.

jieyouxu commented Sep 21, 2024

Uh oh!

Uh oh!

bors commented Sep 21, 2024

Uh oh!

bors commented Sep 21, 2024

Uh oh!

jieyouxu commented Sep 21, 2024

Uh oh!

petrochenkov commented Sep 21, 2024

Uh oh!

bors commented Sep 21, 2024

Uh oh!

bors commented Sep 21, 2024

Uh oh!

bors commented Sep 21, 2024

Uh oh!

Uh oh!

rust-timer commented Sep 21, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

Explain why `non_snake_case` is skipped for binary crates and cleanup tests #130599

Explain why `non_snake_case` is skipped for binary crates and cleanup tests #130599

jieyouxu commented Sep 20, 2024 •

edited

Loading

jieyouxu commented Sep 20, 2024 •

edited

Loading

jieyouxu commented Sep 20, 2024 •

edited

Loading