[PERF] Introduce CovariantCopyTaggedPtr and use it in TyKind::TraitObject

[BoxyUwU]

r? @ghost

[rust-log-analyzer]

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#13 3.232 Building wheels for collected packages: reuse
#13 3.233   Building wheel for reuse (pyproject.toml): started
#13 3.438   Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 3.440   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132718 sha256=f1d7d99e2187cfcc743e73878997db8829d4c560719802a1230bd160f7d9cfca
#13 3.440   Stored in directory: /tmp/pip-ephem-wheel-cache-5e39vv3j/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#13 3.442 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#13 3.833 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#13 3.834 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 4.378 Collecting virtualenv
#13 4.378 Collecting virtualenv
#13 4.437   Downloading virtualenv-20.28.1-py3-none-any.whl (4.3 MB)
#13 4.700      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 4.3/4.3 MB 16.4 MB/s eta 0:00:00
#13 4.761 Collecting platformdirs<5,>=3.9.1
#13 4.772   Downloading platformdirs-4.3.6-py3-none-any.whl (18 kB)
#13 4.796 Collecting distlib<1,>=0.3.7
#13 4.823      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 31.8 MB/s eta 0:00:00
#13 4.863 Collecting filelock<4,>=3.12.2
#13 4.874   Downloading filelock-3.16.1-py3-none-any.whl (16 kB)
#13 4.874   Downloading filelock-3.16.1-py3-none-any.whl (16 kB)
#13 4.954 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 5.138 Successfully installed distlib-0.3.9 filelock-3.16.1 platformdirs-4.3.6 virtualenv-20.28.1
#13 DONE 5.2s

#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
DirectMap4k:      104384 kB
DirectMap2M:     5138432 kB
DirectMap1G:    13631488 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
    Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
downloading https://static.rust-lang.org/dist/2024-11-27/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz
---
   Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
    Finished `release` profile [optimized] target(s) in 32.96s
##[endgroup]
fmt check
Diff in /checkout/src/librustdoc/clean/mod.rs:1839:
         TyKind::Path(_) => clean_qpath(ty, cx),
         TyKind::TraitObject(bounds, lifetime) => {
             let bounds = bounds.iter().map(|bound| clean_poly_trait_ref(bound, cx)).collect();
-            let lifetime =
-                if !lifetime.is_elided() { Some(clean_lifetime(lifetime.pointer(), cx)) } else { None };
+            let lifetime = if !lifetime.is_elided() {
+                Some(clean_lifetime(lifetime.pointer(), cx))
+                None
+            };
+            };
             DynTrait(bounds, lifetime)
         }
         TyKind::BareFn(barefn) => BareFunction(Box::new(clean_bare_fn_ty(barefn, cx))),
Build completed unsuccessfully in 0:01:14
  local time: Wed Jan  8 00:14:11 UTC 2025
  network time: Wed, 08 Jan 2025 00:14:11 GMT
##[error]Process completed with exit code 1.

[BoxyUwU]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 7d47257 with merge be0d3af...

[bors]

☀️ Try build successful - checks-actions
Build commit: be0d3af (be0d3af184bb77eab071fbe610d113bae1d87ad1)

[rust-timer]

Finished benchmarking commit (be0d3af): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.7%, secondary 0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.6%	[3.6%, 3.6%]	1
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	1
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[-2.2%, 3.6%]	2

Cycles

Results (primary -1.9%, secondary -3.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.9%	[-2.8%, -1.2%]	5
Improvements ✅ (secondary)	-3.5%	[-5.0%, -1.9%]	10
All ❌✅ (primary)	-1.9%	[-2.8%, -1.2%]	5

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 763.589s -> 763.221s (-0.05%)
Artifact size: 325.74 MiB -> 325.68 MiB (-0.02%)

[BoxyUwU]

yippers