-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Docs fix spelling issues #136054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Docs fix spelling issues #136054
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -156,7 +156,7 @@ impl<Cx: HasDataLayout> LayoutCalculator<Cx> { | |
| // run and bias niches to the right and then check which one is closer to one of the | ||
| // struct's edges. | ||
| if let Ok(layout) = &layout { | ||
| // Don't try to calculate an end-biased layout for unsizable structs, | ||
| // Don't try to calculate an end-biased layout for unseizable structs, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is wrong? |
||
| // otherwise we could end up with different layouts for | ||
| // Foo<Type> and Foo<dyn Trait> which would break unsizing. | ||
| if !matches!(kind, StructKind::MaybeUnsized) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -110,7 +110,7 @@ impl<'a> Layout<'a> { | |
| /// Whether the layout is from a type that implements [`std::marker::PointerLike`]. | ||
| /// | ||
| /// Currently, that means that the type is pointer-sized, pointer-aligned, | ||
| /// and has a initialized (non-union), scalar ABI. | ||
| /// and has an initialized (non-union), scalar ABI. | ||
| pub fn is_pointer_like(self, data_layout: &TargetDataLayout) -> bool { | ||
| self.size() == data_layout.pointer_size | ||
| && self.align().abi == data_layout.pointer_align.abi | ||
|
|
@@ -119,7 +119,7 @@ impl<'a> Layout<'a> { | |
| } | ||
|
|
||
| /// The layout of a type, alongside the type itself. | ||
| /// Provides various type traversal APIs (e.g., recursing into fields). | ||
| /// Provides various types of traversal APIs (e.g., recursing into fields). | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is also wrong? |
||
| /// | ||
| /// Note that the layout is NOT guaranteed to always be identical | ||
| /// to that obtained from `layout_of(ty)`, as we need to produce | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original is correct, "reducing register pressure (in ...) is"