Add safe new() to NotAllOnes

[kornelski]

Replaces duplicated unsafe code with a single, easier to verify implementation.

[rustbot]

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[Noratrieb]

@bors try @rust-timer queue

[bors]

⌛ Trying commit cb50cf3 with merge f135255...

[bors]

☀️ Try build successful - checks-actions
Build commit: f135255 (f135255328fbde29f259252f50cedc8aa8c206ad)

[rust-timer]

Finished benchmarking commit (f135255): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 3.0%, secondary 4.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.0%	[2.1%, 5.0%]	5
Regressions ❌ (secondary)	4.8%	[3.2%, 6.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.0%	[2.1%, 5.0%]	5

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary 0.0%, secondary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	4
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	35
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.0%]	4

Bootstrap: 788.874s -> 788.141s (-0.09%)
Artifact size: 347.76 MiB -> 347.75 MiB (-0.00%)

[Noratrieb]

Can you remove the last commit? It doesn't seem to be worth it.
The first one looks good.

[Noratrieb]

@bors r+ rollup

[bors]

📌 Commit 00964aa has been approved by Noratrieb

It is now in the queue for this repository.