Skip to content

Emit llvm.{memcpy,memset}.inline when no-builtins attribute is enabled #137246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
compiler-errors wants to merge 1 commit into from
Closed

Emit llvm.{memcpy,memset}.inline when no-builtins attribute is enabled #137246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1565,9 +1565,17 @@ extern "C" LLVMValueRef LLVMRustBuildMemCpy(LLVMBuilderRef B, LLVMValueRef Dst,
unsigned SrcAlign,
LLVMValueRef Size,
bool IsVolatile) {
return wrap(unwrap(B)->CreateMemCpy(unwrap(Dst), MaybeAlign(DstAlign),
unwrap(Src), MaybeAlign(SrcAlign),
unwrap(Size), IsVolatile));
if (unwrap(B)->GetInsertBlock()->getParent()->hasFnAttribute("no-builtins") ||
unwrap(B)->GetInsertBlock()->getParent()->hasFnAttribute(
"no-builtin-memcpy")) {
return wrap(unwrap(B)->CreateMemCpyInline(unwrap(Dst), MaybeAlign(DstAlign),
unwrap(Src), MaybeAlign(SrcAlign),
unwrap(Size), IsVolatile));
} else {
return wrap(unwrap(B)->CreateMemCpy(unwrap(Dst), MaybeAlign(DstAlign),
unwrap(Src), MaybeAlign(SrcAlign),
unwrap(Size), IsVolatile));
}
}

extern "C" LLVMValueRef
Expand All @@ -1583,8 +1591,16 @@ extern "C" LLVMValueRef LLVMRustBuildMemSet(LLVMBuilderRef B, LLVMValueRef Dst,
unsigned DstAlign, LLVMValueRef Val,
LLVMValueRef Size,
bool IsVolatile) {
return wrap(unwrap(B)->CreateMemSet(unwrap(Dst), unwrap(Val), unwrap(Size),
MaybeAlign(DstAlign), IsVolatile));
if (unwrap(B)->GetInsertBlock()->getParent()->hasFnAttribute("no-builtins") ||
unwrap(B)->GetInsertBlock()->getParent()->hasFnAttribute(
"no-builtin-memset")) {
return wrap(unwrap(B)->CreateMemSetInline(unwrap(Dst), MaybeAlign(DstAlign),
unwrap(Val), unwrap(Size),
IsVolatile));
} else {
return wrap(unwrap(B)->CreateMemSet(unwrap(Dst), unwrap(Val), unwrap(Size),
MaybeAlign(DstAlign), IsVolatile));
}
}

// Polyfill for `LLVMBuildCallBr`, which was added in LLVM 19.
Expand Down
16 changes: 16 additions & 0 deletions tests/codegen/no_builtin-mem.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#![crate_type = "lib"]
#![no_builtins]

type T = [u8; 256];

#[no_mangle]
pub fn f() -> [i32; 1000] {
// CHECK: call void @llvm.memset.inline.{{.*}}(ptr nonnull align 4 %{{.*}}, i8 0, i64 4000, i1 false)
[0; 1000]
}

#[no_mangle]
pub fn g(x: &[i32; 1000], y: &mut [i32; 1000]) {
// CHECK: call void @llvm.memcpy.inline.{{.*}}(ptr nonnull align 4 %{{.*}}, ptr nonnull align 4 %{{.*}}, i64 4000, i1 false)
*y = *x;
}
Loading