Skip to content

[EXPERIMENTAL] Test failure investigation #139561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

[EXPERIMENTAL] Test failure investigation #139561

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
89a42d6
Feed HIR for by-move coroutine body def, since the inliner tries to r…
compiler-errors Mar 31, 2025
b05f70b
Add `iter` macro (movable generator)
oli-obk Feb 27, 2025
38ce680
Make `iter` a builtin macro
oli-obk Feb 27, 2025
e84ccac
Make diagnostics know about more coro closures than async closures
oli-obk Feb 27, 2025
4806ac6
Use yield_expr feature for iter_macro tests
eholk Mar 8, 2025
b770e51
Remove support for expr-only yield!
eholk Mar 10, 2025
3eb7b78
Update and fix tests
eholk Mar 13, 2025
2e6e242
Add a test for iterators that capture but don't lend
eholk Mar 18, 2025
69a65cd
Add some tests to make sure iter macros do not accidentally become as…
eholk Mar 28, 2025
5309dbd
Remove AsyncFn* impls from gnerator closures
eholk Mar 31, 2025
3d5a21a
Update error message for const_gen_fn.rs
eholk Apr 1, 2025
676bf46
Gate const coroutines better
eholk Apr 1, 2025
51d09de
Add FIXME about const coroutine feature
eholk Apr 1, 2025
85243d3
Fix CI test failure due to `diagnostic-width`
traviscross Apr 8, 2025
121a5ae
[EXPERIMENTAL] Try `//@ remap-src-base`
jieyouxu Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions tests/ui/iterators/iter-macro-not-async-closure.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
// explanation is moved to the `help` instead of the span label.
//
//@ edition: 2024
//@ revisions: narrow wide
//@[narrow] compile-flags: --diagnostic-width=20
//@[wide] compile-flags: --diagnostic-width=300
Copy link
Member

@RalfJung RalfJung Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks almost like the test intentionally wants to cover different widths?

Copy link
Member Author

@jieyouxu jieyouxu Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Yes, I'm just checking if the original version of the test passes without manually specifying diag width, since it failed in CI but not locally)

//@ remap-src-base

#![feature(yield_expr, iter_macro)]

Expand All @@ -31,8 +29,8 @@ fn main() {

let x = pin!(call_async_once(f));
//~^ ERROR AsyncFnOnce()` is not satisfied
//~^^ ERROR AsyncFnOnce()` is not satisfied
//~^^^ ERROR AsyncFnOnce()` is not satisfied
//~| ERROR AsyncFnOnce()` is not satisfied
//~| ERROR AsyncFnOnce()` is not satisfied
x.poll(&mut Context::from_waker(Waker::noop()));
//~^ ERROR AsyncFnOnce()` is not satisfied
}
54 changes: 54 additions & 0 deletions tests/ui/iterators/iter-macro-not-async-closure.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
error[E0277]: the trait bound `{gen closure@$DIR/iter-macro-not-async-closure.rs:24:21: 24:28}: AsyncFnOnce()` is not satisfied
--> $DIR/iter-macro-not-async-closure.rs:30:34
|
LL | let x = pin!(call_async_once(f));
| --------------- ^ the trait `AsyncFnOnce()` is not implemented for `{gen closure@$DIR/iter-macro-not-async-closure.rs:24:21: 24:28}`
| |
| required by a bound introduced by this call
|
note: required by a bound in `call_async_once`
--> $DIR/iter-macro-not-async-closure.rs:19:34
|
LL | async fn call_async_once(f: impl AsyncFnOnce()) {
| ^^^^^^^^^^^^^ required by this bound in `call_async_once`

error[E0277]: the trait bound `{gen closure@$DIR/iter-macro-not-async-closure.rs:24:21: 24:28}: AsyncFnOnce()` is not satisfied
--> $DIR/iter-macro-not-async-closure.rs:30:18
|
LL | let x = pin!(call_async_once(f));
| ^^^^^^^^^^^^^^^^^^ the trait `AsyncFnOnce()` is not implemented for `{gen closure@$DIR/iter-macro-not-async-closure.rs:24:21: 24:28}`
|
note: required by a bound in `call_async_once`
--> $DIR/iter-macro-not-async-closure.rs:19:34
|
LL | async fn call_async_once(f: impl AsyncFnOnce()) {
| ^^^^^^^^^^^^^ required by this bound in `call_async_once`

error[E0277]: the trait bound `{gen closure@$DIR/iter-macro-not-async-closure.rs:24:21: 24:28}: AsyncFnOnce()` is not satisfied
--> $DIR/iter-macro-not-async-closure.rs:30:13
|
LL | let x = pin!(call_async_once(f));
| ^^^^^^^^^^^^^^^^^^^^^^^^ the trait `AsyncFnOnce()` is not implemented for `{gen closure@$DIR/iter-macro-not-async-closure.rs:24:21: 24:28}`
|
note: required by a bound in `call_async_once`
--> $DIR/iter-macro-not-async-closure.rs:19:34
|
LL | async fn call_async_once(f: impl AsyncFnOnce()) {
| ^^^^^^^^^^^^^ required by this bound in `call_async_once`
= note: this error originates in the macro `pin` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0277]: the trait bound `{gen closure@$DIR/iter-macro-not-async-closure.rs:24:21: 24:28}: AsyncFnOnce()` is not satisfied
--> $DIR/iter-macro-not-async-closure.rs:34:5
|
LL | x.poll(&mut Context::from_waker(Waker::noop()));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `AsyncFnOnce()` is not implemented for `{gen closure@$DIR/iter-macro-not-async-closure.rs:24:21: 24:28}`
|
note: required by a bound in `call_async_once`
--> $DIR/iter-macro-not-async-closure.rs:19:34
|
LL | async fn call_async_once(f: impl AsyncFnOnce()) {
| ^^^^^^^^^^^^^ required by this bound in `call_async_once`

error: aborting due to 4 previous errors

For more information about this error, try `rustc --explain E0277`.
Loading