Skip to content

Make sure fmt-write-bloat doesn't vacuously pass on no symbols #143669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make sure fmt-write-bloat doesn't vacuously pass on no symbols #143669

wants to merge 1 commit into from
+68 −6

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Jul 9, 2025 •
edited
Loading

This PR fixes the tests/run-make/fmt-write-float/ run-make test to both (1) not vacuously pass on no symbols at all, and (2) compare panics symbols under optimizations versus no optimizations.

Context

Previously, the test only checks for the absence of certain panic symbols, but having no symbols was also a possible albeit vacuous way to satisfy this assertion.

Noticed in #142841 (comment).

r? @ChrisDenton

try-job: aarch64-apple
try-job: aarch64-msvc-1
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 9, 2025
@jieyouxu jieyouxu mentioned this pull request Jul 9, 2025
Merged
@ChrisDenton

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@ChrisDenton

This comment was marked as outdated.

Sign in to view
@rust-bors

This comment was marked as outdated.

Sign in to view
rust-bors bot added a commit that referenced this pull request Jul 9, 2025
@rust-bors
Auto merge of #143669 - jieyouxu:fmt-write-bloat, r=<try>
9306675 
Make sure `fmt-write-bloat` doesn't vacuously pass on no symbols

Previously, the test only checks for the absence of certain panic symbols, but having no symbols was also a possible albeit vacuous way to satisfy this assertion.

Fix this by checking we at least observe the `main` symbol which is always expected to be present.

Noticed in #142841 (comment).

r? `@ChrisDenton`
try-job: x86_64-msvc-*
@rust-bors

This comment was marked as outdated.

Sign in to view
@jieyouxu
Copy link
Member Author

jieyouxu commented Jul 9, 2025

Hm. Let me try this locally on windows.

@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2025
@ChrisDenton
Copy link
Member

The failure is not surprising to me. On Windows, symbols are not contained in the binary itself and are instead in a separate file (the .pdb). So the object crate would not be able to find them.

@jieyouxu
Copy link
Member Author

jieyouxu commented Jul 9, 2025 •
edited
Loading

Oh of course... D'oh. Let me see if I can cook something up.

@rustbot

This comment was marked as outdated.

Sign in to view
@jieyouxu jieyouxu changed the title Make sure fmt-write-bloat doesn't vacuously pass on no symbols [WIP] Make sure fmt-write-bloat doesn't vacuously pass on no symbols Jul 9, 2025
@jieyouxu

This comment was marked as outdated.

Sign in to view
@rust-bors

This comment was marked as outdated.

Sign in to view
rust-bors bot added a commit that referenced this pull request Jul 9, 2025
@rust-bors
Auto merge of #143669 - jieyouxu:fmt-write-bloat, r=<try>
a1b33a4 
[WIP] Make sure `fmt-write-bloat` doesn't vacuously pass on no symbols

Previously, the test only checks for the absence of certain panic symbols, but having no symbols was also a possible albeit vacuous way to satisfy this assertion.

Fix this by checking we at least observe the `main` symbol which is always expected to be present.

Noticed in #142841 (comment).

r? `@ChrisDenton`

try-job: aarch64-apple
try-job: x86_64-apple-1
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
@jieyouxu
Copy link
Member Author

jieyouxu commented Jul 9, 2025

llvm-pdbutil is an fallback approach, trying pdb crate to see if that works under CI conditions.

@jieyouxu

This comment was marked as outdated.

Sign in to view
@jieyouxu

This comment was marked as outdated.

Sign in to view
@rust-bors

This comment was marked as outdated.

Sign in to view
@jieyouxu

This comment was marked as resolved.

Sign in to view
@rust-bors

This comment was marked as outdated.

Sign in to view
rust-bors bot added a commit that referenced this pull request Jul 9, 2025
@rust-bors
Auto merge of #143669 - jieyouxu:fmt-write-bloat, r=<try>
1d2e78e 
[WIP] Make sure `fmt-write-bloat` doesn't vacuously pass on no symbols

Previously, the test only checks for the absence of certain panic symbols, but having no symbols was also a possible albeit vacuous way to satisfy this assertion.

Fix this by checking we at least observe the `main` symbol which is always expected to be present.

Noticed in #142841 (comment).

r? `@ChrisDenton`

try-job: aarch64-apple
try-job: x86_64-apple-1
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
@jieyouxu jieyouxu mentioned this pull request Jul 9, 2025
Merged
@jieyouxu

This comment was marked as outdated.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 5, 2025
@rust-bors
Auto merge of #143669 - jieyouxu:fmt-write-bloat, r=<try>
4d52e5b 
Make sure `fmt-write-bloat` doesn't vacuously pass on no symbols

try-job: aarch64-apple
try-job: aarch64-msvc-1
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
@jieyouxu

This comment was marked as outdated.

Sign in to view
@rust-bors

This comment was marked as outdated.

Sign in to view
@rustbot

This comment was marked as outdated.

Sign in to view
@jieyouxu

This comment was marked as outdated.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 5, 2025
@rust-bors
Auto merge of #143669 - jieyouxu:fmt-write-bloat, r=<try>
05ee95b 
Make sure `fmt-write-bloat` doesn't vacuously pass on no symbols

try-job: aarch64-apple
try-job: aarch64-msvc-1
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
@rust-bors

This comment was marked as outdated.

Sign in to view
@jieyouxu

This comment was marked as off-topic.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 6, 2025
@rust-bors
Auto merge of #143669 - jieyouxu:fmt-write-bloat, r=<try>
8fcb32a 
Make sure `fmt-write-bloat` doesn't vacuously pass on no symbols

try-job: aarch64-apple
try-job: aarch64-msvc-1
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
@rust-bors

This comment was marked as outdated.

Sign in to view
@jieyouxu
Copy link
Member Author

jieyouxu commented Oct 6, 2025

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 6, 2025
@rust-bors
Auto merge of #143669 - jieyouxu:fmt-write-bloat, r=<try>
2482721 
Make sure `fmt-write-bloat` doesn't vacuously pass on no symbols

try-job: aarch64-apple
try-job: aarch64-msvc-1
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
@rust-bors
Copy link

rust-bors bot commented Oct 6, 2025

☀️ Try build successful (CI)
Build commit: 2482721 (248272128b67c2c69317753a62e91c371cd7384e, parent: d2acb427e424fd7d52377698046a06109e9777b4)

jieyouxu
jieyouxu commented Oct 7, 2025
View reviewed changes
tests/run-make/fmt-write-bloat/rmake.rs
Comment on lines +70 to +76
let expect_filecheck_pattern = r#"
CHECK: main
CHECK: {{.*}}core{{.*}}panicking{{.*}}
// _ZN4core3fmt3num3imp54_$LT$impl$u20$core..fmt..Display$u20$for$u20$usize...
CHECK: {{.*}}Display{{.*}}
CHECK-NOT: {{.*}}panic_bounds_check{{.*}}
"#;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: these are by no means pretty, and in the future we almost certainly want our own DIA wrappers in run_make_support or somewhere. But I don't feel like implementing that (at least in this PR), so I'll go with the dumb llvm-pdbutil approach for now.

@jieyouxu
Copy link
Member Author

jieyouxu commented Oct 7, 2025

Given that the try jobs finally passed...
@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisDenton ChrisDenton ChrisDenton left review comments

Assignees

@ChrisDenton ChrisDenton

Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jieyouxu @ChrisDenton @rustbot @bors @rust-log-analyzer