Skip to content

take attr style into account in diagnostics #145243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

take attr style into account in diagnostics #145243

wants to merge 1 commit into from

Conversation

jdonszelmann
Copy link
Contributor

@jdonszelmann jdonszelmann commented Aug 11, 2025 •
edited
Loading

when the original attribute was specified as an inner attribute, the suggestion will now match that attribute style

@rustbot
Copy link
Collaborator

rustbot commented Aug 11, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 11, 2025
@jdonszelmann jdonszelmann mentioned this pull request Aug 11, 2025
Open
cjgillot
cjgillot reviewed Aug 11, 2025
View reviewed changes
compiler/rustc_attr_parsing/src/session_diagnostics.rs Outdated
@@ -690,7 +691,7 @@ impl<'a, G: EmissionGuarantee> Diagnostic<'a, G> for AttributeParseError {
}
}

let suggestions = self.template.suggestions(false, &name);
let suggestions = self.template.suggestions(self.attr_style == AttrStyle::Inner, &name);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this method take an AttrStyle parameter?

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2025
@jdonszelmann
Copy link
Contributor Author

fair enough, should be fixed :)

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jdonszelmann
Copy link
Contributor Author

oh this actually got some more improved diagnostics, awesome

@jdonszelmann
Copy link
Contributor Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

Assignees

@petrochenkov petrochenkov

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jdonszelmann @rustbot @rust-log-analyzer @cjgillot @petrochenkov