Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#4 of Batch #2] #145897

Oneirical · 2025-08-26T16:55:52Z

Methodology:

Refer to the previously written tests/ui/SUMMARY.md
Find an appropriate category for the test, using the original issue thread and the test contents.
Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
Rename the tests to make their purpose clearer

Inspired by the methodology that @Kivooeo was using.

rustbot · 2025-08-26T21:03:10Z

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

jieyouxu

Thanks, some nits. I can't seem to figure out what happened to the two removed tests tho.

View changes since this review

tests/ui/array-slice-vec/array-iteration-bitwise-operations-68951.rs

tests/ui/closures/moved-value-in-closure-64559.rs

tests/ui/generics/generic-struct-self-behavior-69306.rs

tests/ui/issues/issue-60218.rs

tests/ui/issues/issue-67039-unsound-pin-partialeq.rs

tests/ui/match/pattern-matching-with-double-references-61475.rs

tests/ui/parser/character-indexing-bug-in-splice-lines-69130.rs

tests/ui/traits/associated-type-ice-recovery-66353.rs

tests/ui/typeck/type-name-intrinsic-usage-61894.rs

jieyouxu · 2025-09-05T07:31:04Z

Also tiny nit: can you refrain from at-mentioning Kivo in PR description

Inspired by the methodology that @Kivooeo was using.

(just remove the @)

Inspired by the methodology that Kivooeo was using.

is fine. Otherwise, they will get pinged for each of such PRs.

bors · 2025-09-27T04:55:44Z

☔ The latest upstream changes (presumably #147074) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2025-10-01T04:05:43Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jieyouxu

Thanks @Oneirical

View changes since this review

jieyouxu · 2025-10-01T04:26:24Z

You can r=me once PR CI is green.
@bors delegate+

bors · 2025-10-01T04:26:28Z

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

rust-log-analyzer · 2025-10-01T04:57:09Z

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

49 error[E0308]: mismatched types
-   --> $DIR/generic-struct-self-unconstrained-inference-vars-69306:28:14
+   --> $DIR/generic-struct-self-unconstrained-inference-vars-69306.rs:28:14
51    |
52 LL | impl<T> Foo<T> for <S0<T> as Fun>::Out {
53    |      - expected this type parameter

60    = note: expected type parameter `T`
61                         found type `{integer}`
62 note: tuple struct defined here
-   --> $DIR/generic-struct-self-unconstrained-inference-vars-69306:4:8
---
80 note: tuple struct defined here
-   --> $DIR/generic-struct-self-unconstrained-inference-vars-69306:32:8
+   --> $DIR/generic-struct-self-unconstrained-inference-vars-69306.rs:32:8
82    |
83 LL | struct S1<T, U>(T, U);
84    |        ^^

85 
86 error[E0308]: mismatched types
-   --> $DIR/generic-struct-self-unconstrained-inference-vars-69306:34:27
+   --> $DIR/generic-struct-self-unconstrained-inference-vars-69306.rs:34:27
88    |
89 LL | impl<T> S1<T, u8> {
90    |      - found this type parameter

95               found struct `S1<T, _>`
96 
97 error[E0308]: mismatched types
-   --> $DIR/generic-struct-self-unconstrained-inference-vars-69306:42:14
+   --> $DIR/generic-struct-self-unconstrained-inference-vars-69306.rs:42:14
99    |
---
To only update this specific test, also pass `--test-args generics/generic-struct-self-unconstrained-inference-vars-69306.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/generics/generic-struct-self-unconstrained-inference-vars-69306.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/generics/generic-struct-self-unconstrained-inference-vars-69306" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
error[E0308]: mismatched types
##[error]  --> /checkout/tests/ui/generics/generic-struct-self-unconstrained-inference-vars-69306.rs:6:28
   |
LL | impl<T> S0<T> {
   |      - expected this type parameter
LL |     const C: S0<u8> = Self(0);
   |                       ---- ^ expected type parameter `T`, found integer
   |                       |
   |                       arguments to this function are incorrect
   |
   = note: expected type parameter `T`
                        found type `{integer}`
---
##[error]  --> /checkout/tests/ui/generics/generic-struct-self-unconstrained-inference-vars-69306.rs:6:23
   |
LL | impl<T> S0<T> {
   |      - found this type parameter
LL |     const C: S0<u8> = Self(0);
   |                       ^^^^^^^ expected `S0<u8>`, found `S0<T>`
   |
   = note: expected struct `S0<u8>`
              found struct `S0<T>`

error[E0308]: mismatched types
---

error[E0308]: mismatched types
##[error]  --> /checkout/tests/ui/generics/generic-struct-self-unconstrained-inference-vars-69306.rs:28:14
   |
LL | impl<T> Foo<T> for <S0<T> as Fun>::Out {
   |      - expected this type parameter
LL |     fn foo() {
LL |         Self(0); //~ ERROR mismatched types
   |         ---- ^ expected type parameter `T`, found integer
   |         |
   |         arguments to this function are incorrect
---

error[E0308]: mismatched types
##[error]  --> /checkout/tests/ui/generics/generic-struct-self-unconstrained-inference-vars-69306.rs:34:32
   |
LL | impl<T> S1<T, u8> {
   |      - expected this type parameter
LL |     const C: S1<u8, u8> = Self(0, 1);
   |                           ---- ^ expected type parameter `T`, found integer
   |                           |
   |                           arguments to this function are incorrect
   |
   = note: expected type parameter `T`
                        found type `{integer}`
note: tuple struct defined here
  --> /checkout/tests/ui/generics/generic-struct-self-unconstrained-inference-vars-69306.rs:32:8
   |
LL | struct S1<T, U>(T, U);
   |        ^^

error[E0308]: mismatched types
##[error]  --> /checkout/tests/ui/generics/generic-struct-self-unconstrained-inference-vars-69306.rs:34:27
   |
LL | impl<T> S1<T, u8> {
   |      - found this type parameter
LL |     const C: S1<u8, u8> = Self(0, 1);
   |                           ^^^^^^^^^^ expected `S1<u8, u8>`, found `S1<T, u8>`
   |
   = note: expected struct `S1<u8, _>`
              found struct `S1<T, _>`

error[E0308]: mismatched types
##[error]  --> /checkout/tests/ui/generics/generic-struct-self-unconstrained-inference-vars-69306.rs:42:14
   |
LL | impl<T> S2<T> {
   |      - expected type parameter
LL |     fn map<U>(x: U) -> S2<U> {
   |            - found type parameter
LL |         Self(x)
   |         ---- ^ expected type parameter `T`, found type parameter `U`
   |         |
   |         arguments to this function are incorrect
---
##[error]  --> /checkout/tests/ui/generics/generic-struct-self-unconstrained-inference-vars-69306.rs:42:9
   |
LL | impl<T> S2<T> {
   |      - found type parameter
LL |     fn map<U>(x: U) -> S2<U> {
   |            -           ----- expected `S2<U>` because of return type
   |            |
   |            expected type parameter
LL |         Self(x)
   |         ^^^^^^^ expected `S2<U>`, found `S2<T>`
   |
   = note: expected struct `S2<U>`
              found struct `S2<T>`
   = note: a type parameter was expected, but a different one was found; you might be missing a type parameter or trait bound
   = note: for more information, visit https://doc.rust-lang.org/book/ch10-02-traits.html#traits-as-parameters

rustbot assigned jieyouxu Aug 26, 2025

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 26, 2025

Oneirical marked this pull request as ready for review August 26, 2025 21:03

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 26, 2025

jieyouxu requested changes Sep 5, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2025

Oneirical force-pushed the uncountable-integer-11 branch from f390533 to 37c9001 Compare September 12, 2025 20:15

This comment has been minimized.

Sign in to view

Oneirical force-pushed the uncountable-integer-11 branch from 37c9001 to 22b9b97 Compare October 1, 2025 03:29

This comment has been minimized.

Sign in to view

Add test batch 4

f957ddb

Oneirical force-pushed the uncountable-integer-11 branch from 22b9b97 to f957ddb Compare October 1, 2025 04:05

jieyouxu approved these changes Oct 1, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#4 of Batch #2] #145897

Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#4 of Batch #2] #145897

Uh oh!

Oneirical commented Aug 26, 2025

Uh oh!

rustbot commented Aug 26, 2025

Uh oh!

jieyouxu left a comment •

edited by rustbot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Sep 5, 2025

Uh oh!

This comment has been minimized.

bors commented Sep 27, 2025

Uh oh!

This comment has been minimized.

rustbot commented Oct 1, 2025

Uh oh!

jieyouxu left a comment •

edited by rustbot

Loading

Uh oh!

jieyouxu commented Oct 1, 2025

Uh oh!

bors commented Oct 1, 2025

Uh oh!

rust-log-analyzer commented Oct 1, 2025

Uh oh!

Uh oh!

Rehome 30 tests/ui/issues/ tests to other subdirectories under tests/ui/ [#4 of Batch #2] #145897

Are you sure you want to change the base?

Rehome 30 tests/ui/issues/ tests to other subdirectories under tests/ui/ [#4 of Batch #2] #145897

Uh oh!

Conversation

Oneirical commented Aug 26, 2025

Uh oh!

rustbot commented Aug 26, 2025

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Sep 5, 2025

Uh oh!

This comment has been minimized.

bors commented Sep 27, 2025

Uh oh!

This comment has been minimized.

rustbot commented Oct 1, 2025

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Oct 1, 2025

Uh oh!

bors commented Oct 1, 2025

Uh oh!

rust-log-analyzer commented Oct 1, 2025

Uh oh!

Uh oh!

Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#4 of Batch #2] #145897

Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#4 of Batch #2] #145897

jieyouxu left a comment •

edited by rustbot

Loading

jieyouxu left a comment •

edited by rustbot

Loading