-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Re-export f16 and f128 into core::primitive.
#146306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@rustbot label +T-libs-api -T-libs r? libs-api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@bors r+ |
|
Did you double check that this doesn't allow escaping the feature gates? That was the reason we didn't do this at one point #116909 (comment) |
|
|
|
Yeah, sure enough. Good catch. This surprisingly compiles: use core::primitive::f16;
fn main() {
let _: f16;
}It would be good to instead add a placeholder comment in library/core/src/primitive.rs indicating that we know we want this re-export but cannot have it until the type is stable (or the stability checking is fixed). @bors r- |
|
I suppose that this will have to wait in the meantime. |
Tracking issue: #116909.
This PR re-exports
f16andf128intocore::primitive.IIRC we already have unstable re-exports in other places of the standard library.
C.c. @joseluis.