Skip to content

[beta] Backport "Less greedily parse [const] bounds" #146443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2025
Merged

[beta] Backport "Less greedily parse [const] bounds" #146443

merged 1 commit into from
Sep 11, 2025
+33 −5

Conversation

fmease
Copy link
Member

@fmease fmease commented Sep 11, 2025 •
edited
Loading

Backport of #146422.
Following https://forge.rust-lang.org/release/backporting.html#beta-backporting-in-rust-langrust.

Not part of some hypothetical future backport rollup because we're under time pressure as release procedures will commence very soon: https://forge.rust-lang.org/#current-release-versions, https://forge.rust-lang.org/release/process.html.

cc @cuviper

@fmease
Less greedily parse [const] bounds
58afb55 
(cherry picked from commit f5dad62)
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 11, 2025
@fmease
Copy link
Member Author

fmease commented Sep 11, 2025

https://forge.rust-lang.org/release/backporting.html#beta-backporting-in-rust-langrust

@bors rollup=never

https://forge.rust-lang.org/compiler/reviews.html#priority

@bors p=10

@fmease fmease added S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-release Relevant to the release subteam, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 11, 2025
@jieyouxu
Copy link
Member

(Beta backport is approved cf. #146422 (comment))

@fmease
Copy link
Member Author

fmease commented Sep 11, 2025

https://forge.rust-lang.org/release/backporting.html

Only a few people are even aware of the process, but this is actually something anybody can do.

A reviewer (typically from the release team) needs to verify that the backport looks correct and that it’s submitted to the beta branch. […]. If the author of the PR has r+ rights, and has not made significant changes while backporting, they can also self-approve the PR.

r? fmease

@fmease fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Sep 11, 2025
@fmease fmease marked this pull request as ready for review September 11, 2025 14:12
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 11, 2025
@fmease
Copy link
Member Author

fmease commented Sep 11, 2025

Change the milestone to the correct value for the beta release.
Remove the beta-nominated label. This indicates that the backport has been completed.

Applied.

@fmease
Copy link
Member Author

fmease commented Sep 11, 2025

https://forge.rust-lang.org/release/backporting.html

Only a few people are even aware of the process, but this is actually something anybody can do.

A reviewer (typically from the release team) needs to verify that the backport looks correct and that it’s submitted to the beta branch. […]. If the author of the PR has r+ rights, and has not made significant changes while backporting, they can also self-approve the PR.

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 11, 2025

📌 Commit 58afb55 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2025
@bors
Copy link
Collaborator

bors commented Sep 11, 2025

⌛ Testing commit 58afb55 with merge 67cb8e0...

@bors
Copy link
Collaborator

bors commented Sep 11, 2025

☀️ Test successful - checks-actions
Approved by: fmease
Pushing 67cb8e0 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 11, 2025
@bors bors merged commit 67cb8e0 into rust-lang:beta Sep 11, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Sep 11, 2025
@fmease fmease deleted the beta-less-greedy-maybe-const-bounds branch September 11, 2025 21:44
@fmease fmease mentioned this pull request Sep 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fmease fmease

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fmease @jieyouxu @bors @rustbot