Skip to content

Conversation

@pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Sep 16, 2025

This PR improves the coverage of the cmp, result and option modules by adding a few new tests to coretests.

r? libs

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 16, 2025
@joboet
Copy link
Member

joboet commented Sep 18, 2025

These are all covered by their doctests (the clamp test is even copied verbatim from the docs, right?). All those doctests are run in CI, so I struggle to find the merit of this PR.

@joboet joboet closed this Sep 18, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2025
@joboet
Copy link
Member

joboet commented Sep 18, 2025

By the way, if you're looking for something to work on, maybe have a look at the list of unimplemented but accepted ACPs here.

@pvdrz
Copy link
Contributor Author

pvdrz commented Sep 19, 2025

These are all covered by their doctests (the clamp test is even copied verbatim from the docs, right?). All those doctests are run in CI, so I struggle to find the merit of this PR.

I was under the impression that it wasn't possible to get coverage numbers from doctests but I may be wrong.

@joboet
Copy link
Member

joboet commented Sep 20, 2025

It's possible, but we don't track coverage anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants