Skip to content

Use SsoHashMap in MirPatch. #147052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cjgillot wants to merge 1 commit into from
Closed

Use SsoHashMap in MirPatch. #147052

cjgillot wants to merge 1 commit into from

Conversation

@cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Sep 26, 2025

r? @ghost for perf
cc #146697 (review)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 26, 2025
@Kobzol
Copy link
Member

Kobzol commented Sep 26, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Sep 26, 2025
@rust-bors
Auto merge of #147052 - cjgillot:sso-mir-patch, r=<try>
89e6aa3 
Use SsoHashMap in MirPatch.
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 26, 2025
@rust-bors
Copy link

rust-bors bot commented Sep 26, 2025

☀️ Try build successful (CI)
Build commit: 89e6aa3 (89e6aa3e38c769aa63f09c80613bc683a8bbd6a6, parent: 5b9007bfc358817cf066ee27c6b440440727d3a7)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

rust-timer commented Sep 26, 2025

Finished benchmarking commit (89e6aa3): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.3% [0.1%, 0.5%] 15
Regressions ❌
(secondary)		 0.4% [0.2%, 0.8%] 18
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.3% [0.1%, 0.5%] 15

Max RSS (memory usage)

Results (primary 1.1%, secondary 1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.1% [1.1%, 1.1%] 1
Regressions ❌
(secondary)		 1.9% [0.7%, 2.7%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.1% [1.1%, 1.1%] 1

Cycles

Results (primary -3.5%, secondary -7.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.5% [-9.5%, -1.8%] 23
Improvements ✅
(secondary)		 -7.0% [-19.1%, -0.9%] 17
All ❌✅ (primary) -3.5% [-9.5%, -1.8%] 23

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Bootstrap: 478.827s -> 469.726s (-1.90%)
Artifact size: 388.10 MiB -> 388.10 MiB (0.00%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 26, 2025
@Kobzol
Copy link
Member

Kobzol commented Sep 26, 2025

Wow. Those cycles and bootstrap time results are pretty awesome.

@lqd
Copy link
Member

lqd commented Sep 26, 2025

The cycles and bootstrap improvements look like the inverse of the previous PR, so maybe noise.

@Kobzol
Copy link
Member

Kobzol commented Sep 26, 2025

Damn, it seemed to good to be true :( Didn't notice that, thanks.

@cjgillot
Copy link
Contributor Author

cjgillot commented Sep 26, 2025

Closing as not worth it.

@cjgillot cjgillot closed this Sep 26, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 26, 2025
@cjgillot cjgillot deleted the sso-mir-patch branch September 26, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

perf-regression Performance regression. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cjgillot @Kobzol @rust-timer @lqd @rustbot