-
Notifications
You must be signed in to change notification settings - Fork 14.1k
v0 mangling for std on nightly #149148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0 mangling for std on nightly #149148
Conversation
|
|
|
Makes sense, thanks! Prioritizing slightly since it still might get into today's nightly (although I worry some tests might fail..). @bors r+ p=1 |
v0 mangling for std on nightly Following #89917 and rust-lang/compiler-team#938, it doesn't make sense that `std` for these channels would have legacy mangling while the user's code would use `v0`. r? `@Kobzol`
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
|
Let's perf this in the meantime. @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
v0 mangling for std on nightly
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (70ed8a5): comparison URL. Overall result: ❌ regressions - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 0.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.3%, secondary -6.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 1.2%, secondary 5.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 473.456s -> 472.364s (-0.23%) |
|
3% larger stdlib. Slightly annoying, but not a big deal, I think. #145343 might reduce that size considerably, once I can finally get back to it someday.. :D |
…td, r=Kobzol v0 mangling for std on nightly Following rust-lang#89917 and rust-lang/compiler-team#938, it doesn't make sense that `std` for these channels would have legacy mangling while the user's code would use `v0`. r? `@Kobzol`
5e4a05f to
62c5ea6
Compare
|
Some changes occurred in tests/ui/sanitizer cc @rcvalle |
|
I've checked on an x86 machine with sanitizers that the change to the |
|
@bors r=Kobzol |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing cdb4236 (parent) -> 7934bbd (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 7934bbdf84a6b9a30297caf4f4f38286dedf876a --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (7934bbd): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -3.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 4.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 2.3%, secondary 5.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 471.494s -> 472.579s (0.23%) |
|
Binary size regressions caused by longer v0 symbols, that is expected. The small regressions on helloworld most likely (as is usual) due to the larger binary size of the programs being loaded. This makes the release @rustbot label: +perf-regression-triaged |
Following #89917 and rust-lang/compiler-team#938, it doesn't make sense that
stdfor these channels would have legacy mangling while the user's code would usev0.r? @Kobzol