Skip to content

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jan 27, 2019

Successful merges:

Failed merges:

r? @ghost

davidtwco and others added 6 commits January 25, 2019 17:41
This commit extends existing suggestions to prefix unused variable
bindings in match arms with an underscore so that it applies to all
patterns in a match arm.
The example no longer produces an error in the 2018 edition
Unused variable suggestions apply on all patterns.

Fixes rust-lang#56685.

This PR extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm.

r? @estebank
cc @alexcrichton (since you filed the issue)
Remove lexical scope examples from std::mem::drop

The example no longer produces an error in the 2018 edition
@Centril
Copy link
Contributor Author

Centril commented Jan 27, 2019

@bors r+ p=3

@bors
Copy link
Collaborator

bors commented Jan 27, 2019

📌 Commit 450692e has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 27, 2019
@bors
Copy link
Collaborator

bors commented Jan 27, 2019

⌛ Testing commit 450692e with merge d904632b75b71ea1a175add13ffd864a1e402b2b...

@bors
Copy link
Collaborator

bors commented Jan 27, 2019

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 27, 2019
@Centril Centril closed this Jan 27, 2019
@Centril Centril deleted the rollup branch January 27, 2019 03:59
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants