Skip to content

Conversation

csmoe
Copy link
Contributor

@csmoe csmoe commented Oct 21, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 21, 2019
@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@estebank
Copy link
Contributor

Does this change have a user visible change?

@csmoe
Copy link
Contributor Author

csmoe commented Oct 22, 2019

@estebank
From

error[E0698]: type inside `async` object must be known in this context
  --> src/lib.rs:23:25
   |
23 |     let server = server.serve(hyper::service::make_service_fn(move |_| {
   |                         ^^^^^ cannot infer type for `ME`
   |
note: the type is part of the `async` object because of this `await`
  --> src/lib.rs:34:5
   |
34 |     server.await
   |     ^^^^^^^^^^^^

To:

error[E0698]: type inside `async fn` body must be known in this context
  --> src/lib.rs:15:13
   |
15 |             Ok(hyper::service::service_fn(move |req| {
   |             ^^ cannot infer type for `ME`
   |
note: the type is part of the `async fn` body because of this `await`
  --> src/lib.rs:24:5
   |
24 |     server.await
   |     ^^^^^^^^^^^^

error: aborting due to previous error

but I should figure out a test/ui.

@estebank
Copy link
Contributor

r=me with a test

@nikomatsakis
Copy link
Contributor

Looks good to me, too

@JohnCSimon
Copy link
Member

Ping from triage.
@estebank can you please review this PR?
cc: @nikomatsakis @csmoe
Thank you!

@estebank
Copy link
Contributor

estebank commented Nov 3, 2019

@csmoe can you add a ui test exercising this new code?

@csmoe
Copy link
Contributor Author

csmoe commented Nov 5, 2019

@estebank it's a bit complicated, still trying.

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2019
@JohnCSimon
Copy link
Member

Ping from triage:
@csmoe How's it going with the UI test?
cc: @estebank
Thank you!

@bors
Copy link
Collaborator

bors commented Nov 11, 2019

☔ The latest upstream changes (presumably #66252) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimon
Copy link
Member

Ping from triage:
@csmoe Can you please post your status regarding this PR, and address the merge conflicts?
cc: @estebank
Thank you!

@JohnCSimon
Copy link
Member

Pinging once again from triage:
@csmoe Can you please post your status regarding this PR, and address the merge conflicts?

Thank you.

@JohnCSimon JohnCSimon added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Nov 29, 2019
@JohnCSimon
Copy link
Member

Triage:

@csmoe - unfortunately this PR has sat idle for several weeks, I'm marking this as inactive. Please reopen this PR when you're ready to move forward.
Thank you

@JohnCSimon JohnCSimon closed this Nov 29, 2019
Centril added a commit to Centril/rust that referenced this pull request Dec 19, 2019
Fix unresolved type span inside async object

Closes rust-lang#65180
r? @estebank
It's hard to create a minimal repro for that issue, [decided](https://rust-lang.zulipchat.com/#narrow/stream/187312-wg-async-foundations/topic/meeting.202019.2E12.2E17/near/183675659) to give up finding mcve.
cc [previous take](rust-lang#65668)
Centril added a commit to Centril/rust that referenced this pull request Dec 20, 2019
Fix unresolved type span inside async object

Closes rust-lang#65180
r? @estebank
It's hard to create a minimal repro for that issue, [decided](https://rust-lang.zulipchat.com/#narrow/stream/187312-wg-async-foundations/topic/meeting.202019.2E12.2E17/near/183675659) to give up finding mcve.
cc [previous take](rust-lang#65668)
Centril added a commit to Centril/rust that referenced this pull request Dec 20, 2019
Fix unresolved type span inside async object

Closes rust-lang#65180
r? @estebank
It's hard to create a minimal repro for that issue, [decided](https://rust-lang.zulipchat.com/#narrow/stream/187312-wg-async-foundations/topic/meeting.202019.2E12.2E17/near/183675659) to give up finding mcve.
cc [previous take](rust-lang#65668)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async-related type error messages defy expectations (in span location)
8 participants