Skip to content

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost

pickfire and others added 24 commits August 24, 2020 22:32
Fixes a false positive for transparent newtype with a non-zero member.
Co-authored-by: Bastian Kauschke <[email protected]>
…declarations-transparent-nonzero, r=lcnr

Fix another clashing_extern_declarations false positive.

Fixes rust-lang#75739.

Fix another clashing_extern_declarations false positive, this time for transparent newtype with a non-zero member.

r? @lcnr
…_typo, r=petrochenkov

Fix typo in TLS Model in Unstable Book
Add test for issue rust-lang#27130

rust-lang#27130 seems to be fixed by the llvm 11 update. The issue is marked with needs-test, so here it is. As some historical context, the generated code was fine until 1.38, and remained unoptimized from 1.38 up until the current nightly.

I've also added a pattern matching version that was fine on 1.45.2.
…, r=jyn514

Move to intra doc links for core::ptr::non_null

Helps with rust-lang#75080.

@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc

r? @jyn514
…r=ehuss

Fix typo (`thumbv8m.main-none-eabihf` is Mainline)
Improve help popup

Fixes rust-lang#75623.

The second commit is just a slight improvement: the help popup won't be created until someone presses "?" or ESC. Not a big improvement in itself but considering the low amount of code required, I think it was worth the shot.

r? @jyn514
Should not apply field accessing on enum

Closes rust-lang#75977
But I'm surprised that `x.py test --stage 1` and CI didn't catch this with existing testcase.
r? @estebank
@Dylan-DPC-zz
Copy link
Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Aug 27, 2020

📌 Commit e23290f has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 27, 2020
@bors
Copy link
Collaborator

bors commented Aug 27, 2020

⌛ Testing commit e23290f with merge f922f94dcb4092d91292eb86f66407f5f3e411c5...

@bors
Copy link
Collaborator

bors commented Aug 27, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 27, 2020
@camelid
Copy link
Member

camelid commented Aug 27, 2020

How do you access the logs for the failed build?

@bugadani
Copy link
Contributor

https://github.com/rust-lang-ci/rust/runs/1038546677 Looks like it's caused by #75910 :/

@Dylan-DPC-zz
Copy link
Author

failed in rollup

@Dylan-DPC-zz
Copy link
Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2020
@bugadani
Copy link
Contributor

@Dylan-DPC I think I fixed the issue, how should I proceed?

@Dylan-DPC-zz
Copy link
Author

i'll make a new rollup in a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.