Skip to content

Pin es-check version to prevent unrelated CI failures #82747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2021
Merged

Pin es-check version to prevent unrelated CI failures #82747

merged 1 commit into from
Mar 4, 2021

Conversation

JohnTitor
Copy link
Member

es-check v5.2.1 causes a lot of unrelated CI failures on mingw-check, e.g. #80723 (comment).
es-check v5.2.2 fixes it but let's pin its version to prevent further failures.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1000

@bors
Copy link
Collaborator

bors commented Mar 4, 2021

📌 Commit ed473af has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2021
@bors
Copy link
Collaborator

bors commented Mar 4, 2021

⌛ Testing commit ed473af with merge d539cda62d4cdab00330a99952899ca3d3b686b8...

@bors
Copy link
Collaborator

bors commented Mar 4, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 4, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@Mark-Simulacrum
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2021
@bors
Copy link
Collaborator

bors commented Mar 4, 2021

⌛ Testing commit ed473af with merge 45b3c28...

@bors
Copy link
Collaborator

bors commented Mar 4, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 45b3c28 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 4, 2021
@bors bors merged commit 45b3c28 into rust-lang:master Mar 4, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 4, 2021
@JohnTitor JohnTitor deleted the pin-es-check-version branch March 5, 2021 05:43
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.
6 participants
@JohnTitor @rust-highfive @Mark-Simulacrum @bors @rust-log-analyzer @rustbot