Skip to content

Update indexmap #91969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update indexmap #91969

wants to merge 1 commit into from

Conversation

pierwill
Copy link
Contributor

Update to version 1.7.0.

r? @cuviper

@pierwill
Update indexmap
62ee54d 
Update to version 1.7.0
@rust-highfive
Copy link
Contributor

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in src/tools/rustfmt.

cc @calebcartwright

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 15, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 15, 2021
@bjorn3
Copy link
Member

bjorn3 commented Dec 15, 2021

Rustc and cg_clif already specify 1.7.0 in their Cargo.lock. This bump in the Cargo.toml files doesn't hurt, but isn't necessary either.

@pierwill
Copy link
Contributor Author

Rustc and cg_clif already specify 1.7.0 in their Cargo.lock. This bump in the Cargo.toml files doesn't hurt, but isn't necessary either.

Ah okay, thanks! I do think it'd be nice to bump these. 😇

@calebcartwright
Copy link
Member

The rustfmt files updated under the tests directory are dummy placeholders that are never actually compiled/wouldn't impact the root level lockfile, but I don't have any concerns or objections with those changes either

@cuviper
Copy link
Member

cuviper commented Dec 15, 2021

I would like to merge a few indexmap PRs and publish a new release, and then we can actually make this a functional change with rustc-rayon support (indexmap-rs/indexmap#212) at least. I'll try to do that in the next few days.

@pierwill
Copy link
Contributor Author

pierwill commented Dec 16, 2021 via email

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2021
@pierwill pierwill marked this pull request as draft December 21, 2021 16:34
@pierwill pierwill closed this Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pierwill @rust-highfive @bjorn3 @calebcartwright @cuviper @rustbot