Skip to content

Commit 5be3a7c

Browse files
author
Ariel Ben-Yehuda
committed
add comments
1 parent f378b92 commit 5be3a7c

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

crates/native-c/src/demangle.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,12 @@ NODISCARD demangle_status rust_demangle_v0_demangle(const char *s, size_t s_len,
138138
inner = s+2;
139139
inner_len = s_len - 2;
140140
} else if (s_len >= 1 && !strncmp(s, "R", strlen("R"))) {
141+
// On Windows, dbghelp strips leading underscores, so we accept "R..."
142+
// form too.
141143
inner = s+1;
142144
inner_len = s_len - 1;
143145
} else if (s_len >= 3 && !strncmp(s, "__R", strlen("__R"))) {
146+
// On OSX, symbols are prefixed with an extra _
144147
inner = s+3;
145148
inner_len = s_len - 3;
146149
} else {
@@ -1682,9 +1685,12 @@ NODISCARD demangle_status rust_demangle_legacy_demangle(const char *s, size_t s_
16821685
inner = s + 3;
16831686
inner_len = s_len - 3;
16841687
} else if (s_len >= 2 && !strncmp(s, "ZN", 2)) {
1688+
// On Windows, dbghelp strips leading underscores, so we accept "ZN...E"
1689+
// form too.
16851690
inner = s + 2;
16861691
inner_len = s_len - 2;
16871692
} else if (s_len >= 4 && !strncmp(s, "__ZN", 4)) {
1693+
// On OSX, symbols are prefixed with an extra _
16881694
inner = s + 4;
16891695
inner_len = s_len - 4;
16901696
} else {

0 commit comments

Comments
 (0)