Skip to content

use repo name in push pr title #2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

use repo name in push pr title #2359

merged 1 commit into from
Apr 30, 2025
+1 −1

Conversation

@tshepang
Copy link
Member

@tshepang tshepang commented Apr 28, 2025 •
edited
Loading

Also, remove @ghost in pr description, to avoid confusion... thought it was a real user.
Heh, I see it has utility.

@tshepang
use repo name in push pr title
1b150ed 
I found "Rustc dev guide subtree update awkward"
@tshepang tshepang force-pushed the tshepang-repo-name branch from 9e96a52 to 1b150ed Compare April 28, 2025 04:51
@jieyouxu jieyouxu added S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content WG-rustc-dev-guide Working group: rustc-dev-guide labels Apr 29, 2025
jieyouxu
jieyouxu approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the ghost is intentional because otherwise it would by default rotate subtree sync PRs between compiler reviewers on active rotation, whereas usually only a subset of people are familiar with the sync workflow.

@jieyouxu jieyouxu merged commit 6eb758e into master Apr 30, 2025
1 check passed
@tshepang tshepang deleted the tshepang-repo-name branch April 30, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

No one assigned

Labels

S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content WG-rustc-dev-guide Working group: rustc-dev-guide

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tshepang @jieyouxu