tweak some git clone commands #2497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tshepang
commented
Jul 9, 2025
tshepang
commented
- --depth=1 is more useful for once-off uses, like on ci
- .git postfix on github repo url is not needed
- --depth=1 is more useful for once-off uses, like on ci - .git postfix on github repo url is not needed
Collaborator
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
rustbot
added
the
S-waiting-on-review
Member
|
|
Member
|
wasn't there a problem that depth 1 doesn't work properly with bootstrap? |
Member
|
For rust-lang/rust almost certainly, I was moreso wondering about the enzyme/llvm cases |
Member
|
I think depth=1 worked well for me even when contributing and saved some time, but then users should also know or learn related commands like unshallow. I guess having slower but simpler and more robust default is better, so lgtm. Thanks! |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.