Skip to content

Commit 33893d4

Browse files
pnkfelixpnkfelix
committed
Initial triage report template.
1 parent f8cc0b2 commit 33893d4

File tree

1 file changed

+229
-0
lines changed

1 file changed

+229
-0
lines changed

‎triage/2023-07-18.md

Lines changed: 229 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,229 @@
1+
# 2023-07-18 Triage Log
2+
3+
TODO: Summary
4+
5+
Triage done by **@???**.
6+
Revision range: [1d4f5affbdee00c816f961c227c6b28a3e725ce6..6b9236ed5a58879969ddcf4c35a6a24f6260e979](https://perf.rust-lang.org/?start=1d4f5affbdee00c816f961c227c6b28a3e725ce6&end=6b9236ed5a58879969ddcf4c35a6a24f6260e979&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 1.5% | [0.6%, 3.0%] | 11 |
13+
| Regressions ❌ <br /> (secondary) | 1.4% | [0.6%, 1.8%] | 11 |
14+
| Improvements ✅ <br /> (primary) | -1.6% | [-3.7%, -0.6%] | 46 |
15+
| Improvements ✅ <br /> (secondary) | -1.9% | [-4.2%, -0.4%] | 46 |
16+
| All ❌✅ (primary) | -1.0% | [-3.7%, 3.0%] | 57 |
17+
18+
19+
5 Regressions, 5 Improvements, 5 Mixed; ??? of them in rollups
20+
57 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
miri: protect Move() function arguments during the call [#113569](https://github.com/rust-lang/rust/pull/113569) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=910be1b3e83d8876a144441695b7a5077967296e&end=136dab66142115d9de16b4cfe2d8395d71a8ab6d&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.8% | [0.5%, 1.1%] | 13 |
29+
| Regressions ❌ <br /> (secondary) | 0.9% | [0.4%, 1.4%] | 11 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.8% | [0.5%, 1.1%] | 13 |
33+
34+
35+
Ignore flaky clippy tests. [#113621](https://github.com/rust-lang/rust/pull/113621) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1e6db3486da0f6474920477c01fca90453b7c428&end=33a2c2487ac5d9927830ea4c1844335c6b9f77db&stat=instructions:u)
36+
37+
| (instructions:u) | mean | range | count |
38+
|:----------------------------------:|:----:|:------------:|:-----:|
39+
| Regressions ❌ <br /> (primary) | 1.0% | [0.6%, 1.2%] | 7 |
40+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
41+
| Improvements ✅ <br /> (primary) | - | - | 0 |
42+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
43+
| All ❌✅ (primary) | 1.0% | [0.6%, 1.2%] | 7 |
44+
45+
46+
Rollup of 6 pull requests [#113673](https://github.com/rust-lang/rust/pull/113673) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a161ab00dbf660dd587ee42a8c855bac94047ddb&end=7bd81ee1902c049691d0a1f03be5558bee51d100&stat=instructions:u)
47+
48+
| (instructions:u) | mean | range | count |
49+
|:----------------------------------:|:----:|:------------:|:-----:|
50+
| Regressions ❌ <br /> (primary) | 1.2% | [1.2%, 1.2%] | 1 |
51+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
52+
| Improvements ✅ <br /> (primary) | - | - | 0 |
53+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
54+
| All ❌✅ (primary) | 1.2% | [1.2%, 1.2%] | 1 |
55+
56+
57+
Add even more GHA log groups [#113514](https://github.com/rust-lang/rust/pull/113514) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ad963232d9b987d66a6f8e6ec4141f672b8b9900&end=4d6e4260b2de66a356a2536320f339467dff0d2b&stat=instructions:u)
58+
59+
| (instructions:u) | mean | range | count |
60+
|:----------------------------------:|:----:|:------------:|:-----:|
61+
| Regressions ❌ <br /> (primary) | - | - | 0 |
62+
| Regressions ❌ <br /> (secondary) | 2.9% | [2.7%, 3.0%] | 6 |
63+
| Improvements ✅ <br /> (primary) | - | - | 0 |
64+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
65+
| All ❌✅ (primary) | - | - | 0 |
66+
67+
68+
Rollup of 3 pull requests [#113738](https://github.com/rust-lang/rust/pull/113738) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4124617c6ebe6b5b4df2c8c8400e87389c377dcc&end=2c718d12599ca00dc3957ec604cb3e87fe437124&stat=instructions:u)
69+
70+
| (instructions:u) | mean | range | count |
71+
|:----------------------------------:|:----:|:------------:|:-----:|
72+
| Regressions ❌ <br /> (primary) | 0.7% | [0.7%, 0.7%] | 1 |
73+
| Regressions ❌ <br /> (secondary) | 3.1% | [2.7%, 3.5%] | 6 |
74+
| Improvements ✅ <br /> (primary) | - | - | 0 |
75+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
76+
| All ❌✅ (primary) | 0.7% | [0.7%, 0.7%] | 1 |
77+
78+
79+
#### Improvements
80+
81+
Rewrite `UnDerefer`, again [#113316](https://github.com/rust-lang/rust/pull/113316) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fcaf04e715bf74ddcbba4c6b0f9adfa00bae1af6&end=5b733e2bcaf784e6a8c523a6d5e74d7263ec7915&stat=instructions:u)
82+
83+
| (instructions:u) | mean | range | count |
84+
|:----------------------------------:|:-----:|:--------------:|:-----:|
85+
| Regressions ❌ <br /> (primary) | 1.2% | [1.2%, 1.2%] | 1 |
86+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
87+
| Improvements ✅ <br /> (primary) | -0.9% | [-1.7%, -0.4%] | 14 |
88+
| Improvements ✅ <br /> (secondary) | -1.2% | [-2.0%, -0.2%] | 21 |
89+
| All ❌✅ (primary) | -0.8% | [-1.7%, 1.2%] | 15 |
90+
91+
92+
(re-)tighten sourceinfo span of adjustments in MIR [#112945](https://github.com/rust-lang/rust/pull/112945) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=136dab66142115d9de16b4cfe2d8395d71a8ab6d&end=da1d099f91ea387a2814a6244dd875a2048b486f&stat=instructions:u)
93+
94+
| (instructions:u) | mean | range | count |
95+
|:----------------------------------:|:-----:|:--------------:|:-----:|
96+
| Regressions ❌ <br /> (primary) | - | - | 0 |
97+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
98+
| Improvements ✅ <br /> (primary) | -0.7% | [-1.1%, -0.4%] | 18 |
99+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.6%, -0.5%] | 5 |
100+
| All ❌✅ (primary) | -0.7% | [-1.1%, -0.4%] | 18 |
101+
102+
103+
Bump bootstrap to 1.72 beta [#113637](https://github.com/rust-lang/rust/pull/113637) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1b3e68692592d71938df8e7fd8e53fbe5e7ef58c&end=a161ab00dbf660dd587ee42a8c855bac94047ddb&stat=instructions:u)
104+
105+
| (instructions:u) | mean | range | count |
106+
|:----------------------------------:|:-----:|:--------------:|:-----:|
107+
| Regressions ❌ <br /> (primary) | - | - | 0 |
108+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
109+
| Improvements ✅ <br /> (primary) | -0.9% | [-1.2%, -0.6%] | 12 |
110+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
111+
| All ❌✅ (primary) | -0.9% | [-1.2%, -0.6%] | 12 |
112+
113+
114+
Add a cache for `maybe_lint_level_root_bounded` [#113609](https://github.com/rust-lang/rust/pull/113609) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7d60819bfd0d66bdc300713101bd285350407038&end=fe03b46ee4688a99d7155b4f9dcd875b6903952d&stat=instructions:u)
115+
116+
| (instructions:u) | mean | range | count |
117+
|:----------------------------------:|:-----:|:--------------:|:-----:|
118+
| Regressions ❌ <br /> (primary) | - | - | 0 |
119+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
120+
| Improvements ✅ <br /> (primary) | -1.4% | [-3.4%, -0.5%] | 29 |
121+
| Improvements ✅ <br /> (secondary) | -1.9% | [-5.9%, -0.2%] | 33 |
122+
| All ❌✅ (primary) | -1.4% | [-3.4%, -0.5%] | 29 |
123+
124+
125+
Remove `LLVMRustCoverageHashCString` [#113430](https://github.com/rust-lang/rust/pull/113430) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=2c718d12599ca00dc3957ec604cb3e87fe437124&end=ffb9b61294b96c389d343a4c55b15400249d74e6&stat=instructions:u)
126+
127+
| (instructions:u) | mean | range | count |
128+
|:----------------------------------:|:-----:|:--------------:|:-----:|
129+
| Regressions ❌ <br /> (primary) | - | - | 0 |
130+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
131+
| Improvements ✅ <br /> (primary) | -0.7% | [-0.7%, -0.7%] | 2 |
132+
| Improvements ✅ <br /> (secondary) | -2.8% | [-3.2%, -2.4%] | 6 |
133+
| All ❌✅ (primary) | -0.7% | [-0.7%, -0.7%] | 2 |
134+
135+
136+
#### Mixed
137+
138+
Eliminate ZST allocations in `Box` and `Vec` [#113113](https://github.com/rust-lang/rust/pull/113113) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7a5814f922f85370e773f2001886b8f57002811c&end=cca3373706b8f5fa12a1b7f18222dde4c3ed6e32&stat=instructions:u)
139+
140+
| (instructions:u) | mean | range | count |
141+
|:----------------------------------:|:-----:|:--------------:|:-----:|
142+
| Regressions ❌ <br /> (primary) | 1.7% | [0.5%, 3.5%] | 3 |
143+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
144+
| Improvements ✅ <br /> (primary) | -1.0% | [-1.7%, -0.4%] | 2 |
145+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
146+
| All ❌✅ (primary) | 0.6% | [-1.7%, 3.5%] | 5 |
147+
148+
149+
Enable MIR reference propagation by default [#109025](https://github.com/rust-lang/rust/pull/109025) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5767cad9b8b58a5c0521c5ddd652a24d0c65f466&end=079e544174b79c372b4b4b473a01d699f128c2de&stat=instructions:u)
150+
151+
| (instructions:u) | mean | range | count |
152+
|:----------------------------------:|:-----:|:--------------:|:-----:|
153+
| Regressions ❌ <br /> (primary) | 1.2% | [0.5%, 2.5%] | 15 |
154+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.2%, 1.3%] | 7 |
155+
| Improvements ✅ <br /> (primary) | -0.9% | [-1.0%, -0.8%] | 3 |
156+
| Improvements ✅ <br /> (secondary) | -0.6% | [-1.1%, -0.4%] | 6 |
157+
| All ❌✅ (primary) | 0.8% | [-1.0%, 2.5%] | 18 |
158+
159+
160+
Resurrect: rustc_target: Add alignment to indirectly-passed by-value types, correcting the alignment of byval on x86 in the process. [#112157](https://github.com/rust-lang/rust/pull/112157) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4d6e4260b2de66a356a2536320f339467dff0d2b&end=7a17f577b3d437179cad254e299b2ace972487c5&stat=instructions:u)
161+
162+
| (instructions:u) | mean | range | count |
163+
|:----------------------------------:|:-----:|:--------------:|:-----:|
164+
| Regressions ❌ <br /> (primary) | 1.7% | [1.5%, 2.0%] | 6 |
165+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
166+
| Improvements ✅ <br /> (primary) | - | - | 0 |
167+
| Improvements ✅ <br /> (secondary) | -2.8% | [-2.9%, -2.8%] | 6 |
168+
| All ❌✅ (primary) | 1.7% | [1.5%, 2.0%] | 6 |
169+
170+
171+
Remove unneeded handling for `ExternalLocation::Unknown` in rustdoc render context [#113697](https://github.com/rust-lang/rust/pull/113697) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=425726d46b637f94995ca1c95f4f16cdb903d30e&end=4c8bb79d9f565115637cc6da739f8389e79f3a29&stat=instructions:u)
172+
173+
| (instructions:u) | mean | range | count |
174+
|:----------------------------------:|:-----:|:--------------:|:-----:|
175+
| Regressions ❌ <br /> (primary) | - | - | 0 |
176+
| Regressions ❌ <br /> (secondary) | 3.0% | [2.5%, 3.4%] | 6 |
177+
| Improvements ✅ <br /> (primary) | -1.1% | [-1.1%, -1.1%] | 1 |
178+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
179+
| All ❌✅ (primary) | -1.1% | [-1.1%, -1.1%] | 1 |
180+
181+
182+
Add support for allocators in `Rc` & `Arc` [#89132](https://github.com/rust-lang/rust/pull/89132) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1787f312907eee9a4a9ac010985d725ad9a03ab6&end=da6b55cc5eaf76ed6acb7dc2f7d611e32af7c9a7&stat=instructions:u)
183+
184+
| (instructions:u) | mean | range | count |
185+
|:----------------------------------:|:-----:|:--------------:|:-----:|
186+
| Regressions ❌ <br /> (primary) | 0.8% | [0.8%, 0.8%] | 1 |
187+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
188+
| Improvements ✅ <br /> (primary) | -1.3% | [-1.3%, -1.3%] | 1 |
189+
| Improvements ✅ <br /> (secondary) | -0.7% | [-0.8%, -0.5%] | 4 |
190+
| All ❌✅ (primary) | -0.3% | [-1.3%, 0.8%] | 2 |
191+
192+
193+
#### Untriaged Pull Requests
194+
195+
- [#113738 Rollup of 3 pull requests](https://github.com/rust-lang/rust/pull/113738)
196+
- [#113697 Remove unneeded handling for `ExternalLocation::Unknown` in rustdoc render context](https://github.com/rust-lang/rust/pull/113697)
197+
- [#113569 miri: protect Move() function arguments during the call](https://github.com/rust-lang/rust/pull/113569)
198+
- [#113514 Add even more GHA log groups](https://github.com/rust-lang/rust/pull/113514)
199+
- [#113485 Bump version to 1.73](https://github.com/rust-lang/rust/pull/113485)
200+
- [#113370 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/113370)
201+
- [#113320 Add some extra information to opaque type cycle errors](https://github.com/rust-lang/rust/pull/113320)
202+
- [#113306 Update debuginfo test runner to provide more useful output](https://github.com/rust-lang/rust/pull/113306)
203+
- [#113304 Upgrade to indexmap 2.0.0](https://github.com/rust-lang/rust/pull/113304)
204+
- [#113270 perform TokenStream replacement in-place when possible in expand_macro](https://github.com/rust-lang/rust/pull/113270)
205+
- [#113113 Eliminate ZST allocations in `Box` and `Vec`](https://github.com/rust-lang/rust/pull/113113)
206+
- [#113057 Rollup of 2 pull requests](https://github.com/rust-lang/rust/pull/113057)
207+
- [#112963 Stop bubbling out hidden types from the eval obligation queries](https://github.com/rust-lang/rust/pull/112963)
208+
- [#112882 Rewrite `UnDerefer`](https://github.com/rust-lang/rust/pull/112882)
209+
- [#112420 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/112420)
210+
- [#112157 Resurrect: rustc_target: Add alignment to indirectly-passed by-value types, correcting the alignment of byval on x86 in the process.](https://github.com/rust-lang/rust/pull/112157)
211+
- [#112083 Make `TrustedStep` require `Copy`](https://github.com/rust-lang/rust/pull/112083)
212+
- [#112016 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/112016)
213+
- [#112001 Enable MatchBranchSimplification](https://github.com/rust-lang/rust/pull/112001)
214+
- [#111869 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/111869)
215+
- [#111850 Specialize `StepBy<Range<{integer}>>`](https://github.com/rust-lang/rust/pull/111850)
216+
- [#111813 MIR: opt-in normalization of `BasicBlock` and `Local` numbering](https://github.com/rust-lang/rust/pull/111813)
217+
- [#111623 move `super_relate_consts` hack to `normalize_param_env_or_error`](https://github.com/rust-lang/rust/pull/111623)
218+
- [#111524 `ascii::Char`-ify the escaping code in `core`](https://github.com/rust-lang/rust/pull/111524)
219+
- [#111425 Populate effective visibilities in `rustc_privacy` (take 2)](https://github.com/rust-lang/rust/pull/111425)
220+
- [#111364 Remove the ThinLTO CU hack](https://github.com/rust-lang/rust/pull/111364)
221+
- [#111311 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/111311)
222+
- [#111306 Update hashbrown from 0.12.3 to 0.13.1 for std](https://github.com/rust-lang/rust/pull/111306)
223+
- [#111221 Combine three generalizer implementations](https://github.com/rust-lang/rust/pull/111221)
224+
- [#111007 Disable nrvo mir opt](https://github.com/rust-lang/rust/pull/111007)
225+
226+
#### Nags requiring follow up
227+
228+
TODO: Nags
229+

0 commit comments

Comments
 (0)