Skip to content

Commit 3dc219c

Browse files
rylevrylev
authored
Merge pull request #1710 from rylev/perf-2023-08-22
Add perf for 2023-08-22
2 parents 238fa37 + 30a4065 commit 3dc219c

File tree

1 file changed

+108
-0
lines changed

1 file changed

+108
-0
lines changed

‎triage/2023-08-22.md

Lines changed: 108 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
1+
# 2023-08-22 Triage Log
2+
3+
A week with very few real regressions and some good improvements through work done by @cjgillot who found a few spots where the compiler was doing unnecessary work.
4+
5+
Triage done by **@rylev**.
6+
Revision range: [e845910..d4a881](https://perf.rust-lang.org/?start=e8459109bbb440764c1c877032189a27b9e76c4e&end=d4a881e1433cd10e424843353e1f939f5a798f4e&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 1.4% | [0.5%, 2.6%] | 13 |
13+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.3%, 0.8%] | 8 |
14+
| Improvements ✅ <br /> (primary) | -0.7% | [-1.4%, -0.3%] | 59 |
15+
| Improvements ✅ <br /> (secondary) | -0.8% | [-1.3%, -0.3%] | 38 |
16+
| All ❌✅ (primary) | -0.3% | [-1.4%, 2.6%] | 72 |
17+
18+
19+
3 Regressions, 2 Improvements, 2 Mixed; 2 of them in rollups
20+
28 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Warn on inductive cycle in coherence leading to impls being considered not overlapping [#114023](https://github.com/rust-lang/rust/pull/114023) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d7e751006cb3691d1384b74196a9cb45447acfa8&end=a32978a5e8a3c34bb5caa1175f7404c2ede019b6&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 1.3% | [0.6%, 2.5%] | 10 |
29+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 1.3% | [0.6%, 2.5%] | 10 |
33+
- The author is investigating whether this is due to the use of a temporary lint or if there is some more fundamental change happening here.
34+
35+
36+
Rollup of 7 pull requests [#114879](https://github.com/rust-lang/rust/pull/114879) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4e3ce0e782a30d467ddbc542c3eb5d215eac1b9d&end=60713f4234c56e21f77e37c61dd731247d0b9429&stat=instructions:u)
37+
38+
| (instructions:u) | mean | range | count |
39+
|:----------------------------------:|:----:|:------------:|:-----:|
40+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.3%] | 2 |
41+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.4%, 0.6%] | 8 |
42+
| Improvements ✅ <br /> (primary) | - | - | 0 |
43+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
44+
| All ❌✅ (primary) | 0.3% | [0.3%, 0.3%] | 2 |
45+
- The perf result seems to just be noise.
46+
47+
48+
Remove conditional use of `Sharded` from query caches [#114892](https://github.com/rust-lang/rust/pull/114892) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f3b4c6746aa0e278797ae52e2c16fdef04136e3a&end=c5833f1956bea474034ffec5ab2c75f343548038&stat=instructions:u)
49+
50+
| (instructions:u) | mean | range | count |
51+
|:----------------------------------:|:----:|:------------:|:-----:|
52+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.5%] | 3 |
53+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.4%, 0.6%] | 8 |
54+
| Improvements ✅ <br /> (primary) | - | - | 0 |
55+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
56+
| All ❌✅ (primary) | 0.4% | [0.2%, 0.5%] | 3 |
57+
- Perf results are small and worth the simplification in code.
58+
59+
60+
#### Improvements
61+
62+
Do not mark shallow_lint_levels_on as eval_always. [#114536](https://github.com/rust-lang/rust/pull/114536) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=656ee47db32e882fb02913f6204e09cc7a41a50e&end=4e3ce0e782a30d467ddbc542c3eb5d215eac1b9d&stat=instructions:u)
63+
64+
| (instructions:u) | mean | range | count |
65+
|:----------------------------------:|:-----:|:--------------:|:-----:|
66+
| Regressions ❌ <br /> (primary) | - | - | 0 |
67+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.4%, 0.4%] | 1 |
68+
| Improvements ✅ <br /> (primary) | -0.7% | [-1.3%, -0.3%] | 30 |
69+
| Improvements ✅ <br /> (secondary) | -0.5% | [-1.0%, -0.3%] | 15 |
70+
| All ❌✅ (primary) | -0.7% | [-1.3%, -0.3%] | 30 |
71+
72+
73+
Only run MaybeInitializedPlaces dataflow once to elaborate drops [#111555](https://github.com/rust-lang/rust/pull/111555) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=07438b0928c6691d6ee734a5a77823ec143be94d&end=f3b4c6746aa0e278797ae52e2c16fdef04136e3a&stat=instructions:u)
74+
75+
| (instructions:u) | mean | range | count |
76+
|:----------------------------------:|:-----:|:--------------:|:-----:|
77+
| Regressions ❌ <br /> (primary) | - | - | 0 |
78+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.6%, 0.6%] | 1 |
79+
| Improvements ✅ <br /> (primary) | -0.8% | [-1.3%, -0.3%] | 27 |
80+
| Improvements ✅ <br /> (secondary) | -0.7% | [-1.1%, -0.4%] | 32 |
81+
| All ❌✅ (primary) | -0.8% | [-1.3%, -0.3%] | 27 |
82+
83+
84+
#### Mixed
85+
86+
add a csky-unknown-linux-gnuabiv2 target [#113658](https://github.com/rust-lang/rust/pull/113658) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f960bdf1feacad4ab5a079c76ff31053c1799f71&end=180dffba142c47240ca0d93096ce90b9fd97c8d7&stat=instructions:u)
87+
88+
| (instructions:u) | mean | range | count |
89+
|:----------------------------------:|:-----:|:--------------:|:-----:|
90+
| Regressions ❌ <br /> (primary) | 1.3% | [0.3%, 1.9%] | 3 |
91+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.3%] | 1 |
92+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.2%] | 4 |
93+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.4%, -0.2%] | 4 |
94+
| All ❌✅ (primary) | 0.4% | [-0.3%, 1.9%] | 7 |
95+
- Noise
96+
97+
98+
Rollup of 10 pull requests [#114852](https://github.com/rust-lang/rust/pull/114852) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4f4dae055b470c889968b02964a28477f9daff62&end=c57393e4f8b88444fbf0985a81a2d662862f2733&stat=instructions:u)
99+
100+
| (instructions:u) | mean | range | count |
101+
|:----------------------------------:|:-----:|:--------------:|:-----:|
102+
| Regressions ❌ <br /> (primary) | 0.5% | [0.5%, 0.6%] | 4 |
103+
| Regressions ❌ <br /> (secondary) | 1.0% | [1.0%, 1.0%] | 3 |
104+
| Improvements ✅ <br /> (primary) | - | - | 0 |
105+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
106+
| All ❌✅ (primary) | 0.5% | [0.5%, 0.6%] | 4 |
107+
- Noise
108+

0 commit comments

Comments
 (0)