Skip to content

Commit 3eb0f21

Browse files
KobzolKobzol
authored
Merge pull request #2419 from Kobzol/triage-2026-03-10
Add 2026-03-10 triage
2 parents 4bfa110 + 4bb67d6 commit 3eb0f21

File tree

1 file changed

+131
-0
lines changed

1 file changed

+131
-0
lines changed

‎triage/2026/2026-03-10.md‎

Lines changed: 131 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,131 @@
1+
# 2026-03-10 Triage Log
2+
3+
Almost no regressions this week, while there was a handful of performance improvements
4+
caused by the ongoing refactoring of the compiler query system. The largest one was from
5+
[#153521](https://github.com/rust-lang/rust/pull/153521).
6+
7+
Triage done by **@kobzol**.
8+
Revision range: [ddd36bd5..3945997a](https://perf.rust-lang.org/?start=ddd36bd57051f796850345b76c17e9402e28a9e4&end=3945997aabf6165261ef3419534c1ad59d9dc5c6&absolute=false&stat=instructions%3Au)
9+
10+
**Summary**:
11+
12+
| (instructions:u) | mean | range | count |
13+
|:----------------------------------:|:-----:|:--------------:|:-----:|
14+
| Regressions ❌ <br /> (primary) | 0.4% | [0.4%, 0.5%] | 3 |
15+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.1%, 1.2%] | 8 |
16+
| Improvements ✅ <br /> (primary) | -0.9% | [-2.5%, -0.1%] | 110 |
17+
| Improvements ✅ <br /> (secondary) | -0.8% | [-2.7%, -0.1%] | 77 |
18+
| All ❌✅ (primary) | -0.9% | [-2.5%, 0.5%] | 113 |
19+
20+
21+
0 Regressions, 6 Improvements, 3 Mixed; 5 of them in rollups
22+
31 artifact comparisons made in total
23+
24+
#### Improvements
25+
26+
Remove `tls::with_related_context`. [#153316](https://github.com/rust-lang/rust/pull/153316) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f82485388963286763f8c8a9261ac227627f6a18&end=ff086354c9fc93e1da1d2f4d255456624fbcd099&stat=instructions:u)
27+
28+
| (instructions:u) | mean | range | count |
29+
|:----------------------------------:|:-----:|:--------------:|:-----:|
30+
| Regressions ❌ <br /> (primary) | - | - | 0 |
31+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
32+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.1%] | 5 |
33+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.2%, -0.0%] | 21 |
34+
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.1%] | 5 |
35+
36+
37+
Get rid of `QueryVTable::call_query_method_fn` [#153387](https://github.com/rust-lang/rust/pull/153387) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ea5573a6c6e5e932f917ec4a8e6d8efdeb9f394d&end=085c58f2c0c7db692a2eaf2b8970ff474eed9183&stat=instructions:u)
38+
39+
| (instructions:u) | mean | range | count |
40+
|:----------------------------------:|:-----:|:--------------:|:-----:|
41+
| Regressions ❌ <br /> (primary) | - | - | 0 |
42+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
43+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.2%] | 15 |
44+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.2%, -0.2%] | 5 |
45+
| All ❌✅ (primary) | -0.3% | [-0.3%, -0.2%] | 15 |
46+
47+
48+
Rollup of 2 pull requests [#153541](https://github.com/rust-lang/rust/pull/153541) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=085c58f2c0c7db692a2eaf2b8970ff474eed9183&end=e3d66fe39ae70380fa2365c008e2927479114844&stat=instructions:u)
49+
50+
| (instructions:u) | mean | range | count |
51+
|:----------------------------------:|:-----:|:--------------:|:-----:|
52+
| Regressions ❌ <br /> (primary) | - | - | 0 |
53+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
54+
| Improvements ✅ <br /> (primary) | - | - | 0 |
55+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.3%, -0.1%] | 9 |
56+
| All ❌✅ (primary) | - | - | 0 |
57+
58+
59+
Don't use incremental disk-cache for query `predicates_of` [#153521](https://github.com/rust-lang/rust/pull/153521) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e370b60cf2b0d3e4b55923ec1558c5b5f8970cfb&end=052b9c23daccef254010e43d6c4d0a5459caec5b&stat=instructions:u)
60+
61+
| (instructions:u) | mean | range | count |
62+
|:----------------------------------:|:-----:|:--------------:|:-----:|
63+
| Regressions ❌ <br /> (primary) | - | - | 0 |
64+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
65+
| Improvements ✅ <br /> (primary) | -0.8% | [-2.0%, -0.1%] | 92 |
66+
| Improvements ✅ <br /> (secondary) | -1.0% | [-2.6%, -0.2%] | 40 |
67+
| All ❌✅ (primary) | -0.8% | [-2.0%, -0.1%] | 92 |
68+
69+
70+
Rollup of 6 pull requests [#153579](https://github.com/rust-lang/rust/pull/153579) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b41f22de2a13a0babd28771e96feef4c309f54aa&end=eda4fc7733ee89e484d7120cafbd80dcb2fce66e&stat=instructions:u)
71+
72+
| (instructions:u) | mean | range | count |
73+
|:----------------------------------:|:-----:|:--------------:|:-----:|
74+
| Regressions ❌ <br /> (primary) | - | - | 0 |
75+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
76+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.4%, -0.1%] | 3 |
77+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.2%, -0.2%] | 1 |
78+
| All ❌✅ (primary) | -0.2% | [-0.4%, -0.1%] | 3 |
79+
80+
81+
core: respect precision in `ByteStr` `Display` [#153025](https://github.com/rust-lang/rust/pull/153025) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=eda4fc7733ee89e484d7120cafbd80dcb2fce66e&end=98e7077b903559d7a4fafb775cd5292cc9427b67&stat=instructions:u)
82+
83+
| (instructions:u) | mean | range | count |
84+
|:----------------------------------:|:-----:|:--------------:|:-----:|
85+
| Regressions ❌ <br /> (primary) | - | - | 0 |
86+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
87+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.8%, -0.2%] | 4 |
88+
| Improvements ✅ <br /> (secondary) | -0.8% | [-0.8%, -0.8%] | 1 |
89+
| All ❌✅ (primary) | -0.4% | [-0.8%, -0.2%] | 4 |
90+
91+
92+
#### Mixed
93+
94+
Rollup of 10 pull requests [#153304](https://github.com/rust-lang/rust/pull/153304) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8ddf4ef064fb702fed0f3d239ec8d0bac607484e&end=ec818fda361ca216eb186f5cf45131bd9c776bb4&stat=instructions:u)
95+
96+
| (instructions:u) | mean | range | count |
97+
|:----------------------------------:|:-----:|:--------------:|:-----:|
98+
| Regressions ❌ <br /> (primary) | 0.4% | [0.1%, 0.6%] | 5 |
99+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.0%, 0.5%] | 3 |
100+
| Improvements ✅ <br /> (primary) | -0.7% | [-1.0%, -0.4%] | 2 |
101+
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.1%, -0.1%] | 1 |
102+
| All ❌✅ (primary) | 0.1% | [-1.0%, 0.6%] | 7 |
103+
104+
- Only tiny perf. changes and it was overall a wash.
105+
- Marked as triaged.
106+
107+
Rollup of 8 pull requests [#153377](https://github.com/rust-lang/rust/pull/153377) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d9563937fa3b030c5845811113505070109414d2&end=d933cf483edf1605142ac6899ff32536c0ad8b22&stat=instructions:u)
108+
109+
| (instructions:u) | mean | range | count |
110+
|:----------------------------------:|:-----:|:--------------:|:-----:|
111+
| Regressions ❌ <br /> (primary) | 0.1% | [0.1%, 0.1%] | 1 |
112+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.1%, 0.3%] | 6 |
113+
| Improvements ✅ <br /> (primary) | - | - | 0 |
114+
| Improvements ✅ <br /> (secondary) | -0.8% | [-0.8%, -0.7%] | 2 |
115+
| All ❌✅ (primary) | 0.1% | [0.1%, 0.1%] | 1 |
116+
117+
- The deep-vector tiny regression was likely https://github.com/rust-lang/rust/pull/153258, but it doesn't seem worth it to deal with that.
118+
- Marked as triaged.
119+
120+
Rollup of 4 pull requests [#153552](https://github.com/rust-lang/rust/pull/153552) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=052b9c23daccef254010e43d6c4d0a5459caec5b&end=c3d014032f39a252387ca7c4fe4039c1b7c01eb4&stat=instructions:u)
121+
122+
| (instructions:u) | mean | range | count |
123+
|:----------------------------------:|:-----:|:--------------:|:-----:|
124+
| Regressions ❌ <br /> (primary) | - | - | 0 |
125+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.3%] | 1 |
126+
| Improvements ✅ <br /> (primary) | -2.3% | [-2.5%, -2.2%] | 4 |
127+
| Improvements ✅ <br /> (secondary) | -0.8% | [-0.8%, -0.8%] | 1 |
128+
| All ❌✅ (primary) | -2.3% | [-2.5%, -2.2%] | 4 |
129+
130+
- The coercions tiny loss swung back in the next PR.
131+
- Marked as triaged.

0 commit comments

Comments
 (0)