Merge pull request #2391 from Kobzol/history-graph

Consider codegen backend in graphs page

Author: Kobzol

site/frontend/src/graph/api.ts

@@ -13,6 +13,7 @@ export async function loadGraphs(
     benchmark: selector.benchmark,
     scenario: selector.scenario,
     profile: selector.profile,
+    backend: selector.backend,
     target: selector.target,
   };
   return await getJson<CompileGraphData>(GRAPH_DATA_URL, params);

site/frontend/src/graph/data.ts

@@ -9,7 +9,8 @@ export interface GraphsSelector {
   benchmark: string | null;
   scenario: string | null;
   profile: string | null;
-  target: string;
+  backend: string | null;
+  target: string | null;
 }
 
 export interface Series {

site/frontend/src/pages/compare/compile/table/benchmark-detail-graph.vue

@@ -79,6 +79,7 @@ async function renderGraphs(detail: CompileDetailGraphs) {
       start: selector.start,
       end: selector.end,
       target: selector.target,
+      backend: selector.backend,
       kind,
     };
 

site/frontend/src/pages/compare/compile/table/benchmark-detail.vue

@@ -70,8 +70,8 @@ function graphLink(
   // Move to `30 days ago` to display history of the test case
   const start = formatDate(getPastDate(new Date(commit.date), 30));
   const end = commit.commit;
-  const {benchmark, profile, scenario} = testCase;
-  return `/index.html?start=${start}&end=${end}&benchmark=${benchmark}&profile=${profile}&scenario=${scenario}&stat=${metric}`;
+  const {benchmark, profile, scenario, target, backend} = testCase;
+  return `/index.html?start=${start}&end=${end}&benchmark=${benchmark}&profile=${profile}&scenario=${scenario}&target=${target}&backend=${backend}&stat=${metric}`;
 }
 
 const metadata = computed(

site/frontend/src/pages/compare/runtime/benchmark-detail-graph.vue

@@ -67,6 +67,7 @@ async function renderGraphs(detail: RuntimeDetailGraphs) {
       profile: null,
       scenario: null,
       target: selector.target,
+      backend: null,
       kind,
     };
 

site/frontend/src/pages/graphs/page.vue

@@ -9,11 +9,7 @@ import {
   navigateToUrlParams,
 } from "../../utils/navigation";
 import {renderPlots} from "../../graph/render";
-import {
-  BenchmarkInfo,
-  loadBenchmarkInfo,
-  DEFAULT_COMPILE_TARGET_TRIPLE,
-} from "../../api";
+import {BenchmarkInfo, loadBenchmarkInfo} from "../../api";
 import {loadGraphs} from "../../graph/api";
 
 function loadSelectorFromUrl(urlParams: Dict<string>): GraphsSelector {
@@ -24,7 +20,8 @@ function loadSelectorFromUrl(urlParams: Dict<string>): GraphsSelector {
   const benchmark = urlParams["benchmark"] ?? null;
   const scenario = urlParams["scenario"] ?? null;
   const profile = urlParams["profile"] ?? null;
-  const target = urlParams["target"] ?? DEFAULT_COMPILE_TARGET_TRIPLE;
+  const target = urlParams["target"] ?? null;
+  const backend = urlParams["backend"] ?? null;
   return {
     start,
     end,
@@ -33,6 +30,7 @@ function loadSelectorFromUrl(urlParams: Dict<string>): GraphsSelector {
     benchmark,
     scenario,
     profile,
+    backend,
     target,
   };
 }

site/src/api.rs

@@ -119,6 +119,7 @@ pub mod graphs {
         pub benchmark: Option<String>,
         pub scenario: Option<String>,
         pub profile: Option<String>,
+        pub backend: Option<String>,
         pub target: Option<String>,
     }
 

site/src/request_handlers/graph.rs

@@ -206,6 +206,7 @@ pub async fn handle_graphs(
             benchmark: None,
             scenario: None,
             profile: None,
+            backend: None,
             target: None,
         };
 
@@ -250,14 +251,16 @@ async fn create_graphs(
     let scenario_selector = create_selector(&request.scenario).unwrap_or(Ok(Selector::All))?;
     let target_selector = create_selector(&request.target)
         .unwrap_or(Ok(Selector::One(Target::X86_64UnknownLinuxGnu)))?;
+    let backend_selector =
+        create_selector(&request.backend).unwrap_or(Ok(Selector::One(CodegenBackend::Llvm)))?;
 
     let interpolated_responses: Vec<_> = ctxt
         .statistic_series(
             CompileBenchmarkQuery::default()
                 .benchmark(benchmark_selector)
                 .profile(profile_selector)
                 .scenario(scenario_selector)
-                .backend(Selector::One(CodegenBackend::Llvm))
+                .backend(backend_selector)
                 .target(target_selector)
                 .metric(Selector::One(request.stat.parse()?)),
             artifact_ids.clone(),