Do not warn if a step is ended multiple times

Author: Kobzol

collector/src/lib.rs

@@ -353,13 +353,9 @@ pub struct CollectorCtx {
 }
 
 impl CollectorCtx {
-    pub async fn start_compile_step(
-        &self,
-        conn: &dyn Connection,
-        benchmark_name: &BenchmarkName,
-    ) -> bool {
+    pub async fn start_compile_step(&self, conn: &dyn Connection, benchmark_name: &BenchmarkName) {
         conn.collector_start_step(self.artifact_row_id, &benchmark_name.0)
-            .await
+            .await;
     }
 
     pub async fn end_compile_step(&self, conn: &dyn Connection, benchmark_name: &BenchmarkName) {

database/src/pool/postgres.rs

@@ -1095,19 +1095,14 @@ where
             == 1
     }
     async fn collector_end_step(&self, aid: ArtifactIdNumber, step: &str) {
-        let did_modify = self
-            .conn()
+        self.conn()
             .execute(
                 "update collector_progress set end_time = statement_timestamp() \
-                where aid = $1 and step = $2 and start_time is not null and end_time is null;",
+                where aid = $1 and step = $2 and start_time is not null;",
                 &[&(aid.0 as i32), &step],
             )
             .await
-            .unwrap()
-            == 1;
-        if !did_modify {
-            log::error!("did not end {} for {:?}", step, aid);
-        }
+            .unwrap();
     }
     async fn collector_remove_step(&self, aid: ArtifactIdNumber, step: &str) {
         self.conn()

database/src/pool/sqlite.rs

@@ -1050,18 +1050,13 @@ impl Connection for SqliteConnection {
     }
 
     async fn collector_end_step(&self, aid: ArtifactIdNumber, step: &str) {
-        let did_modify = self
-            .raw_ref()
+        self.raw_ref()
             .execute(
                 "update collector_progress set end = strftime('%s','now') \
-                where aid = ? and step = ? and start is not null and end is null;",
+                where aid = ? and step = ? and start is not null;",
                 params![&aid.0, &step],
             )
-            .unwrap()
-            == 1;
-        if !did_modify {
-            log::error!("did not end {} for {:?}", step, aid);
-        }
+            .unwrap();
     }
 
     async fn collector_remove_step(&self, aid: ArtifactIdNumber, step: &str) {