Skip to content

Commit 4f299a6

Browse files
lqdlqd
authored
Merge pull request #2205 from rylev/perf-2025-07-22
Add perf triage for 2025-07-22
2 parents 3982771 + f660014 commit 4f299a6

File tree

1 file changed

+245
-0
lines changed

1 file changed

+245
-0
lines changed

‎triage/2025/2025-07-22.md

Lines changed: 245 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,245 @@
1+
# 2025-07-22 Triage Log
2+
3+
Fairly busy week with improvements outweighing regressions. Most of the regressions were considered acceptable given the circumstances (such as landing a long awaited feature). By far the biggest win comes from being a bit smarter about hashing certain information inside of `DefPathHash`. Since hashing happens quite a lot in the compiler's query system, optimizing when hashing happens can have large performance impacts.
4+
5+
Triage done by **@rylev**.
6+
Revision range: [a9fb6103..3f9f20f7](https://perf.rust-lang.org/?start=a9fb6103b05c6ad6eee6bed4c0bb5a2e8e1024c6&end=3f9f20f71dd945fe7d044e274094a53c90788269&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.4% | [0.1%, 0.9%] | 47 |
13+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.1%, 2.7%] | 69 |
14+
| Improvements ✅ <br /> (primary) | -0.8% | [-4.1%, -0.2%] | 122 |
15+
| Improvements ✅ <br /> (secondary) | -0.7% | [-2.5%, -0.0%] | 143 |
16+
| All ❌✅ (primary) | -0.5% | [-4.1%, 0.9%] | 169 |
17+
18+
19+
3 Regressions, 8 Improvements, 8 Mixed; 8 of them in rollups
20+
35 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Miri subtree update [#144019](https://github.com/rust-lang/rust/pull/144019) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5795086bdfe7ed988aa53a110bd0692c33d8755b&end=fd2eb391d032181459773f3498c17b198513e0d0&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | - | - | 0 |
29+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.5%] | 12 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | - | - | 0 |
33+
- Noise
34+
35+
36+
Implement unstable trait impl [#140399](https://github.com/rust-lang/rust/pull/140399) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fd2eb391d032181459773f3498c17b198513e0d0&end=014bd8290f084c714995205a9116e6c035419ae6&stat=instructions:u)
37+
38+
| (instructions:u) | mean | range | count |
39+
|:----------------------------------:|:-----:|:--------------:|:-----:|
40+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.8%] | 65 |
41+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.1%, 1.3%] | 60 |
42+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.3%, -0.2%] | 2 |
43+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
44+
| All ❌✅ (primary) | 0.3% | [-0.3%, 0.8%] | 67 |
45+
- "The perf regressions were deemed to be acceptable for the time being, to avoid delaying this feature."
46+
47+
48+
tests: Require `run-fail` ui tests to have an exit code (`SIGABRT` not ok) [#143002](https://github.com/rust-lang/rust/pull/143002) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ee3a0783df39cb11c5706e38805eb9258b4fad79&end=6707bf0f59485cf054ac1095725df43220e4be20&stat=instructions:u)
49+
50+
| (instructions:u) | mean | range | count |
51+
|:----------------------------------:|:----:|:------------:|:-----:|
52+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.3%] | 1 |
53+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.4%, 0.8%] | 6 |
54+
| Improvements ✅ <br /> (primary) | - | - | 0 |
55+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
56+
| All ❌✅ (primary) | 0.3% | [0.3%, 0.3%] | 1 |
57+
- Noise
58+
59+
60+
#### Improvements
61+
62+
Rollup of 12 pull requests [#144028](https://github.com/rust-lang/rust/pull/144028) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1c6de215099bbe33668de762f9591187f6c25eef&end=5795086bdfe7ed988aa53a110bd0692c33d8755b&stat=instructions:u)
63+
64+
| (instructions:u) | mean | range | count |
65+
|:----------------------------------:|:-----:|:--------------:|:-----:|
66+
| Regressions ❌ <br /> (primary) | - | - | 0 |
67+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.3%] | 1 |
68+
| Improvements ✅ <br /> (primary) | - | - | 0 |
69+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.2%] | 13 |
70+
| All ❌✅ (primary) | - | - | 0 |
71+
72+
73+
Rollup of 15 pull requests [#144044](https://github.com/rust-lang/rust/pull/144044) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=014bd8290f084c714995205a9116e6c035419ae6&end=f8f6997469237299c1d60814c7b9828602a1f8e4&stat=instructions:u)
74+
75+
| (instructions:u) | mean | range | count |
76+
|:----------------------------------:|:-----:|:--------------:|:-----:|
77+
| Regressions ❌ <br /> (primary) | - | - | 0 |
78+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.5%] | 3 |
79+
| Improvements ✅ <br /> (primary) | -0.7% | [-1.6%, -0.2%] | 21 |
80+
| Improvements ✅ <br /> (secondary) | -0.4% | [-1.5%, -0.2%] | 27 |
81+
| All ❌✅ (primary) | -0.7% | [-1.6%, -0.2%] | 21 |
82+
83+
84+
Only inherit local hash for paths [#142903](https://github.com/rust-lang/rust/pull/142903) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f8f6997469237299c1d60814c7b9828602a1f8e4&end=8c12d76304fcceaeaad0d67209e5727e94f5f2b8&stat=instructions:u)
85+
86+
| (instructions:u) | mean | range | count |
87+
|:----------------------------------:|:-----:|:--------------:|:-----:|
88+
| Regressions ❌ <br /> (primary) | - | - | 0 |
89+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
90+
| Improvements ✅ <br /> (primary) | -0.4% | [-1.0%, -0.2%] | 140 |
91+
| Improvements ✅ <br /> (secondary) | -0.5% | [-1.2%, -0.1%] | 105 |
92+
| All ❌✅ (primary) | -0.4% | [-1.0%, -0.2%] | 140 |
93+
94+
95+
Rollup of 11 pull requests [#144130](https://github.com/rust-lang/rust/pull/144130) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6caa224a242d4c7b06c317969c51862815a4454b&end=82310651b93a594a3fd69015e1562186a080d94c&stat=instructions:u)
96+
97+
| (instructions:u) | mean | range | count |
98+
|:----------------------------------:|:-----:|:--------------:|:-----:|
99+
| Regressions ❌ <br /> (primary) | - | - | 0 |
100+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
101+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.3%] | 3 |
102+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.4%, -0.2%] | 6 |
103+
| All ❌✅ (primary) | -0.3% | [-0.4%, -0.3%] | 3 |
104+
105+
106+
Rollup of 5 pull requests [#144181](https://github.com/rust-lang/rust/pull/144181) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0d9592026226f5a667a0da60c13b955e0b486a07&end=ee3a0783df39cb11c5706e38805eb9258b4fad79&stat=instructions:u)
107+
108+
| (instructions:u) | mean | range | count |
109+
|:----------------------------------:|:-----:|:--------------:|:-----:|
110+
| Regressions ❌ <br /> (primary) | - | - | 0 |
111+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
112+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.3%, -0.1%] | 3 |
113+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.9%, -0.2%] | 7 |
114+
| All ❌✅ (primary) | -0.2% | [-0.3%, -0.1%] | 3 |
115+
116+
117+
Weekly `cargo update` [#143861](https://github.com/rust-lang/rust/pull/143861) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0864097cd31ee30f5081ba588a5c9820c2c6fc71&end=9982d6462bedf1e793f7b2dbd655a4e57cdf67d4&stat=instructions:u)
118+
119+
| (instructions:u) | mean | range | count |
120+
|:----------------------------------:|:-----:|:--------------:|:-----:|
121+
| Regressions ❌ <br /> (primary) | - | - | 0 |
122+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
123+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.2%] | 3 |
124+
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.1%, -0.1%] | 1 |
125+
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.2%] | 3 |
126+
127+
128+
Consider param-env for sizedness fast path [#143309](https://github.com/rust-lang/rust/pull/143309) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9982d6462bedf1e793f7b2dbd655a4e57cdf67d4&end=460259d14de0274b97b8801e08cb2fe5f16fdac5&stat=instructions:u)
129+
130+
| (instructions:u) | mean | range | count |
131+
|:----------------------------------:|:-----:|:--------------:|:-----:|
132+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.3%] | 2 |
133+
| Regressions ❌ <br /> (secondary) | 0.1% | [0.1%, 0.1%] | 1 |
134+
| Improvements ✅ <br /> (primary) | -1.3% | [-2.9%, -0.3%] | 16 |
135+
| Improvements ✅ <br /> (secondary) | -1.1% | [-2.9%, -0.1%] | 19 |
136+
| All ❌✅ (primary) | -1.1% | [-2.9%, 0.3%] | 18 |
137+
138+
139+
Rollup of 8 pull requests [#144238](https://github.com/rust-lang/rust/pull/144238) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e05ab47e6c418fb2b9faa2eae9a7e70c65c98eaa&end=67819923ac8ea353aaa775303f4c3aacbf41d010&stat=instructions:u)
140+
141+
| (instructions:u) | mean | range | count |
142+
|:----------------------------------:|:-----:|:--------------:|:-----:|
143+
| Regressions ❌ <br /> (primary) | - | - | 0 |
144+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
145+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.3%] | 6 |
146+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
147+
| All ❌✅ (primary) | -0.3% | [-0.4%, -0.3%] | 6 |
148+
149+
150+
#### Mixed
151+
152+
`std::vec`: Add UB check for `set_len`, `from_raw_parts_in`, and etc. [#143877](https://github.com/rust-lang/rust/pull/143877) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e27f16a499074ba9a87f7f7641d9f64c572863bc&end=3014e79f9c8d5510ea7b3a3b70d171d0948b1e96&stat=instructions:u)
153+
154+
| (instructions:u) | mean | range | count |
155+
|:----------------------------------:|:-----:|:--------------:|:-----:|
156+
| Regressions ❌ <br /> (primary) | 0.7% | [0.3%, 0.9%] | 4 |
157+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.3%, 0.6%] | 2 |
158+
| Improvements ✅ <br /> (primary) | -1.1% | [-2.1%, -0.4%] | 3 |
159+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
160+
| All ❌✅ (primary) | -0.1% | [-2.1%, 0.9%] | 7 |
161+
- Perf is acceptable for being able to catch UB
162+
163+
164+
resolve: Merge `NameBindingKind::Module` into `NameBindingKind::Res` [#143458](https://github.com/rust-lang/rust/pull/143458) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f21fbac535ab2c3bc50db20547f4d48477357103&end=1c6de215099bbe33668de762f9591187f6c25eef&stat=instructions:u)
165+
166+
| (instructions:u) | mean | range | count |
167+
|:----------------------------------:|:-----:|:--------------:|:-----:|
168+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 1 |
169+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.7%, 0.8%] | 3 |
170+
| Improvements ✅ <br /> (primary) | -0.5% | [-2.1%, -0.1%] | 30 |
171+
| Improvements ✅ <br /> (secondary) | -0.4% | [-1.4%, -0.0%] | 65 |
172+
| All ❌✅ (primary) | -0.5% | [-2.1%, 0.2%] | 31 |
173+
- Improvements vastly outweigh regressions (which might just be noise)
174+
175+
176+
Rollup of 11 pull requests [#144058](https://github.com/rust-lang/rust/pull/144058) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8c12d76304fcceaeaad0d67209e5727e94f5f2b8&end=bf5e6cc7a7a7eb03e3ed9b875d76530eddd47d5f&stat=instructions:u)
177+
178+
| (instructions:u) | mean | range | count |
179+
|:----------------------------------:|:-----:|:--------------:|:-----:|
180+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 1 |
181+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
182+
| Improvements ✅ <br /> (primary) | - | - | 0 |
183+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.6%, -0.2%] | 15 |
184+
| All ❌✅ (primary) | 0.2% | [0.2%, 0.2%] | 1 |
185+
- The only regression seems like it might just be returning to a previous baseline so it's not worth investigating.
186+
187+
188+
`-Zhigher-ranked-assumptions`: Consider WF of coroutine witness when proving outlives assumptions [#143545](https://github.com/rust-lang/rust/pull/143545) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e4662966273ed58b51f9ff8d682accc202aa1210&end=1aa5b2246560ce85b42fa8b33e5927c5de3fa389&stat=instructions:u)
189+
190+
| (instructions:u) | mean | range | count |
191+
|:----------------------------------:|:-----:|:--------------:|:-----:|
192+
| Regressions ❌ <br /> (primary) | 0.3% | [0.1%, 0.5%] | 29 |
193+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.0%, 0.6%] | 50 |
194+
| Improvements ✅ <br /> (primary) | - | - | 0 |
195+
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.1%, -0.1%] | 1 |
196+
| All ❌✅ (primary) | 0.3% | [0.1%, 0.5%] | 29 |
197+
- Asked the author and reviewer for thoughts on performance since the regressions were certainly not unexpected, but the PR was merged anyway.
198+
199+
200+
Rollup of 11 pull requests [#144109](https://github.com/rust-lang/rust/pull/144109) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1aa5b2246560ce85b42fa8b33e5927c5de3fa389&end=6c0a912e5a45904cf537f34876b16ae71d899f86&stat=instructions:u)
201+
202+
| (instructions:u) | mean | range | count |
203+
|:----------------------------------:|:-----:|:--------------:|:-----:|
204+
| Regressions ❌ <br /> (primary) | 0.4% | [0.4%, 0.4%] | 3 |
205+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.5%] | 8 |
206+
| Improvements ✅ <br /> (primary) | -1.5% | [-1.5%, -1.5%] | 1 |
207+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
208+
| All ❌✅ (primary) | -0.1% | [-1.5%, 0.4%] | 4 |
209+
- The relative size of the regressions are fairly small, I don't think it's worth the investigation.
210+
211+
212+
Split-up stability_index query [#143845](https://github.com/rust-lang/rust/pull/143845) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=82310651b93a594a3fd69015e1562186a080d94c&end=8f08b3a32478b8d0507732800ecb548a76e0fd0c&stat=instructions:u)
213+
214+
| (instructions:u) | mean | range | count |
215+
|:----------------------------------:|:-----:|:--------------:|:-----:|
216+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.4%] | 29 |
217+
| Regressions ❌ <br /> (secondary) | 2.0% | [0.1%, 3.3%] | 15 |
218+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.6%, -0.2%] | 23 |
219+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.5%, -0.2%] | 14 |
220+
| All ❌✅ (primary) | 0.0% | [-0.6%, 0.4%] | 52 |
221+
- As [stated here](https://github.com/rust-lang/rust/pull/143845#pullrequestreview-3024720852), the perf regressions were considered acceptable.
222+
223+
224+
Rollup of 9 pull requests [#144145](https://github.com/rust-lang/rust/pull/144145) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ebd8557637b33cc09b6ee8273f3154d5d3af6a15&end=1079c5edb2bd837e5c4cf8c7db2892db359a3862&stat=instructions:u)
225+
226+
| (instructions:u) | mean | range | count |
227+
|:----------------------------------:|:-----:|:--------------:|:-----:|
228+
| Regressions ❌ <br /> (primary) | - | - | 0 |
229+
| Regressions ❌ <br /> (secondary) | 1.4% | [0.5%, 2.8%] | 9 |
230+
| Improvements ✅ <br /> (primary) | - | - | 0 |
231+
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.3%, -0.0%] | 2 |
232+
| All ❌✅ (primary) | - | - | 0 |
233+
234+
235+
Simplify discriminant codegen for niche-encoded variants which don't wrap across an integer boundary [#143784](https://github.com/rust-lang/rust/pull/143784) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1079c5edb2bd837e5c4cf8c7db2892db359a3862&end=83825dd277503edf5d7eda6be8b5fb9896f343f5&stat=instructions:u)
236+
237+
| (instructions:u) | mean | range | count |
238+
|:----------------------------------:|:-----:|:--------------:|:-----:|
239+
| Regressions ❌ <br /> (primary) | 0.7% | [0.4%, 0.8%] | 4 |
240+
| Regressions ❌ <br /> (secondary) | 1.6% | [1.6%, 1.6%] | 1 |
241+
| Improvements ✅ <br /> (primary) | -0.4% | [-1.3%, -0.2%] | 16 |
242+
| Improvements ✅ <br /> (secondary) | -0.5% | [-1.5%, -0.2%] | 20 |
243+
| All ❌✅ (primary) | -0.2% | [-1.3%, 0.8%] | 20 |
244+
- [Perf was considered acceptable](https://github.com/rust-lang/rust/pull/143784#issuecomment-3092568339).
245+

0 commit comments

Comments
 (0)