Skip to content

Commit 512571d

Browse files
pnkfelixpnkfelix
committed
triage for this week.
1 parent 665e70d commit 512571d

File tree

1 file changed

+192
-0
lines changed

1 file changed

+192
-0
lines changed

‎triage/2023-05-23.md

Lines changed: 192 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,192 @@
1+
# 2023-05-23 Triage Log
2+
3+
There were a few regressions, but most were expected, and one in particular (PR
4+
#111807) is expected yield gains in object code performance at the expense of a
5+
slight compile-time hit. There are a couple PR's that need future followup,
6+
namely PRs #111364 and #111524.
7+
8+
Triage done by **@pnkfelix**.
9+
Revision range: [3ea9ad53..cda5becc](https://perf.rust-lang.org/?start=3ea9ad532474343426e564b997891e459cda89a6&end=cda5becc27cbc7106646fbc40aacea5e7896d954&absolute=false&stat=instructions%3Au)
10+
11+
**Summary**:
12+
13+
| (instructions:u) | mean | range | count |
14+
|:----------------------------------:|:-----:|:--------------:|:-----:|
15+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 2.3%] | 28 |
16+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.2%, 0.7%] | 19 |
17+
| Improvements ✅ <br /> (primary) | -0.9% | [-4.4%, -0.3%] | 11 |
18+
| Improvements ✅ <br /> (secondary) | -0.8% | [-2.2%, -0.4%] | 11 |
19+
| All ❌✅ (primary) | 0.1% | [-4.4%, 2.3%] | 39 |
20+
21+
22+
3 Regressions, 2 Improvements, 5 Mixed; 2 of them in rollups
23+
51 artifact comparisons made in total
24+
25+
#### Regressions
26+
27+
Remove the ThinLTO CU hack [#111364](https://github.com/rust-lang/rust/pull/111364) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=24c180c438b5ee9a150d20b9822bd7712bef8f62&end=77fb0cd3aa276919e00397f526616c5036562ea1&stat=instructions:u)
28+
29+
| (instructions:u) | mean | range | count |
30+
|:----------------------------------:|:----:|:------------:|:-----:|
31+
| Regressions ❌ <br /> (primary) | 1.6% | [1.1%, 2.2%] | 2 |
32+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
33+
| Improvements ✅ <br /> (primary) | - | - | 0 |
34+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
35+
| All ❌✅ (primary) | 1.6% | [1.1%, 2.2%] | 2 |
36+
37+
* This is being discussed on the comment thread for PR #111364.
38+
* what is worrisome is not instructions:u, but rather the regressions to size:linked_artifact (aka binary sizes).
39+
* the PR author is going to try to replicate locally and investigate further if so.
40+
41+
Add creation time support to `FileTimes` on apple and windows [#109773](https://github.com/rust-lang/rust/pull/109773) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8a281f9c796ee8cbebb07bbeec04ef2f2dd8db45&end=521f4dae1bdf7fe9cf9436ecef9ee7c7442708bf&stat=instructions:u)
42+
43+
| (instructions:u) | mean | range | count |
44+
|:----------------------------------:|:----:|:------------:|:-----:|
45+
| Regressions ❌ <br /> (primary) | 0.8% | [0.7%, 0.8%] | 4 |
46+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.3%, 0.7%] | 6 |
47+
| Improvements ✅ <br /> (primary) | - | - | 0 |
48+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
49+
| All ❌✅ (primary) | 0.8% | [0.7%, 0.8%] | 4 |
50+
51+
* already marked as triaged.
52+
53+
54+
[rustc_ty_utils] Treat `drop_in_place`'s *mut argument like &mut when adding LLVM attributes [#111807](https://github.com/rust-lang/rust/pull/111807) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=cda5becc27cbc7106646fbc40aacea5e7896d954&end=f3d597b31c0f101a02c230798afa31a36bdacbc6&stat=instructions:u)
55+
56+
| (instructions:u) | mean | range | count |
57+
|:----------------------------------:|:-----:|:--------------:|:-----:|
58+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.7%] | 17 |
59+
| Regressions ❌ <br /> (secondary) | 1.3% | [0.2%, 2.9%] | 6 |
60+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.2%] | 1 |
61+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
62+
| All ❌✅ (primary) | 0.4% | [-0.2%, 0.7%] | 18 |
63+
64+
65+
* This change emits more attributes; it is expected to slow down the compiler, and that is compensated by the fact that it enables better code-generation from what we emit out of the compiler
66+
* marking as triaged.
67+
68+
#### Improvements
69+
70+
Rollup of 7 pull requests [#111650](https://github.com/rust-lang/rust/pull/111650) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b652d9a0fd5c5a7eeacd1ae8299166941c221230&end=e77366b57b799dfa3ce1fcb850c068723a3213ee&stat=instructions:u)
71+
72+
| (instructions:u) | mean | range | count |
73+
|:----------------------------------:|:-----:|:--------------:|:-----:|
74+
| Regressions ❌ <br /> (primary) | - | - | 0 |
75+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
76+
| Improvements ✅ <br /> (primary) | -2.3% | [-4.4%, -0.6%] | 3 |
77+
| Improvements ✅ <br /> (secondary) | -2.2% | [-2.5%, -2.0%] | 2 |
78+
| All ❌✅ (primary) | -2.3% | [-4.4%, -0.6%] | 3 |
79+
80+
* solely improvements to rustdoc benchmarks
81+
82+
Rollup of 7 pull requests [#111721](https://github.com/rust-lang/rust/pull/111721) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ba6f5e3b4d60ea5a847cd4402cca594cd40b218f&end=fdd030127cc68afec44a8d3f6341525dd34e50ae&stat=instructions:u)
83+
84+
| (instructions:u) | mean | range | count |
85+
|:----------------------------------:|:-----:|:--------------:|:-----:|
86+
| Regressions ❌ <br /> (primary) | - | - | 0 |
87+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
88+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.3%, -0.2%] | 3 |
89+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.4%, -0.2%] | 6 |
90+
| All ❌✅ (primary) | -0.2% | [-0.3%, -0.2%] | 3 |
91+
92+
* minor improvement to primary regex and secondary externs.
93+
94+
#### Mixed
95+
96+
Specialize query execution for incremental and non-incremental [#108062](https://github.com/rust-lang/rust/pull/108062) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9239760da89cd8e9a51536beeb0a23762064037d&end=b652d9a0fd5c5a7eeacd1ae8299166941c221230&stat=instructions:u)
97+
98+
| (instructions:u) | mean | range | count |
99+
|:----------------------------------:|:-----:|:--------------:|:-----:|
100+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.3%] | 9 |
101+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.2%, 2.9%] | 5 |
102+
| Improvements ✅ <br /> (primary) | -0.6% | [-1.1%, -0.3%] | 17 |
103+
| Improvements ✅ <br /> (secondary) | -0.8% | [-1.2%, -0.2%] | 31 |
104+
| All ❌✅ (primary) | -0.3% | [-1.1%, 0.3%] | 26 |
105+
106+
* the sea of green improvements to scenario=full outweighs the occasional (and minor) red regressions to incr cases.
107+
* marking as triaged.
108+
109+
Merge return place with other locals in CopyProp. [#111556](https://github.com/rust-lang/rust/pull/111556) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e77366b57b799dfa3ce1fcb850c068723a3213ee&end=5c3a3362f86f9748b4a6cb18b147893774a189ac&stat=instructions:u)
110+
111+
| (instructions:u) | mean | range | count |
112+
|:----------------------------------:|:-----:|:--------------:|:-----:|
113+
| Regressions ❌ <br /> (primary) | - | - | 0 |
114+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.4%, 0.4%] | 2 |
115+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.7%, -0.2%] | 17 |
116+
| Improvements ✅ <br /> (secondary) | -0.8% | [-0.9%, -0.7%] | 4 |
117+
| All ❌✅ (primary) | -0.4% | [-0.7%, -0.2%] | 17 |
118+
119+
* already marked as triaged.
120+
121+
Shorten backtraces for queries in ICEs [#108938](https://github.com/rust-lang/rust/pull/108938) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=77fb0cd3aa276919e00397f526616c5036562ea1&end=77c836e1ae582661924d3b6ec4d57a2de120f59f&stat=instructions:u)
122+
123+
| (instructions:u) | mean | range | count |
124+
|:----------------------------------:|:-----:|:--------------:|:-----:|
125+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.4%] | 3 |
126+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.2%, 0.6%] | 10 |
127+
| Improvements ✅ <br /> (primary) | - | - | 0 |
128+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.3%, -0.2%] | 3 |
129+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.4%] | 3 |
130+
131+
* already marked as triaged.
132+
133+
do not allow inference in `predicate_must_hold` (alternative approach) [#110100](https://github.com/rust-lang/rust/pull/110100) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=92f5dea0ebe2e34ad8411e8cd8a0c97dd45b3400&end=19ca5692f69d20643656bf501fd171f1907ef875&stat=instructions:u)
134+
135+
| (instructions:u) | mean | range | count |
136+
|:----------------------------------:|:-----:|:--------------:|:-----:|
137+
| Regressions ❌ <br /> (primary) | 1.1% | [0.9%, 1.4%] | 6 |
138+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
139+
| Improvements ✅ <br /> (primary) | - | - | 0 |
140+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
141+
| All ❌✅ (primary) | 1.1% | [0.9%, 1.4%] | 6 |
142+
143+
* diesel took a 1% regression in various scenarios.
144+
* there are indications from T-types that this is fixing a bug
145+
* therefore, the performance regression is acceptable; marking as triaged.
146+
147+
`ascii::Char`-ify the escaping code in `core` [#111524](https://github.com/rust-lang/rust/pull/111524) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7047d97e012d5ed90cf2837c361150bc149837b4&end=e86fd62b6b198584a47798eb271d4b54c4dc96ec&stat=instructions:u)
148+
149+
| (instructions:u) | mean | range | count |
150+
|:----------------------------------:|:-----:|:--------------:|:-----:|
151+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.7%] | 6 |
152+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
153+
| Improvements ✅ <br /> (primary) | -0.6% | [-0.7%, -0.6%] | 3 |
154+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.6%, -0.4%] | 3 |
155+
| All ❌✅ (primary) | 0.1% | [-0.7%, 0.7%] | 9 |
156+
157+
* lqd identified most of this as noise.
158+
* however, there was a bump on the compile-time for html5ever that has not yet receded as of 2023-05-23; i.e. that might not be noise.
159+
* therefore, not yet marking as triaged...
160+
161+
#### Untriaged Pull Requests
162+
163+
- [#111807 [rustc_ty_utils] Treat `drop_in_place`'s *mut argument like &mut when adding LLVM attributes](https://github.com/rust-lang/rust/pull/111807)
164+
- [#111524 `ascii::Char`-ify the escaping code in `core`](https://github.com/rust-lang/rust/pull/111524)
165+
- [#111425 Populate effective visibilities in `rustc_privacy` (take 2)](https://github.com/rust-lang/rust/pull/111425)
166+
- [#111364 Remove the ThinLTO CU hack](https://github.com/rust-lang/rust/pull/111364)
167+
- [#111311 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/111311)
168+
- [#111306 Update hashbrown from 0.12.3 to 0.13.1 for std](https://github.com/rust-lang/rust/pull/111306)
169+
- [#111221 Combine three generalizer implementations](https://github.com/rust-lang/rust/pull/111221)
170+
- [#111007 Disable nrvo mir opt](https://github.com/rust-lang/rust/pull/111007)
171+
- [#110967 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/110967)
172+
- [#110546 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/110546)
173+
- [#110542 resolve: Remove `module_children_untracked`](https://github.com/rust-lang/rust/pull/110542)
174+
- [#110440 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/110440)
175+
- [#110100 do not allow inference in `predicate_must_hold` (alternative approach)](https://github.com/rust-lang/rust/pull/110100)
176+
- [#110012 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/110012)
177+
- [#109900 Only enable ConstProp at mir-opt-level >= 2.](https://github.com/rust-lang/rust/pull/109900)
178+
- [#109732 Uplift `clippy::{drop,forget}_{ref,copy}` lints](https://github.com/rust-lang/rust/pull/109732)
179+
- [#109692 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/109692)
180+
- [#109588 Alloc `hir::Lit` in an arena to remove the destructor from `Expr`](https://github.com/rust-lang/rust/pull/109588)
181+
- [#109247 Permit MIR inlining without #[inline]](https://github.com/rust-lang/rust/pull/109247)
182+
- [#109097 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/109097)
183+
- [#108934 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/108934)
184+
- [#108872 Strengthen state tracking in const-prop](https://github.com/rust-lang/rust/pull/108872)
185+
- [#108830 Treat projections with infer as placeholder during fast reject in new solver](https://github.com/rust-lang/rust/pull/108830)
186+
- [#108587 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/108587)
187+
- [#108080 Add a builtin `FnPtr` trait that is implemented for all function pointers](https://github.com/rust-lang/rust/pull/108080)
188+
- [#108062 Specialize query execution for incremental and non-incremental](https://github.com/rust-lang/rust/pull/108062)
189+
- [#108025 rustdoc: add more tooltips to intra-doc links](https://github.com/rust-lang/rust/pull/108025)
190+
- [#107833 Factor query arena allocation out from query caches](https://github.com/rust-lang/rust/pull/107833)
191+
- [#107783 rustdoc: simplify DOM for `.item-table`](https://github.com/rust-lang/rust/pull/107783)
192+
- [#107765 rustc/rustdoc: Perform name resolver cleanups enabled by #94857](https://github.com/rust-lang/rust/pull/107765)

0 commit comments

Comments
 (0)