PR Feedback; don't mutate the benchmark_request in memory & fix a typo in the query

Author: Jamesbarford

database/src/pool.rs

@@ -258,7 +258,7 @@ pub trait Connection: Send + Sync {
     /// it has been marked as completed else `false` meaning there was no change
     async fn mark_benchmark_request_as_completed(
         &self,
-        benchmark_request: &mut BenchmarkRequest,
+        benchmark_request: &BenchmarkRequest,
     ) -> anyhow::Result<bool>;
 }
 

database/src/pool/postgres.rs

@@ -1891,7 +1891,7 @@ where
 
     async fn mark_benchmark_request_as_completed(
         &self,
-        benchmark_request: &mut BenchmarkRequest,
+        benchmark_request: &BenchmarkRequest,
     ) -> anyhow::Result<bool> {
         anyhow::ensure!(
             benchmark_request.tag().is_some(),
@@ -1914,7 +1914,7 @@ where
                     status = $1,
                     completed_at = NOW()
                 WHERE
-                    banchmark_request.tag = $2
+                    benchmark_request.tag = $2
                     AND benchmark_request.status != $1
                     AND NOT EXISTS (
                         SELECT
@@ -1957,8 +1957,6 @@ where
         // presence to determine if the request was marked as completed
         if let Some(row) = row {
             let completed_at = row.get::<_, DateTime<Utc>>(0);
-            // Also mutate our object
-            benchmark_request.status = BenchmarkRequestStatus::Completed { completed_at };
             Ok(true)
         } else {
             Ok(false)

database/src/pool/sqlite.rs

@@ -1356,7 +1356,7 @@ impl Connection for SqliteConnection {
 
     async fn mark_benchmark_request_as_completed(
         &self,
-        _benchmark_request: &mut BenchmarkRequest,
+        _benchmark_request: &BenchmarkRequest,
     ) -> anyhow::Result<bool> {
         no_queue_implementation_abort!()
     }

site/src/job_queue/mod.rs

@@ -246,17 +246,14 @@ async fn try_enqueue_next_benchmark_request(
     let queue = build_queue(conn, index).await?;
 
     #[allow(clippy::never_loop)]
-    for mut request in queue {
+    for request in queue {
         match request.status() {
             BenchmarkRequestStatus::ArtifactsReady => {
                 enqueue_benchmark_request(conn, &request).await?;
                 break;
             }
             BenchmarkRequestStatus::InProgress => {
-                if conn
-                    .mark_benchmark_request_as_completed(&mut request)
-                    .await?
-                {
+                if conn.mark_benchmark_request_as_completed(&request).await? {
                     index.add_tag(request.tag().unwrap());
                     continue;
                 }