PR Feedback: Use execute and row count, change zulip link to infra

Author: Jamesbarford

database/src/pool/postgres.rs

@@ -1634,9 +1634,9 @@ where
         &self,
         benchmark_request: &BenchmarkRequest,
     ) -> anyhow::Result<BenchmarkRequestInsertResult> {
-        let rows = self
+        let row_insert_count = self
             .conn()
-            .query(
+            .execute(
                 r#"
                 INSERT INTO benchmark_request(
                     tag,
@@ -1650,8 +1650,7 @@ where
                     commit_date
                 )
                 VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9)
-                ON CONFLICT DO NOTHING
-                RETURNING id;
+                ON CONFLICT DO NOTHING;
             "#,
                 &[
                     &benchmark_request.tag(),
@@ -1667,7 +1666,7 @@ where
             )
             .await
             .context("Failed to insert benchmark request")?;
-        if rows.is_empty() {
+        if row_insert_count == 0 {
             // Allows us to handle duplicated cases without the database auto
             // erroring
             Ok(BenchmarkRequestInsertResult::NothingInserted)

site/src/request_handlers/github.rs

@@ -108,7 +108,7 @@ async fn record_try_benchmark_request_without_artifacts(
         Ok(BenchmarkRequestInsertResult::Inserted) => get_awaiting_on_bors_message(),
         Err(e) => {
             log::error!("Failed to insert release benchmark request: {e}");
-            "Something went wrong! This is most likely an internal failure, please let us know on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/247081-t-compiler.2Fperformance)".to_string()
+            "Something went wrong! This is most likely an internal failure, please let us know on [Zulip]( https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra)".to_string()
         }
     }
 }