Skip to content

Commit 584304c

Browse files
authored
Merge pull request #1498 from rust-lang/compare-show-raw-data
Store "Display raw data" checkbox in URL in compare page
2 parents 9310694 + 322dbba commit 584304c

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

site/static/compare.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
274274
</span>
275275
</span>
276276
</div>
277-
<input type="checkbox" v-model="showRawData" style="margin-left: 20px;" />
277+
<input type="checkbox" v-model="filter.showRawData" style="margin-left: 20px;" />
278278
</div>
279279
<button @click="resetFilter" style="margin-right: 10px;">Reset filters</button>
280280
<button @click="exportToMarkdown"
@@ -315,7 +315,7 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
315315
<test-cases-table
316316
title="Primary"
317317
:cases="testCases.filter(c => c.category === 'primary')"
318-
:show-raw-data="showRawData"
318+
:show-raw-data="filter.showRawData"
319319
:commit-a="data.a"
320320
:commit-b="data.b"
321321
:stat="stat"
@@ -329,7 +329,7 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
329329
<test-cases-table
330330
title="Secondary"
331331
:cases="testCases.filter(c => c.category === 'secondary')"
332-
:show-raw-data="showRawData"
332+
:show-raw-data="filter.showRawData"
333333
:commit-a="data.a"
334334
:commit-b="data.b"
335335
:stat="stat"

site/static/compare/script.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ function createDefaultFilter() {
1111
return {
1212
name: null,
1313
nonRelevant: false,
14+
showRawData: false,
1415
profile: {
1516
check: true,
1617
debug: true,
@@ -49,6 +50,7 @@ function initializeFilterFromUrl() {
4950
return {
5051
name: params.get("name"),
5152
nonRelevant: getBoolOrDefault("nonRelevant", defaultFilter.nonRelevant),
53+
showRawData: getBoolOrDefault("showRawData", defaultFilter.showRawData),
5254
profile: {
5355
check: getBoolOrDefault("check", defaultFilter.profile.check),
5456
debug: getBoolOrDefault("debug", defaultFilter.profile.debug),
@@ -88,6 +90,7 @@ function storeFilterToUrl(filter) {
8890

8991
storeOrReset("name", filter.name || null, defaultFilter.name);
9092
storeOrReset("nonRelevant", filter.nonRelevant, defaultFilter.nonRelevant);
93+
storeOrReset("showRawData", filter.showRawData, defaultFilter.showRawData);
9194
storeOrReset("check", filter.profile.check, defaultFilter.profile.check);
9295
storeOrReset("debug", filter.profile.debug, defaultFilter.profile.debug);
9396
storeOrReset("opt", filter.profile.opt, defaultFilter.profile.opt);
@@ -123,7 +126,6 @@ const app = Vue.createApp({
123126
data() {
124127
return {
125128
filter: initializeFilterFromUrl(),
126-
showRawData: false,
127129
data: null,
128130
dataLoading: false
129131
}

0 commit comments

Comments
 (0)