Skip to content

Commit 5905b73

Browse files
pnkfelixpnkfelix
authored
Merge pull request #1496 from pnkfelix/triage-2022-11-14
triage for this week.
2 parents 2481375 + 7d95654 commit 5905b73

File tree

1 file changed

+184
-0
lines changed

1 file changed

+184
-0
lines changed

‎triage/2022-11-14.md

Lines changed: 184 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,184 @@
1+
# 2022-11-14 Triage Log
2+
3+
A light week for triage. The biggest of the three regressions has a (hopeful)
4+
fix up already. The second biggest is a regression we are accepting for sake
5+
of correctness of incremental-compilation. The third regression is small and may
6+
well be removed as the type system internals are improved. max-rss seems stable.
7+
8+
Triage done by **@pnkfelix**.
9+
Revision range: [57d3c58e..96ddd32c](https://perf.rust-lang.org/?start=57d3c58ed6e0faf89a62411f96c000ffc9fd3937&end=96ddd32c4bfb1d78f0cd03eb068b1710a8cebeef&absolute=false&stat=instructions%3Au)
10+
11+
**Summary**:
12+
13+
| (instructions:u) | mean | range | count |
14+
|:----------------------------------:|:-----:|:--------------:|:-----:|
15+
| Regressions ❌ <br /> (primary) | 0.7% | [0.2%, 1.4%] | 87 |
16+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.2%, 2.3%] | 36 |
17+
| Improvements ✅ <br /> (primary) | -0.5% | [-1.2%, -0.3%] | 12 |
18+
| Improvements ✅ <br /> (secondary) | -0.9% | [-2.0%, -0.2%] | 9 |
19+
| All ❌✅ (primary) | 0.5% | [-1.2%, 1.4%] | 99 |
20+
21+
22+
3 Regressions, 4 Improvements, 3 Mixed; 2 of them in rollups
23+
40 artifact comparisons made in total
24+
25+
#### Regressions
26+
27+
Better error for HRTB error from generator interior [#103171](https://github.com/rust-lang/rust/pull/103171) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8d36948b1519c77a54867523453fef3e0c3a648b&end=bc2504a83ca6ee8f6717dedd0721b90ffcbe1300&stat=instructions:u)
28+
29+
| (instructions:u) | mean | range | count |
30+
|:----------------------------------:|:----:|:------------:|:-----:|
31+
| Regressions ❌ <br /> (primary) | - | - | 0 |
32+
| Regressions ❌ <br /> (secondary) | 1.6% | [1.3%, 2.1%] | 6 |
33+
| Improvements ✅ <br /> (primary) | - | - | 0 |
34+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
35+
| All ❌✅ (primary) | - | - | 0 |
36+
37+
* Already triaged (by two different people).
38+
* Also, according to comment thread, this change is slated to be removed once
39+
binders support implied bounds, so even if there is a minor regression
40+
attached to this PR, the PR should nonetheless go away eventually.
41+
42+
Recover wrong-cased keywords that start items [#99918](https://github.com/rust-lang/rust/pull/99918) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c1a859b25a95999ba276075bbd8e284ea675b41a&end=5b82ea74b705799665b5a676b162f30d26f5108c&stat=instructions:u)
43+
44+
| (instructions:u) | mean | range | count |
45+
|:----------------------------------:|:----:|:------------:|:-----:|
46+
| Regressions ❌ <br /> (primary) | 0.6% | [0.2%, 1.2%] | 80 |
47+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.3%, 1.4%] | 11 |
48+
| Improvements ✅ <br /> (primary) | - | - | 0 |
49+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
50+
| All ❌✅ (primary) | 0.6% | [0.2%, 1.2%] | 80 |
51+
52+
* Believed to be fixed by https://github.com/rust-lang/rust/pull/104410
53+
54+
55+
Hash spans when interning types [#104282](https://github.com/rust-lang/rust/pull/104282) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=229e875878a682411df8b8adae39372302d2b4c7&end=3be81dd0cedef3c83fba7047857418633708890f&stat=instructions:u)
56+
57+
| (instructions:u) | mean | range | count |
58+
|:----------------------------------:|:----:|:------------:|:-----:|
59+
| Regressions ❌ <br /> (primary) | 0.5% | [0.2%, 0.9%] | 44 |
60+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.2%, 0.9%] | 19 |
61+
| Improvements ✅ <br /> (primary) | - | - | 0 |
62+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
63+
| All ❌✅ (primary) | 0.5% | [0.2%, 0.9%] | 44 |
64+
65+
* already triaged; its a regression we are accepting for sake of correctness
66+
67+
#### Improvements
68+
69+
Remove allow(rustc::potential_query_instability) in rustc_trait_selection [#103723](https://github.com/rust-lang/rust/pull/103723) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0aaad9e757207657064d70bf9e6c1e6eb327bf15&end=cc9b259b5e94e4543b96dca236e3a1af5ec496c9&stat=instructions:u)
70+
71+
| (instructions:u) | mean | range | count |
72+
|:----------------------------------:|:-----:|:--------------:|:-----:|
73+
| Regressions ❌ <br /> (primary) | - | - | 0 |
74+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
75+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.5%, -0.5%] | 1 |
76+
| Improvements ✅ <br /> (secondary) | -0.8% | [-1.0%, -0.5%] | 7 |
77+
| All ❌✅ (primary) | -0.5% | [-0.5%, -0.5%] | 1 |
78+
79+
80+
Rollup of 9 pull requests [#104236](https://github.com/rust-lang/rust/pull/104236) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=11fa0850f03ae49fe1053a21bcdcf8a301668ad8&end=01a6f30324deb8f9c9ec4a70c53690c5d073a244&stat=instructions:u)
81+
82+
| (instructions:u) | mean | range | count |
83+
|:----------------------------------:|:-----:|:--------------:|:-----:|
84+
| Regressions ❌ <br /> (primary) | - | - | 0 |
85+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
86+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.2%] | 21 |
87+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.6%, -0.2%] | 12 |
88+
| All ❌✅ (primary) | -0.3% | [-0.4%, -0.2%] | 21 |
89+
90+
91+
Rollup of 9 pull requests [#104246](https://github.com/rust-lang/rust/pull/104246) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=01a6f30324deb8f9c9ec4a70c53690c5d073a244&end=a3c0a023611fcaf5ae3ec242d7d60e356041d25f&stat=instructions:u)
92+
93+
| (instructions:u) | mean | range | count |
94+
|:----------------------------------:|:-----:|:--------------:|:-----:|
95+
| Regressions ❌ <br /> (primary) | - | - | 0 |
96+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
97+
| Improvements ✅ <br /> (primary) | -0.7% | [-0.8%, -0.6%] | 3 |
98+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.6%, -0.3%] | 4 |
99+
| All ❌✅ (primary) | -0.7% | [-0.8%, -0.6%] | 3 |
100+
101+
102+
Retry failed macro matching for diagnostics [#103898](https://github.com/rust-lang/rust/pull/103898) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5b82ea74b705799665b5a676b162f30d26f5108c&end=b7b7f2716ee1655a696d3d64c3e12638d0dd19c0&stat=instructions:u)
103+
104+
| (instructions:u) | mean | range | count |
105+
|:----------------------------------:|:-----:|:--------------:|:-----:|
106+
| Regressions ❌ <br /> (primary) | - | - | 0 |
107+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
108+
| Improvements ✅ <br /> (primary) | -0.8% | [-1.3%, -0.3%] | 11 |
109+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
110+
| All ❌✅ (primary) | -0.8% | [-1.3%, -0.3%] | 11 |
111+
112+
113+
#### Mixed
114+
115+
resolve: More detailed effective visibility tracking for imports [#103965](https://github.com/rust-lang/rust/pull/103965) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ddfe1e87f7c85c03773c29180a931447fcd03b65&end=c5842b0be783dffa5a49693541acb79115c7eeef&stat=instructions:u)
116+
117+
| (instructions:u) | mean | range | count |
118+
|:----------------------------------:|:-----:|:--------------:|:-----:|
119+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.4%] | 4 |
120+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.4%] | 5 |
121+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.2%] | 3 |
122+
| Improvements ✅ <br /> (secondary) | -0.5% | [-1.1%, -0.4%] | 9 |
123+
| All ❌✅ (primary) | 0.1% | [-0.2%, 0.4%] | 7 |
124+
125+
* This is an internal refactoring that we need to get more precise tracking of imports in presence of globs.
126+
* treating the regressions as acceptable; marked it as triaged.
127+
128+
rustc_codegen_ssa: Better code generation for niche discriminants. [#102872](https://github.com/rust-lang/rust/pull/102872) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b7b7f2716ee1655a696d3d64c3e12638d0dd19c0&end=742d3f02c243964e5b868d90afd60c2907be5853&stat=instructions:u)
129+
130+
| (instructions:u) | mean | range | count |
131+
|:----------------------------------:|:-----:|:--------------:|:-----:|
132+
| Regressions ❌ <br /> (primary) | 0.5% | [0.5%, 0.6%] | 2 |
133+
| Regressions ❌ <br /> (secondary) | 2.1% | [2.1%, 2.1%] | 1 |
134+
| Improvements ✅ <br /> (primary) | - | - | 0 |
135+
| Improvements ✅ <br /> (secondary) | -1.3% | [-2.2%, -0.3%] | 4 |
136+
| All ❌✅ (primary) | 0.5% | [0.5%, 0.6%] | 2 |
137+
138+
* already triaged
139+
140+
Merge crossbeam-channel into `std::sync::mpsc` [#93563](https://github.com/rust-lang/rust/pull/93563) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=928d14bcd1976ffd33e743aa09c7c22a063bf87c&end=afd7977c850d9ce06f1dd2bebb40db8cc2224a51&stat=instructions:u)
141+
142+
| (instructions:u) | mean | range | count |
143+
|:----------------------------------:|:-----:|:--------------:|:-----:|
144+
| Regressions ❌ <br /> (primary) | 0.8% | [0.4%, 1.1%] | 5 |
145+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.5%, 0.5%] | 1 |
146+
| Improvements ✅ <br /> (primary) | -0.7% | [-1.1%, -0.3%] | 3 |
147+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
148+
| All ❌✅ (primary) | 0.2% | [-1.1%, 1.1%] | 8 |
149+
150+
* already triaged
151+
152+
#### Untriaged Pull Requests
153+
154+
- [#104017 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/104017)
155+
- [#103998 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/103998)
156+
- [#103975 Some tracing and comment cleanups](https://github.com/rust-lang/rust/pull/103975)
157+
- [#103965 resolve: More detailed effective visibility tracking for imports](https://github.com/rust-lang/rust/pull/103965)
158+
- [#103934 std: sync "Dependencies of the `backtrace` crate" with `backtrace`](https://github.com/rust-lang/rust/pull/103934)
159+
- [#103841 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/103841)
160+
- [#103650 rustdoc: change `.src-line-numbers > span` to `.src-line-numbers > a`](https://github.com/rust-lang/rust/pull/103650)
161+
- [#103562 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/103562)
162+
- [#103295 ci: Bring back ninja for dist builders](https://github.com/rust-lang/rust/pull/103295)
163+
- [#103071 Fix line numbers for MIR inlined code](https://github.com/rust-lang/rust/pull/103071)
164+
- [#102975 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/102975)
165+
- [#102915 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/102915)
166+
- [#102895 Get rid of `rustc_query_description!`](https://github.com/rust-lang/rust/pull/102895)
167+
- [#102867 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/102867)
168+
- [#102809 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/102809)
169+
- [#102548 Mark Cell::replace() as #[inline]](https://github.com/rust-lang/rust/pull/102548)
170+
- [#102026 Populate effective visibilities in 'rustc_resolve'](https://github.com/rust-lang/rust/pull/102026)
171+
- [#101858 derive various impls instead of hand-rolling them](https://github.com/rust-lang/rust/pull/101858)
172+
- [#101857 change `FnMutDelegate` to trait objects](https://github.com/rust-lang/rust/pull/101857)
173+
- [#101702 rustdoc: add hash to filename of toolchain files](https://github.com/rust-lang/rust/pull/101702)
174+
- [#101632 Remove `TypeckResults` from `InferCtxt`](https://github.com/rust-lang/rust/pull/101632)
175+
- [#101620 Compute lint levels by definition](https://github.com/rust-lang/rust/pull/101620)
176+
- [#101433 Emit a note that static bounds from HRTBs are a bug](https://github.com/rust-lang/rust/pull/101433)
177+
- [#100982 Require `#[const_trait]` on `Trait` for `impl const Trait`](https://github.com/rust-lang/rust/pull/100982)
178+
- [#100963 Rollup of 15 pull requests](https://github.com/rust-lang/rust/pull/100963)
179+
- [#100869 Replace `rustc_data_structures::thin_vec::ThinVec` with `thin_vec::ThinVec`](https://github.com/rust-lang/rust/pull/100869)
180+
- [#100841 update Miri](https://github.com/rust-lang/rust/pull/100841)
181+
- [#100759 Make `const_eval_select` a real intrinsic](https://github.com/rust-lang/rust/pull/100759)
182+
- [#100748 add `depth_limit` in `QueryVTable` to avoid entering a new tcx in `layout_of`](https://github.com/rust-lang/rust/pull/100748)
183+
- [#100676 implied bounds: explicitly state which types are assumed to be wf](https://github.com/rust-lang/rust/pull/100676)
184+

0 commit comments

Comments
 (0)