Skip to content

Commit 6b7b893

Browse files
KobzolKobzol
authored
Merge pull request #2177 from Mark-Simulacrum/triage
Add triage for this week
2 parents 257a88a + 42b0f5e commit 6b7b893

File tree

1 file changed

+186
-0
lines changed

1 file changed

+186
-0
lines changed

‎triage/2025/2025-06-30.md

Lines changed: 186 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,186 @@
1+
# 2025-06-30 Triage Log
2+
3+
Lots of changes this week with results dominated by the 1-5% improvements from
4+
[#142941](https://github.com/rust-lang/rust/pull/142941) across lots of primary
5+
benchmarks in the suite.
6+
7+
Triage done by **@simulacrum**.
8+
Revision range: [42245d34..ad3b7257](https://perf.rust-lang.org/?start=42245d34d22ade32b3f276dcf74deb826841594c&end=ad3b7257615c28aaf8212a189ec032b8af75de51&absolute=false&stat=instructions%3Au)
9+
10+
**Summary**:
11+
12+
| (instructions:u) | mean | range | count |
13+
|:----------------------------------:|:-----:|:---------------:|:-----:|
14+
| Regressions ❌ <br /> (primary) | 2.9% | [0.2%, 21.6%] | 16 |
15+
| Regressions ❌ <br /> (secondary) | 1.5% | [0.1%, 13.5%] | 38 |
16+
| Improvements ✅ <br /> (primary) | -0.9% | [-4.5%, -0.1%] | 99 |
17+
| Improvements ✅ <br /> (secondary) | -6.2% | [-67.9%, -0.1%] | 100 |
18+
| All ❌✅ (primary) | -0.4% | [-4.5%, 21.6%] | 115 |
19+
20+
3 Regressions, 6 Improvements, 5 Mixed; 4 of them in rollups
21+
39 artifact comparisons made in total
22+
23+
#### Regressions
24+
25+
Rollup of 10 pull requests [#143091](https://github.com/rust-lang/rust/pull/143091) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=13c46fd0b089360922a557d8e18a63a2c41dfbeb&end=fe5f3dedf7b4d6bea2cadb17343f747d70b4c66b&stat=instructions:u)
26+
27+
| (instructions:u) | mean | range | count |
28+
|:----------------------------------:|:-----:|:--------------:|:-----:|
29+
| Regressions ❌ <br /> (primary) | - | - | 0 |
30+
| Regressions ❌ <br /> (secondary) | 2.1% | [0.1%, 2.7%] | 7 |
31+
| Improvements ✅ <br /> (primary) | - | - | 0 |
32+
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.1%, -0.1%] | 1 |
33+
| All ❌✅ (primary) | - | - | 0 |
34+
35+
Regressions in ctfe and match stress tests, trying to find the PR that
36+
introduced them in case there's obvious tweaks, but not particularly
37+
noteworthy given the limited impact.
38+
39+
Rollup of 9 pull requests [#143116](https://github.com/rust-lang/rust/pull/143116) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=bdaba05a953eb5abeba0011cdda2560d157aed2e&end=d41e12f1f4e4884c356f319b881921aa37040de5&stat=instructions:u)
40+
41+
| (instructions:u) | mean | range | count |
42+
|:----------------------------------:|:----:|:------------:|:-----:|
43+
| Regressions ❌ <br /> (primary) | - | - | 0 |
44+
| Regressions ❌ <br /> (secondary) | 1.1% | [0.9%, 1.3%] | 9 |
45+
| Improvements ✅ <br /> (primary) | - | - | 0 |
46+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
47+
| All ❌✅ (primary) | - | - | 0 |
48+
49+
Regressions are in the `coercions` stress test, not clear which of the rolled
50+
up PRs caused it. Started one candidate perf run.
51+
52+
Rollup of 11 pull requests [#143173](https://github.com/rust-lang/rust/pull/143173) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=dddd7ab96229ea5f2ca96afcb5984a9831393a13&end=5ca574e85b67cec0a6fc3fddfe398cbe676c9c69&stat=instructions:u)
53+
54+
| (instructions:u) | mean | range | count |
55+
|:----------------------------------:|:----:|:------------:|:-----:|
56+
| Regressions ❌ <br /> (primary) | 0.5% | [0.3%, 0.7%] | 2 |
57+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
58+
| Improvements ✅ <br /> (primary) | - | - | 0 |
59+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
60+
| All ❌✅ (primary) | 0.5% | [0.3%, 0.7%] | 2 |
61+
62+
Likely due to [#142641](https://github.com/rust-lang/rust/pull/142641) which
63+
added extra work to proc-macro crates, which are the benchmarks affected here.
64+
65+
#### Improvements
66+
67+
Encode hir attributes cross-crate properly [#142777](https://github.com/rust-lang/rust/pull/142777) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d14d202262d13df896b0c624b0cec6e4bfde631a&end=0fa4ec6cde46fa17ab07acb5531cfe0dc1349ffa&stat=instructions:u)
68+
69+
| (instructions:u) | mean | range | count |
70+
|:----------------------------------:|:-----:|:--------------:|:-----:|
71+
| Regressions ❌ <br /> (primary) | - | - | 0 |
72+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
73+
| Improvements ✅ <br /> (primary) | -0.4% | [-1.4%, -0.1%] | 16 |
74+
| Improvements ✅ <br /> (secondary) | -0.6% | [-1.3%, -0.2%] | 20 |
75+
| All ❌✅ (primary) | -0.4% | [-1.4%, -0.1%] | 16 |
76+
77+
78+
Rollup of 8 pull requests [#143057](https://github.com/rust-lang/rust/pull/143057) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b03b3a7ec92682be2917540b679478d41c95a30c&end=513999b936c37902120380f4171963d1f1d80347&stat=instructions:u)
79+
80+
| (instructions:u) | mean | range | count |
81+
|:----------------------------------:|:-----:|:--------------:|:-----:|
82+
| Regressions ❌ <br /> (primary) | - | - | 0 |
83+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
84+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.4%, -0.3%] | 3 |
85+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
86+
| All ❌✅ (primary) | -0.4% | [-0.4%, -0.3%] | 3 |
87+
88+
89+
Fast path for WF goals in new solver [#142223](https://github.com/rust-lang/rust/pull/142223) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e61dd437f33b5a640e67dc3628397689c664c17f&end=df32e15c56f582eb2bdde07711af6271f2ae660b&stat=instructions:u)
90+
91+
| (instructions:u) | mean | range | count |
92+
|:----------------------------------:|:-----:|:--------------:|:-----:|
93+
| Regressions ❌ <br /> (primary) | - | - | 0 |
94+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
95+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.4%, -0.1%] | 8 |
96+
| Improvements ✅ <br /> (secondary) | -1.5% | [-3.5%, -0.3%] | 13 |
97+
| All ❌✅ (primary) | -0.2% | [-0.4%, -0.1%] | 8 |
98+
99+
100+
Collapse Analysis|Borrowck|PostBorrowckAnalysis when there are no opaques [#142802](https://github.com/rust-lang/rust/pull/142802) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ed2d759783dc9de134bbb3f01085b1e6dbf539f3&end=35f6036521777bdc0dcea1f980be4c192962a168&stat=instructions:u)
101+
102+
| (instructions:u) | mean | range | count |
103+
|:----------------------------------:|:-----:|:--------------:|:-----:|
104+
| Regressions ❌ <br /> (primary) | - | - | 0 |
105+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.1%, 0.2%] | 2 |
106+
| Improvements ✅ <br /> (primary) | - | - | 0 |
107+
| Improvements ✅ <br /> (secondary) | -2.4% | [-7.5%, -0.5%] | 14 |
108+
| All ❌✅ (primary) | - | - | 0 |
109+
110+
111+
Shallowly bail from `coerce_unsized` more [#142941](https://github.com/rust-lang/rust/pull/142941) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=35f6036521777bdc0dcea1f980be4c192962a168&end=f19142044f270760ce0ebc03b2c3a44217d8703d&stat=instructions:u)
112+
113+
| (instructions:u) | mean | range | count |
114+
|:----------------------------------:|:-----:|:---------------:|:-----:|
115+
| Regressions ❌ <br /> (primary) | - | - | 0 |
116+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.8%, 0.8%] | 1 |
117+
| Improvements ✅ <br /> (primary) | -0.8% | [-4.6%, -0.2%] | 84 |
118+
| Improvements ✅ <br /> (secondary) | -5.6% | [-21.6%, -0.1%] | 71 |
119+
| All ❌✅ (primary) | -0.8% | [-4.6%, -0.2%] | 84 |
120+
121+
122+
#### Mixed
123+
124+
update to literal-escaper 0.0.4 for better API without `unreachable` and faster string parsing [#140999](https://github.com/rust-lang/rust/pull/140999) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=3de5b08ef6b260277dd4c77f7472fe6904bd6002&end=2c2bb995af398383e3b93b859302bdc447ca7a7c&stat=instructions:u)
125+
126+
| (instructions:u) | mean | range | count |
127+
|:----------------------------------:|:-----:|:--------------:|:-----:|
128+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.3%] | 3 |
129+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.3%] | 1 |
130+
| Improvements ✅ <br /> (primary) | - | - | 0 |
131+
| Improvements ✅ <br /> (secondary) | -0.7% | [-1.2%, -0.4%] | 16 |
132+
| All ❌✅ (primary) | 0.2% | [0.2%, 0.3%] | 3 |
133+
134+
Regressions limited to stm32f4, some mild improvements, doesn't seem worth
135+
further investigation.
136+
137+
Stop collecting unmentioned constants [#142893](https://github.com/rust-lang/rust/pull/142893) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d51b6f97122671c5de27cfc08cded235357e0d97&end=13c46fd0b089360922a557d8e18a63a2c41dfbeb&stat=instructions:u)
138+
139+
| (instructions:u) | mean | range | count |
140+
|:----------------------------------:|:------:|:----------------:|:-----:|
141+
| Regressions ❌ <br /> (primary) | 19.2% | [17.2%, 21.2%] | 2 |
142+
| Regressions ❌ <br /> (secondary) | 9.1% | [6.0%, 13.4%] | 5 |
143+
| Improvements ✅ <br /> (primary) | -1.6% | [-2.3%, -0.8%] | 8 |
144+
| Improvements ✅ <br /> (secondary) | -67.8% | [-67.9%, -67.8%] | 2 |
145+
| All ❌✅ (primary) | 2.6% | [-2.3%, 21.2%] | 10 |
146+
147+
Regressed benchmarks are incremental scenarios which have changed codegen units
148+
-- overall, this is an improvement in the typical case.
149+
150+
Don't fold in Instantiate when there's nothing to fold [#142317](https://github.com/rust-lang/rust/pull/142317) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b63223c152212832ce37a109e26cc5f84c577532&end=7ba34c704529e7fcab80130c3fe40efe415d61b5&stat=instructions:u)
151+
152+
| (instructions:u) | mean | range | count |
153+
|:----------------------------------:|:-----:|:--------------:|:-----:|
154+
| Regressions ❌ <br /> (primary) | 0.2% | [0.1%, 0.3%] | 9 |
155+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
156+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.3%, -0.1%] | 3 |
157+
| Improvements ✅ <br /> (secondary) | -2.6% | [-2.9%, -2.4%] | 6 |
158+
| All ❌✅ (primary) | 0.1% | [-0.3%, 0.3%] | 12 |
159+
160+
Some mixed results from this but improvements were deemed as outweighing the
161+
regressions ([comment](https://github.com/rust-lang/rust/pull/142317#issuecomment-2964689882)).
162+
163+
Only compute recursive callees once. [#142625](https://github.com/rust-lang/rust/pull/142625) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7ba34c704529e7fcab80130c3fe40efe415d61b5&end=11ad40bb839ca16f74784b4ab72596ad85587298&stat=instructions:u)
164+
165+
| (instructions:u) | mean | range | count |
166+
|:----------------------------------:|:-----:|:--------------:|:-----:|
167+
| Regressions ❌ <br /> (primary) | 0.4% | [0.3%, 0.6%] | 3 |
168+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.3%] | 2 |
169+
| Improvements ✅ <br /> (primary) | -1.3% | [-2.5%, -0.2%] | 2 |
170+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
171+
| All ❌✅ (primary) | -0.3% | [-2.5%, 0.6%] | 5 |
172+
173+
Per the PR description makes some intentional tradeoffs between two variants of
174+
implementation and is overall an improvement or neutral.
175+
176+
Stop backends from needing to support nullary intrinsics [#142839](https://github.com/rust-lang/rust/pull/142839) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f19142044f270760ce0ebc03b2c3a44217d8703d&end=ad3b7257615c28aaf8212a189ec032b8af75de51&stat=instructions:u)
177+
178+
| (instructions:u) | mean | range | count |
179+
|:----------------------------------:|:-----:|:--------------:|:-----:|
180+
| Regressions ❌ <br /> (primary) | 2.7% | [2.7%, 2.7%] | 1 |
181+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
182+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.3%] | 5 |
183+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
184+
| All ❌✅ (primary) | 0.2% | [-0.4%, 2.7%] | 6 |
185+
186+
Some slight changes, no particularly significant changes.

0 commit comments

Comments
 (0)