Add constants for benchmark request type strings

Author: Kobzol

database/src/lib.rs

@@ -849,6 +849,10 @@ impl<'a> tokio_postgres::types::FromSql<'a> for BenchmarkRequestStatus {
     }
 }
 
+const BENCHMARK_REQUEST_TRY_STR: &str = "try";
+const BENCHMARK_REQUEST_MASTER_STR: &str = "master";
+const BENCHMARK_REQUEST_RELEASE_STR: &str = "release";
+
 #[derive(Debug, Clone, PartialEq)]
 pub enum BenchmarkRequestType {
     /// A Try commit
@@ -870,9 +874,9 @@ pub enum BenchmarkRequestType {
 impl fmt::Display for BenchmarkRequestType {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self {
-            BenchmarkRequestType::Try { .. } => write!(f, "try"),
-            BenchmarkRequestType::Master { .. } => write!(f, "master"),
-            BenchmarkRequestType::Release { .. } => write!(f, "release"),
+            BenchmarkRequestType::Try { .. } => write!(f, "{BENCHMARK_REQUEST_TRY_STR}"),
+            BenchmarkRequestType::Master { .. } => write!(f, "{BENCHMARK_REQUEST_MASTER_STR}"),
+            BenchmarkRequestType::Release { .. } => write!(f, "{BENCHMARK_REQUEST_RELEASE_STR}"),
         }
     }
 }

database/src/pool/postgres.rs

@@ -3,6 +3,7 @@ use crate::{
     ArtifactCollection, ArtifactId, ArtifactIdNumber, Benchmark, BenchmarkRequest,
     BenchmarkRequestStatus, BenchmarkRequestType, CodegenBackend, CollectionId, Commit, CommitType,
     CompileBenchmark, Date, Index, Profile, QueuedCommit, Scenario, Target,
+    BENCHMARK_REQUEST_MASTER_STR, BENCHMARK_REQUEST_RELEASE_STR, BENCHMARK_REQUEST_TRY_STR,
 };
 use anyhow::Context as _;
 use chrono::{DateTime, TimeZone, Utc};
@@ -1463,7 +1464,7 @@ where
                 let profiles = row.get::<_, &str>(8);
 
                 match commit_type {
-                    "try" => {
+                    BENCHMARK_REQUEST_TRY_STR => {
                         let mut try_benchmark = BenchmarkRequest::create_try(
                             tag,
                             parent_sha,
@@ -1476,7 +1477,7 @@ where
                         try_benchmark.completed_at = completed_at;
                         try_benchmark
                     }
-                    "master" => {
+                    BENCHMARK_REQUEST_MASTER_STR => {
                         let mut master_benchmark = BenchmarkRequest::create_master(
                             tag.expect("Master commit in DB without SHA"),
                             parent_sha.unwrap(),
@@ -1489,7 +1490,7 @@ where
                         master_benchmark.completed_at = completed_at;
                         master_benchmark
                     }
-                    "release" => {
+                    BENCHMARK_REQUEST_RELEASE_STR => {
                         let mut release_benchmark = BenchmarkRequest::create_release(
                             tag.expect("Release commit in DB witohut SHA"),
                             created_at,