Skip to content

Commit 8d563ce

Browse files
KobzolKobzol
authored
Merge pull request #1625 from Mark-Simulacrum/triage
Add triage for this week
2 parents 47972d8 + 4551586 commit 8d563ce

File tree

1 file changed

+195
-0
lines changed

1 file changed

+195
-0
lines changed

‎triage/2023-06-27.md

Lines changed: 195 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,195 @@
1+
# 2023-06-27 Triage Log
2+
3+
Relatively quiet week outside of a large win on one incremental benchmark in a
4+
regression test (i.e., not real world code). Bimodality in a number of
5+
benchmarks continues to be an issue.
6+
7+
Triage done by **@simulacrum**.
8+
Revision range: [b9d608c979ad3c0700f9f0237a8c12feb0ba44fb..b5e51db16dfbf5685e32dfe2d9a835a5c695afe4](https://perf.rust-lang.org/?start=b9d608c979ad3c0700f9f0237a8c12feb0ba44fb&end=b5e51db16dfbf5685e32dfe2d9a835a5c695afe4&absolute=false&stat=instructions%3Au)
9+
10+
**Summary**:
11+
12+
| (instructions:u) | mean | range | count |
13+
|:----------------------------------:|:------:|:---------------:|:-----:|
14+
| Regressions ❌ <br /> (primary) | 1.0% | [0.4%, 3.7%] | 186 |
15+
| Regressions ❌ <br /> (secondary) | 1.1% | [0.2%, 3.0%] | 95 |
16+
| Improvements ✅ <br /> (primary) | -1.9% | [-3.7%, -0.9%] | 3 |
17+
| Improvements ✅ <br /> (secondary) | -16.1% | [-78.8%, -0.3%] | 5 |
18+
| All ❌✅ (primary) | 0.9% | [-3.7%, 3.7%] | 189 |
19+
20+
21+
5 Regressions, 6 Improvements, 3 Mixed; 5 of them in rollups
22+
44 artifact comparisons made in total
23+
24+
#### Regressions
25+
26+
proof tree nits [#112835](https://github.com/rust-lang/rust/pull/112835) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a34ceade11f62bdef20b86ef37949d3fe00944ef&end=46514218f6f31ad3a1510ecc32af47e9e486c27d&stat=instructions:u)
27+
28+
| (instructions:u) | mean | range | count |
29+
|:----------------------------------:|:----:|:------------:|:-----:|
30+
| Regressions ❌ <br /> (primary) | 0.7% | [0.3%, 0.9%] | 7 |
31+
| Regressions ❌ <br /> (secondary) | 1.2% | [0.5%, 1.7%] | 10 |
32+
| Improvements ✅ <br /> (primary) | - | - | 0 |
33+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
34+
| All ❌✅ (primary) | 0.7% | [0.3%, 0.9%] | 7 |
35+
36+
The regression in diesel seems to have persisted in future commits, but PR
37+
authors note that the code changed in this PR is not expected to affect
38+
benchmarks, so it is likely to be optimizer noise of some kind.
39+
40+
Disable two mir opts that are known to be unsound [#112834](https://github.com/rust-lang/rust/pull/112834) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=97bf23d26b1ffff46f071aa687945a6cf85a5914&end=38b44eb2335885844137f918c44c437f5a8da951&stat=instructions:u)
41+
42+
| (instructions:u) | mean | range | count |
43+
|:----------------------------------:|:-----:|:--------------:|:-----:|
44+
| Regressions ❌ <br /> (primary) | 0.4% | [0.3%, 0.9%] | 48 |
45+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.2%, 1.1%] | 30 |
46+
| Improvements ✅ <br /> (primary) | - | - | 0 |
47+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.3%, -0.1%] | 2 |
48+
| All ❌✅ (primary) | 0.4% | [0.3%, 0.9%] | 48 |
49+
50+
Regression on multiple benchmarks, seems to be real, likely to be expected with
51+
disabling of optimization passes.
52+
53+
Inline before merging cgus [#112695](https://github.com/rust-lang/rust/pull/112695) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0928a1f7574f5ca019b5443b3a90008588d18c8c&end=fa06a371b715f137c952577cfded4e49cb7e76c4&stat=instructions:u)
54+
55+
| (instructions:u) | mean | range | count |
56+
|:----------------------------------:|:-----:|:--------------:|:-----:|
57+
| Regressions ❌ <br /> (primary) | 0.5% | [0.2%, 3.6%] | 98 |
58+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.3%, 2.7%] | 37 |
59+
| Improvements ✅ <br /> (primary) | -1.0% | [-1.2%, -0.9%] | 2 |
60+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 2 |
61+
| All ❌✅ (primary) | 0.5% | [-1.2%, 3.6%] | 100 |
62+
63+
Instruction counts (shown in this table) are not the best metric for this
64+
change. See [comment](https://github.com/rust-lang/rust/pull/112695#issuecomment-1603381738)
65+
on the PR with more details for why this change makes sense.
66+
67+
Rollup of 9 pull requests [#112957](https://github.com/rust-lang/rust/pull/112957) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fe37f37e4b764bb82fc0eb8c727842746de7c93f&end=54d6738a8df74382c439e1dfb9ce4e2382d7742e&stat=instructions:u)
68+
69+
| (instructions:u) | mean | range | count |
70+
|:----------------------------------:|:----:|:------------:|:-----:|
71+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.3%] | 8 |
72+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.4%, 0.4%] | 4 |
73+
| Improvements ✅ <br /> (primary) | - | - | 0 |
74+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
75+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.3%] | 8 |
76+
77+
Regressions are limited to subset of incremental benchmarks, multiple of which
78+
are benchmarks prone to bimodality, with relatively low significance factors.
79+
No further investigation warranted.
80+
81+
Rollup of 2 pull requests [#113057](https://github.com/rust-lang/rust/pull/113057) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6f8c27ae89dfd32895419d7ef5b89844bcad1bcd&end=36fb58e433c782e27dd41034284e157cf86d587f&stat=instructions:u)
82+
83+
| (instructions:u) | mean | range | count |
84+
|:----------------------------------:|:----:|:------------:|:-----:|
85+
| Regressions ❌ <br /> (primary) | 0.5% | [0.4%, 0.8%] | 5 |
86+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.3%, 1.1%] | 12 |
87+
| Improvements ✅ <br /> (primary) | - | - | 0 |
88+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
89+
| All ❌✅ (primary) | 0.5% | [0.4%, 0.8%] | 5 |
90+
91+
See [comment](https://github.com/rust-lang/rust/pull/113057#issuecomment-1608561630) for details.
92+
93+
#### Improvements
94+
95+
Avoid `Lrc<Box<dyn CodegenBackend>>`. [#112913](https://github.com/rust-lang/rust/pull/112913) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fa06a371b715f137c952577cfded4e49cb7e76c4&end=2efe09170530fa18e42ff05b8d9dd23f00b5c430&stat=instructions:u)
96+
97+
| (instructions:u) | mean | range | count |
98+
|:----------------------------------:|:-----:|:--------------:|:-----:|
99+
| Regressions ❌ <br /> (primary) | - | - | 0 |
100+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
101+
| Improvements ✅ <br /> (primary) | - | - | 0 |
102+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.4%, -0.2%] | 10 |
103+
| All ❌✅ (primary) | - | - | 0 |
104+
105+
106+
rustc_session: default to -Z plt=yes on non-x86_64 [#109982](https://github.com/rust-lang/rust/pull/109982) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=54d6738a8df74382c439e1dfb9ce4e2382d7742e&end=c79d6be6a287dcda55236fa6438286d16ec990ae&stat=instructions:u)
107+
108+
| (instructions:u) | mean | range | count |
109+
|:----------------------------------:|:-----:|:--------------:|:-----:|
110+
| Regressions ❌ <br /> (primary) | - | - | 0 |
111+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
112+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.2%] | 5 |
113+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.6%, -0.3%] | 3 |
114+
| All ❌✅ (primary) | -0.3% | [-0.3%, -0.2%] | 5 |
115+
116+
117+
Rollup of 5 pull requests [#113014](https://github.com/rust-lang/rust/pull/113014) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f7ca9df69549470541fbf542f87a03eb9ed024b6&end=7b9b1277009c407010298bd2f195f83af31fd06b&stat=instructions:u)
118+
119+
| (instructions:u) | mean | range | count |
120+
|:----------------------------------:|:-----:|:--------------:|:-----:|
121+
| Regressions ❌ <br /> (primary) | - | - | 0 |
122+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
123+
| Improvements ✅ <br /> (primary) | -0.7% | [-1.2%, -0.4%] | 39 |
124+
| Improvements ✅ <br /> (secondary) | -0.6% | [-0.9%, -0.3%] | 20 |
125+
| All ❌✅ (primary) | -0.7% | [-1.2%, -0.4%] | 39 |
126+
127+
128+
Do not emit coerce_suggestions for expr from destructuring assignment desugaring [#112476](https://github.com/rust-lang/rust/pull/112476) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7b9b1277009c407010298bd2f195f83af31fd06b&end=3c5d71a99dd5ece7f6c87ca80b0adb1637c3b11a&stat=instructions:u)
129+
130+
| (instructions:u) | mean | range | count |
131+
|:----------------------------------:|:-----:|:--------------:|:-----:|
132+
| Regressions ❌ <br /> (primary) | - | - | 0 |
133+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
134+
| Improvements ✅ <br /> (primary) | -0.6% | [-0.8%, -0.5%] | 6 |
135+
| Improvements ✅ <br /> (secondary) | -1.0% | [-1.1%, -1.0%] | 4 |
136+
| All ❌✅ (primary) | -0.6% | [-0.8%, -0.5%] | 6 |
137+
138+
139+
Move windows-sys arm32 shim to c.rs [#113001](https://github.com/rust-lang/rust/pull/113001) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0d03812e2424b324d067d89852ad925d2eecb53e&end=c51fbb3dd3a75fd43d51c0c29ca645c3dac99aae&stat=instructions:u)
140+
141+
| (instructions:u) | mean | range | count |
142+
|:----------------------------------:|:-----:|:--------------:|:-----:|
143+
| Regressions ❌ <br /> (primary) | - | - | 0 |
144+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
145+
| Improvements ✅ <br /> (primary) | -0.7% | [-0.7%, -0.7%] | 1 |
146+
| Improvements ✅ <br /> (secondary) | -1.2% | [-1.3%, -1.1%] | 6 |
147+
| All ❌✅ (primary) | -0.7% | [-0.7%, -0.7%] | 1 |
148+
149+
150+
Rollup of 6 pull requests [#113049](https://github.com/rust-lang/rust/pull/113049) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=25b5af1b3a0b9e2c0c57b223b2d0e3e203869b2c&end=27e10c5292eee22abef69aed7144f80bdea00603&stat=instructions:u)
151+
152+
| (instructions:u) | mean | range | count |
153+
|:----------------------------------:|:-----:|:--------------:|:-----:|
154+
| Regressions ❌ <br /> (primary) | - | - | 0 |
155+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
156+
| Improvements ✅ <br /> (primary) | -0.8% | [-1.2%, -0.5%] | 17 |
157+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
158+
| All ❌✅ (primary) | -0.8% | [-1.2%, -0.5%] | 17 |
159+
160+
161+
#### Mixed
162+
163+
Rollup of 6 pull requests [#112877](https://github.com/rust-lang/rust/pull/112877) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=67da586efe13aa66eef576ba095e1875ba65fd20&end=97bf23d26b1ffff46f071aa687945a6cf85a5914&stat=instructions:u)
164+
165+
| (instructions:u) | mean | range | count |
166+
|:----------------------------------:|:------:|:----------------:|:-----:|
167+
| Regressions ❌ <br /> (primary) | 0.4% | [0.4%, 0.4%] | 4 |
168+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.2%] | 2 |
169+
| Improvements ✅ <br /> (primary) | -2.9% | [-2.9%, -2.9%] | 1 |
170+
| Improvements ✅ <br /> (secondary) | -78.9% | [-78.9%, -78.9%] | 1 |
171+
| All ❌✅ (primary) | -0.3% | [-2.9%, 0.4%] | 5 |
172+
173+
174+
Various impl trait in assoc tys cleanups [#112891](https://github.com/rust-lang/rust/pull/112891) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=22e9fe644ea710eec50cb0aabcae7fa8dd9fd675&end=1d67eba6873b1d551a259a0bbc1e2651b4443e12&stat=instructions:u)
175+
176+
| (instructions:u) | mean | range | count |
177+
|:----------------------------------:|:-----:|:--------------:|:-----:|
178+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.3%] | 1 |
179+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.6%, 0.7%] | 2 |
180+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.7%, -0.4%] | 6 |
181+
| Improvements ✅ <br /> (secondary) | -1.0% | [-1.3%, -0.6%] | 8 |
182+
| All ❌✅ (primary) | -0.4% | [-0.7%, 0.3%] | 7 |
183+
184+
Performance is mixed, but the cleanups are useful in their own right. Marking
185+
as triaged.
186+
187+
Specialize `StepBy<Range<{integer}>>` [#111850](https://github.com/rust-lang/rust/pull/111850) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7f01f030613fb6ffe06d5f5791a273d384cd6f55&end=ae8ffa663c913551c462fd2e07705be730a4ea07&stat=instructions:u)
188+
189+
| (instructions:u) | mean | range | count |
190+
|:----------------------------------:|:-----:|:--------------:|:-----:|
191+
| Regressions ❌ <br /> (primary) | - | - | 0 |
192+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.5%, 0.7%] | 3 |
193+
| Improvements ✅ <br /> (primary) | -1.7% | [-2.1%, -1.4%] | 2 |
194+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.6%, -0.4%] | 6 |
195+
| All ❌✅ (primary) | -1.7% | [-2.1%, -1.4%] | 2 |

0 commit comments

Comments
 (0)